NewPagesPager: Fix namespace query conditions
authorDannyS712 <DannyS712.enwiki@gmail.com>
Tue, 17 Dec 2019 06:22:57 +0000 (06:22 +0000)
committerJforrester <jforrester@wikimedia.org>
Tue, 17 Dec 2019 15:50:40 +0000 (15:50 +0000)
Bug: T240924
Change-Id: I28d276cae0518386cac3f9d571ba09e9eff6678b
(cherry picked from commit b390ef6e5825e8906667d7a755d70b3478ce47b7)

includes/specials/pagers/NewPagesPager.php

index c50563d..95f67d5 100644 (file)
@@ -139,15 +139,18 @@ class NewPagesPager extends ReverseChronologicalPager {
                $eq_op = $invert ? '!=' : '=';
                $bool_op = $invert ? 'AND' : 'OR';
 
+               $selectedNS = $this->mDb->addQuotes( $namespace );
                if ( !$associated ) {
-                       return [ "rc_namespace $eq_op " . $this->mDb->addQuotes( $namespace ) ];
+                       return [ "rc_namespace $eq_op $selectedNS" ];
                }
 
-               $associatedNS = MediaWikiServices::getInstance()->getNamespaceInfo()->getAssociated( $namespace );
+               $associatedNS = $this->mDb->addQuotes(
+                       MediaWikiServices::getInstance()->getNamespaceInfo()->getAssociated( $namespace )
+               );
                return [
-                       "rc_namespace $eq_op " . $this->mDb->addQuotes( $namespace ) .
+                       "rc_namespace $eq_op $selectedNS " .
                        $bool_op .
-                       " rc_namespace $eq_op " . $this->mDb->addQuotes( $associatedNS )
+                       " rc_namespace $eq_op $associatedNS"
                ];
        }