rdbms: make LBFactory close/rollback dangling handles like LoadBalancer

The application is expected to call shutdown(), so do not commit if that
never happens, which usually indicates some sort of severe error. This
should avoid "already closed" errors that pile on top of uncaught errors.

Bug: T225103
Bug: T230065
Change-Id: I1bdfe87c47bcc2537d0dfc518f7212c2c9bf21d2

diff --git a/includes/libs/rdbms/lbfactory/LBFactory.php b/includes/libs/rdbms/lbfactory/LBFactory.php
index 4426654..77467f0 100644 (file)
--- a/includes/libs/rdbms/lbfactory/LBFactory.php
+++ b/includes/libs/rdbms/lbfactory/LBFactory.php
@@ -160,7 +160,6 @@ abstract class LBFactory implements ILBFactory {
        }
 
        public function destroy() {
-               $this->shutdown( self::SHUTDOWN_NO_CHRONPROT );
                $this->forEachLBCallMethod( 'disable' );
        }