Address an edge case - input being null. Add test cases.

diff --git a/languages/Language.php b/languages/Language.php
index b204626..691c43b 100644 (file)
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -2729,6 +2729,9 @@ class Language {
         */
        function commafy( $_ ) {
                $digitGroupingPattern = $this->digitGroupingPattern();
+               if ( $_ === null ) {
+                       return '';
+               }
 
                if ( !$digitGroupingPattern || $digitGroupingPattern === "###,###,###" ) {
                        // default grouping is at thousands,  use the same for ###,###,### pattern too.

diff --git a/tests/phpunit/languages/LanguageMlTest.php b/tests/phpunit/languages/LanguageMlTest.php
index 45091db..6e93524 100644 (file)
--- a/tests/phpunit/languages/LanguageMlTest.php
+++ b/tests/phpunit/languages/LanguageMlTest.php
@@ -30,5 +30,7 @@ class LanguageMlTest extends MediaWikiTestCase {
                $this->assertEquals( '-98', $this->lang->formatNum( '-98' ) );
                $this->assertEquals( '-98', $this->lang->formatNum( -98 ) );
                $this->assertEquals( '-1,23,45,678', $this->lang->formatNum( -12345678 ) );
+               $this->assertEquals( '', $this->lang->formatNum( '' ) );
+               $this->assertEquals( '', $this->lang->formatNum( null ) );
        }
 }