Sanity check hideminor param; fix the hide link in rc

diff --git a/includes/SpecialRecentchanges.php b/includes/SpecialRecentchanges.php
index 74282bb..1e3a93d 100644 (file)
--- a/includes/SpecialRecentchanges.php
+++ b/includes/SpecialRecentchanges.php
@@ -49,25 +49,25 @@ function wfSpecialRecentchanges( $par )
        if ( ! isset( $hideminor ) ) {
                $hideminor = $wgUser->getOption( "hideminor" );
        }
+       $hideminor = ($hideminor ? 1 : 0);
        if ( $hideminor ) {
                $hidem = "AND rc_minor=0";
-                $mltitle = wfMsg( "show" );
-                $mlhide = 0;
-
+               $mltitle = wfMsg( "show" );
+               $mlhide = 0;
        } else {
                $hidem = "";
-                $mltitle = wfMsg( "hide" );
-                $mlhide = 1;
+               $mltitle = wfMsg( "hide" );
+               $mlhide = 1;
        }
 
-        if ( isset( $from ) ) {
-          $mlparams = "from={$from}&hideminor={$mlhide}";
-        } else {
-          $mlparams = "days={$days}&limit={$limit}&hideminor=0";
-        }
+       if ( isset( $from ) ) {
+               $mlparams = "from={$from}&hideminor={$mlhide}";
+       } else {
+               $mlparams = "days={$days}&limit={$limit}&hideminor={$mlhide}";
+       }
 
-        $mlink = $sk->makeKnownLink( $wgLang->specialPage( "Recentchanges" ),
-                                     $mltitle, $mlparams );
+       $mlink = $sk->makeKnownLink( $wgLang->specialPage( "Recentchanges" ),
+               $mltitle, $mlparams );
        
        if ( !isset( $hidebots ) ) {
                $hidebots = 1;

diff --git a/includes/SpecialRecentchangeslinked.php b/includes/SpecialRecentchangeslinked.php
index af30777..b2c568e 100644 (file)
--- a/includes/SpecialRecentchangeslinked.php
+++ b/includes/SpecialRecentchangeslinked.php
@@ -28,6 +28,7 @@ function wfSpecialRecentchangeslinked( $par = NULL )
        list( $limit, $offset ) = wfCheckLimits( 100, "rclimit" );
        $cutoff = wfUnix2Timestamp( time() - ( $days * 86400 ) );
 
+       $hideminor = ($hideminor ? 1 : 0);
        if ( $hideminor ) {
                $mlink = $sk->makeKnownLink( $wgLang->specialPage( "Recentchangeslinked" ),
                  WfMsg( "show" ), "target=" . wfEscapeHTML( $nt->getPrefixedURL() ) .