when a value is selected, hide the 'time' entry field

diff --git a/includes/SpecialBlockip.php b/includes/SpecialBlockip.php
index 98a4af2..f1ea7cd 100644 (file)
--- a/includes/SpecialBlockip.php
+++ b/includes/SpecialBlockip.php
@@ -83,6 +83,7 @@ class IPBlockForm {
 
                $blockExpiryFormOptions = "<option value=\"other\">$mIpbothertime</option>";
                foreach (explode(',', $scBlockExpiryOptions) as $option) {
+                       if (strstr($option, ":")) $option = "$option:$option";
                        list($show, $value) = explode(":", $option);
                        $show = htmlspecialchars($show);
                        $value = htmlspecialchars($value);
@@ -108,7 +109,7 @@ class IPBlockForm {
                        $wgOut->addHTML("
                        <td align=\"right\">{$mIpbexpiry}:</td>
                        <td align=\"left\">
-                               <select tabindex='2' name=\"wpBlockExpiry\">
+                               <select tabindex='2' id='wpBlockExpiry' name=\"wpBlockExpiry\" onchange=\"considerChangingExpiryFocus()\">
                                        $blockExpiryFormOptions
                                </select>
                        </td>
@@ -116,7 +117,7 @@ class IPBlockForm {
                }
                $wgOut->addHTML("
                </tr>
-               <tr>
+               <tr id='wpBlockOther'>
                        <td align=\"right\">{$mIpbother}:</td>
                        <td align=\"left\">
                                <input tabindex='3' type='text' size='40' name=\"wpBlockOther\" value=\"{$scBlockOtherTime}\" />

diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js
index c251c78..249f720 100644 (file)
--- a/skins/common/wikibits.js
+++ b/skins/common/wikibits.js
@@ -485,3 +485,16 @@ function fillDestFilename() {
        document.fname = fname;
 }
        
+
+function considerChangingExpiryFocus() {
+       if (!document.getElementById) return;
+       var drop = document.getElementById('wpBlockExpiry');
+       if (!drop) return;
+       var field = document.getElementById('wpBlockOther');
+       if (!field) return;
+       var opt = drop.value;
+       if (opt == 'other')
+               field.style.display = '';
+       else
+               field.style.display = 'none';
+}