Make SpecialPageTestBase always call parent::tearDown
authorAryeh Gregor <ayg@aryeh.name>
Mon, 8 Oct 2018 16:54:32 +0000 (19:54 +0300)
committerAryeh Gregor <ayg@aryeh.name>
Mon, 8 Oct 2018 16:54:32 +0000 (19:54 +0300)
Change-Id: Ifc244d5117e7da4bf46cdf273eca9fc4ae5c3a42

tests/phpunit/includes/specials/SpecialPageTestBase.php

index 4809e1b..fc9e2f0 100644 (file)
@@ -28,13 +28,15 @@ abstract class SpecialPageTestBase extends MediaWikiTestCase {
                        ob_end_clean();
                }
 
-               if ( $obLevel !== $this->obLevel ) {
-                       $this->fail(
-                               "Test changed output buffer level: was {$this->obLevel} before test, but $obLevel after test."
-                       );
+               try {
+                       if ( $obLevel !== $this->obLevel ) {
+                               $this->fail(
+                                       "Test changed output buffer level: was {$this->obLevel} before test, but $obLevel after test."
+                               );
+                       }
+               } finally {
+                       parent::tearDown();
                }
-
-               parent::tearDown();
        }
 
        /**