From 81c165b84f3fca524ed890801f36a17204bf06c8 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Fri, 28 Jun 2019 13:20:04 -0700 Subject: [PATCH] rdbms: update return type comments for ConnectionManager to IDatabase Change-Id: I0ed1fc7b2c22192d80b99df54444a904c1778d05 --- includes/libs/rdbms/connectionmanager/ConnectionManager.php | 6 +++--- .../SessionConsistentConnectionManager.php | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/includes/libs/rdbms/connectionmanager/ConnectionManager.php b/includes/libs/rdbms/connectionmanager/ConnectionManager.php index 27e6138102..50a0b0e1f8 100644 --- a/includes/libs/rdbms/connectionmanager/ConnectionManager.php +++ b/includes/libs/rdbms/connectionmanager/ConnectionManager.php @@ -73,7 +73,7 @@ class ConnectionManager { * @param int $i * @param string[]|null $groups * - * @return Database + * @return IDatabase */ private function getConnection( $i, array $groups = null ) { $groups = $groups === null ? $this->groups : $groups; @@ -97,7 +97,7 @@ class ConnectionManager { * * @since 1.29 * - * @return Database + * @return IDatabase */ public function getWriteConnection() { return $this->getConnection( DB_MASTER ); @@ -111,7 +111,7 @@ class ConnectionManager { * * @param string[]|null $groups * - * @return Database + * @return IDatabase */ public function getReadConnection( array $groups = null ) { $groups = $groups === null ? $this->groups : $groups; diff --git a/includes/libs/rdbms/connectionmanager/SessionConsistentConnectionManager.php b/includes/libs/rdbms/connectionmanager/SessionConsistentConnectionManager.php index aa3bea8fdc..ccb73d7256 100644 --- a/includes/libs/rdbms/connectionmanager/SessionConsistentConnectionManager.php +++ b/includes/libs/rdbms/connectionmanager/SessionConsistentConnectionManager.php @@ -64,7 +64,7 @@ class SessionConsistentConnectionManager extends ConnectionManager { * * @param string[]|null $groups * - * @return Database + * @return IDatabase */ public function getReadConnection( array $groups = null ) { if ( $this->forceWriteConnection ) { @@ -77,7 +77,7 @@ class SessionConsistentConnectionManager extends ConnectionManager { /** * @since 1.29 * - * @return Database + * @return IDatabase */ public function getWriteConnection() { $this->prepareForUpdates(); -- 2.20.1