From: Umherirrender <umherirrender_de.wp@web.de>
Date: Sat, 23 Feb 2019 20:35:15 +0000 (+0100)
Subject: Document type for class properties in ResourceLoaderImageModule
X-Git-Tag: 1.34.0-rc.0~2710^2
X-Git-Url: https://git.cyclocoop.org/admin/Duna?a=commitdiff_plain;h=6efe87449f16851243d053be00b24751feec9e63;p=lhc%2Fweb%2Fwiklou.git

Document type for class properties in ResourceLoaderImageModule

Also declare missing properties

Change-Id: Ia63597fa996e7050b29ff6df0694dd7e036800d8
---

diff --git a/includes/resourceloader/ResourceLoaderImageModule.php b/includes/resourceloader/ResourceLoaderImageModule.php
index b711cbd17f..c555eb8849 100644
--- a/includes/resourceloader/ResourceLoaderImageModule.php
+++ b/includes/resourceloader/ResourceLoaderImageModule.php
@@ -28,6 +28,7 @@
  */
 class ResourceLoaderImageModule extends ResourceLoaderModule {
 
+	/** @var array|null */
 	protected $definition = null;
 
 	/**
@@ -38,10 +39,18 @@ class ResourceLoaderImageModule extends ResourceLoaderModule {
 
 	protected $origin = self::ORIGIN_CORE_SITEWIDE;
 
+	/** @var ResourceLoaderImage[]|null */
+	protected $imageObjects = null;
+	/** @var array */
 	protected $images = [];
+	/** @var string|null */
 	protected $defaultColor = null;
 	protected $useDataURI = true;
+	/** @var array|null */
+	protected $globalVariants = null;
+	/** @var array */
 	protected $variants = [];
+	/** @var string|null */
 	protected $prefix = null;
 	protected $selectorWithoutVariant = '.{prefix}-{name}';
 	protected $selectorWithVariant = '.{prefix}-{name}-{variant}';
@@ -240,7 +249,7 @@ class ResourceLoaderImageModule extends ResourceLoaderModule {
 	 */
 	public function getImages( ResourceLoaderContext $context ) {
 		$skin = $context->getSkin();
-		if ( !isset( $this->imageObjects ) ) {
+		if ( $this->imageObjects === null ) {
 			$this->loadFromDefinition();
 			$this->imageObjects = [];
 		}
@@ -288,7 +297,7 @@ class ResourceLoaderImageModule extends ResourceLoaderModule {
 	 */
 	public function getGlobalVariants( ResourceLoaderContext $context ) {
 		$skin = $context->getSkin();
-		if ( !isset( $this->globalVariants ) ) {
+		if ( $this->globalVariants === null ) {
 			$this->loadFromDefinition();
 			$this->globalVariants = [];
 		}