From e53c6dbd8da07eaa75bb7a627f2523e0ecf38eac Mon Sep 17 00:00:00 2001
From: withoutaname <drevitchi@gmail.com>
Date: Sun, 3 Aug 2014 17:15:17 -0700
Subject: [PATCH] actions: Move SubmitAction class out of EditAction.php

Straight move, except for the slight change in the comparison operator
for session_id().

Change-Id: I9404f48ee75ff3d3655f2f5b75a05d66f334b80d
---
 includes/AutoLoader.php           |  2 +-
 includes/actions/EditAction.php   | 25 +-----------------
 includes/actions/SubmitAction.php | 42 +++++++++++++++++++++++++++++++
 3 files changed, 44 insertions(+), 25 deletions(-)
 create mode 100644 includes/actions/SubmitAction.php

diff --git a/includes/AutoLoader.php b/includes/AutoLoader.php
index c535ca0c30..0399bd3994 100644
--- a/includes/AutoLoader.php
+++ b/includes/AutoLoader.php
@@ -208,7 +208,7 @@ $wgAutoloadLocalClasses = array(
 	'RevertAction' => 'includes/actions/RevertAction.php',
 	'RevisiondeleteAction' => 'includes/actions/RevisiondeleteAction.php',
 	'RollbackAction' => 'includes/actions/RollbackAction.php',
-	'SubmitAction' => 'includes/actions/EditAction.php',
+	'SubmitAction' => 'includes/actions/SubmitAction.php',
 	'UnprotectAction' => 'includes/actions/UnprotectAction.php',
 	'UnwatchAction' => 'includes/actions/UnwatchAction.php',
 	'ViewAction' => 'includes/actions/ViewAction.php',
diff --git a/includes/actions/EditAction.php b/includes/actions/EditAction.php
index 31f58b8072..5a1e2c1fd9 100644
--- a/includes/actions/EditAction.php
+++ b/includes/actions/EditAction.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * action=edit / action=submit handler
+ * action=edit handler
  *
  * Copyright © 2012 Timo Tijhof
  *
@@ -50,26 +50,3 @@ class EditAction extends FormlessAction {
 		}
 	}
 }
-
-/**
- * Edit submission handler
- *
- * This is the same as EditAction; except that it sets the session cookie.
- *
- * @ingroup Actions
- */
-class SubmitAction extends EditAction {
-
-	public function getName() {
-		return 'submit';
-	}
-
-	public function show() {
-		if ( session_id() == '' ) {
-			// Send a cookie so anons get talk message notifications
-			wfSetupSession();
-		}
-
-		parent::show();
-	}
-}
diff --git a/includes/actions/SubmitAction.php b/includes/actions/SubmitAction.php
new file mode 100644
index 0000000000..fae49f61e3
--- /dev/null
+++ b/includes/actions/SubmitAction.php
@@ -0,0 +1,42 @@
+<?php
+/**
+ * Wrapper for EditAction; sets the session cookie.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
+ *
+ * @file
+ * @ingroup Actions
+ */
+
+/**
+ * This is the same as EditAction; except that it sets the session cookie.
+ *
+ * @ingroup Actions
+ */
+class SubmitAction extends EditAction {
+
+	public function getName() {
+		return 'submit';
+	}
+
+	public function show() {
+		if ( session_id() === '' ) {
+			// Send a cookie so anons get talk message notifications
+			wfSetupSession();
+		}
+
+		parent::show();
+	}
+}
-- 
2.20.1