From bd602d20833f435fd1b9fbe7154ea10971eb5a7f Mon Sep 17 00:00:00 2001 From: umherirrender Date: Sun, 23 Sep 2012 01:05:07 +0200 Subject: [PATCH] Drop unused database field ss_admins no longer updated since 1.5 Change-Id: Iebdce084d178b5003105b2d2b7dcc499c274ff56 --- includes/installer/MysqlUpdater.php | 1 + includes/installer/SqliteUpdater.php | 1 + maintenance/archives/patch-drop-ss_admins.sql | 2 ++ .../sqlite/archives/patch-drop-ss_admins.sql | 22 +++++++++++++++++++ maintenance/tables.sql | 3 --- 5 files changed, 26 insertions(+), 3 deletions(-) create mode 100644 maintenance/archives/patch-drop-ss_admins.sql create mode 100644 maintenance/sqlite/archives/patch-drop-ss_admins.sql diff --git a/includes/installer/MysqlUpdater.php b/includes/installer/MysqlUpdater.php index 08307af35e..037af7b002 100644 --- a/includes/installer/MysqlUpdater.php +++ b/includes/installer/MysqlUpdater.php @@ -216,6 +216,7 @@ class MysqlUpdater extends DatabaseUpdater { array( 'dropField', 'category', 'cat_hidden', 'patch-cat_hidden.sql' ), // 1.21 + array( 'dropField', 'site_stats', 'ss_admins', 'patch-drop-ss_admins.sql' ), ); } diff --git a/includes/installer/SqliteUpdater.php b/includes/installer/SqliteUpdater.php index aedc5c7bec..8813b858f3 100644 --- a/includes/installer/SqliteUpdater.php +++ b/includes/installer/SqliteUpdater.php @@ -95,6 +95,7 @@ class SqliteUpdater extends DatabaseUpdater { array( 'dropField', 'category', 'cat_hidden', 'patch-cat_hidden.sql' ), // 1.21 + array( 'dropField', 'site_stats', 'ss_admins', 'patch-drop-ss_admins.sql' ), ); } diff --git a/maintenance/archives/patch-drop-ss_admins.sql b/maintenance/archives/patch-drop-ss_admins.sql new file mode 100644 index 0000000000..13c3d3b0a2 --- /dev/null +++ b/maintenance/archives/patch-drop-ss_admins.sql @@ -0,0 +1,2 @@ +-- field is deprecated and no longer updated as of 1.5 +ALTER TABLE /*_*/site_stats DROP COLUMN ss_admins; \ No newline at end of file diff --git a/maintenance/sqlite/archives/patch-drop-ss_admins.sql b/maintenance/sqlite/archives/patch-drop-ss_admins.sql new file mode 100644 index 0000000000..9951e17e35 --- /dev/null +++ b/maintenance/sqlite/archives/patch-drop-ss_admins.sql @@ -0,0 +1,22 @@ +-- field is deprecated and no longer updated as of 1.5 +CREATE TABLE /*_*/site_stats_tmp ( + ss_row_id int unsigned NOT NULL, + ss_total_views bigint unsigned default 0, + ss_total_edits bigint unsigned default 0, + ss_good_articles bigint unsigned default 0, + ss_total_pages bigint default '-1', + ss_users bigint default '-1', + ss_active_users bigint default '-1', + ss_images int default 0 +) /*$wgDBTableOptions*/; + +INSERT INTO /*_*/site_stats_tmp + SELECT ss_row_id, ss_total_views, ss_total_edits, ss_good_articles, + ss_total_pages, ss_users, ss_active_users, ss_images + FROM /*_*/site_stats; + +DROP TABLE /*_*/site_stats; + +ALTER TABLE /*_*/site_stats_tmp RENAME TO /*_*/site_stats; + +CREATE UNIQUE INDEX /*i*/ss_row_id ON /*_*/site_stats (ss_row_id); \ No newline at end of file diff --git a/maintenance/tables.sql b/maintenance/tables.sql index 062052f77c..1ddc89d2a8 100644 --- a/maintenance/tables.sql +++ b/maintenance/tables.sql @@ -689,9 +689,6 @@ CREATE TABLE /*_*/site_stats ( -- Number of users that still edit ss_active_users bigint default '-1', - -- Deprecated, no longer updated as of 1.5 - ss_admins int default '-1', - -- Number of images, equivalent to SELECT COUNT(*) FROM image ss_images int default 0 ) /*$wgDBTableOptions*/; -- 2.20.1