From a7733bbf0d45690c7bbebcafad2d9c1584a87133 Mon Sep 17 00:00:00 2001 From: Chad Horohoe Date: Wed, 25 Feb 2009 22:18:44 +0000 Subject: [PATCH] Follow up to r46613 (Allow local redirects to foreign images): * This doesn't work like it should. We seem to be returning metadata about the target (ie: it does in fact exist), but at some point it all goes null. Making a note in ImagePage * Reverting RELEASE-NOTES until this is right. --- RELEASE-NOTES | 2 -- includes/ImagePage.php | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index c4dc3b809c..3e40a011c8 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -71,8 +71,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN can now be determined and set with ParserOptions. * Wrap message 'confirmemail_pending' into a div with CSS classes "error" and "mw-confirmemail-pending" -* Local redirects to foreign images are now displayed on the ImagePage when - viewing on the local wiki. * (bug 8249) The magic words for namespaces and pagenames can now be used as parser functions to return the desired namespace or normalized title/title part for a given title. diff --git a/includes/ImagePage.php b/includes/ImagePage.php index 9eed236aa1..b6964d6eaa 100644 --- a/includes/ImagePage.php +++ b/includes/ImagePage.php @@ -127,6 +127,8 @@ class ImagePage extends Article { array( 'id' => 'filelinks' ), wfMsg( 'imagelinks' ) ) . "\n" ); $this->imageDupes(); + # TODO! FIXME! For some freaky reason, we can't redirect to foreign images. + # Yet we return metadata about the target. Definitely an issue in the FileRepo $this->imageRedirects(); $this->imageLinks(); -- 2.20.1