From 99e8325cc16fb769fcc3c7a66089d6d5c1928862 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= <matma.rex@gmail.com>
Date: Mon, 5 Mar 2018 19:24:37 +0100
Subject: [PATCH] DifferenceEngine: Use CSS classes instead of inline styles

Change-Id: Iee0e5e7eb73023a6f57c1f462e71cbb0e771d1f2
---
 includes/diff/DifferenceEngine.php                | 10 +++++-----
 resources/src/mediawiki/mediawiki.diff.styles.css |  6 ++++++
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php
index fa30d68655..037a80fbc7 100644
--- a/includes/diff/DifferenceEngine.php
+++ b/includes/diff/DifferenceEngine.php
@@ -1294,7 +1294,7 @@ class DifferenceEngine extends ContextSource {
 
 		if ( !$diff && !$otitle ) {
 			$header .= "
-			<tr style=\"vertical-align: top;\" lang=\"{$userLang}\">
+			<tr class=\"diff-title\" lang=\"{$userLang}\">
 			<td class=\"diff-ntitle\">{$ntitle}</td>
 			</tr>";
 			$multiColspan = 1;
@@ -1313,7 +1313,7 @@ class DifferenceEngine extends ContextSource {
 			}
 			if ( $otitle || $ntitle ) {
 				$header .= "
-				<tr style=\"vertical-align: top;\" lang=\"{$userLang}\">
+				<tr class=\"diff-title\" lang=\"{$userLang}\">
 				<td colspan=\"$colspan\" class=\"diff-otitle\">{$otitle}</td>
 				<td colspan=\"$colspan\" class=\"diff-ntitle\">{$ntitle}</td>
 				</tr>";
@@ -1321,12 +1321,12 @@ class DifferenceEngine extends ContextSource {
 		}
 
 		if ( $multi != '' ) {
-			$header .= "<tr><td colspan=\"{$multiColspan}\" style=\"text-align: center;\" " .
+			$header .= "<tr><td colspan=\"{$multiColspan}\" " .
 				"class=\"diff-multi\" lang=\"{$userLang}\">{$multi}</td></tr>";
 		}
 		if ( $notice != '' ) {
-			$header .= "<tr><td colspan=\"{$multiColspan}\" style=\"text-align: center;\" " .
-				"lang=\"{$userLang}\">{$notice}</td></tr>";
+			$header .= "<tr><td colspan=\"{$multiColspan}\" " .
+				"class=\"diff-notice\" lang=\"{$userLang}\">{$notice}</td></tr>";
 		}
 
 		return $header . $diff . "</table>";
diff --git a/resources/src/mediawiki/mediawiki.diff.styles.css b/resources/src/mediawiki/mediawiki.diff.styles.css
index 7260a0a7f1..c46922257f 100644
--- a/resources/src/mediawiki/mediawiki.diff.styles.css
+++ b/resources/src/mediawiki/mediawiki.diff.styles.css
@@ -33,6 +33,12 @@
 	word-wrap: break-word;
 }
 
+.diff-title {
+	vertical-align: top;
+}
+
+.diff-notice,
+.diff-multi,
 .diff-otitle,
 .diff-ntitle {
 	text-align: center;
-- 
2.20.1