From 6b060fde3672aea1e7c2e18ea442075a9535488e Mon Sep 17 00:00:00 2001 From: addshore Date: Sat, 14 Oct 2017 11:43:58 +0100 Subject: [PATCH] RevisionUnitTest for userJoinCond and pageJoinCond Change-Id: I4deb6192e56c6b6eb9c60d0ae3cd3aa472a84af6 --- tests/phpunit/includes/RevisionUnitTest.php | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/tests/phpunit/includes/RevisionUnitTest.php b/tests/phpunit/includes/RevisionUnitTest.php index 232b0868fc..47dcf6591c 100644 --- a/tests/phpunit/includes/RevisionUnitTest.php +++ b/tests/phpunit/includes/RevisionUnitTest.php @@ -202,4 +202,24 @@ class RevisionUnitTest extends MediaWikiTestCase { Revision::getRevisionText( $row ), "getRevisionText" ); } + /** + * @covers Revision::userJoinCond + */ + public function testUserJoinCond() { + $this->assertEquals( + [ 'LEFT JOIN', [ 'rev_user != 0', 'user_id = rev_user' ] ], + Revision::userJoinCond() + ); + } + + /** + * @covers Revision::pageJoinCond + */ + public function testPageJoinCond() { + $this->assertEquals( + [ 'INNER JOIN', [ 'page_id = rev_page' ] ], + Revision::pageJoinCond() + ); + } + } -- 2.20.1