lhc/web/wiklou.git
10 years agoRemove use of strencode() in buildLike()
Kevin Israel [Tue, 10 Jun 2014 19:51:33 +0000 (15:51 -0400)]
Remove use of strencode() in buildLike()

This may cause unnecessary backslashes (in the case of a literal
% or _) to end up in the query when the DBMS uses C-style string
escaping; however, the query should still work.

Change-Id: I82681f83dd45fcbecf4bfd672f550cd4dba30949

10 years agoMerge "Vector: Update comments in vector.js"
jenkins-bot [Tue, 10 Jun 2014 03:02:56 +0000 (03:02 +0000)]
Merge "Vector: Update comments in vector.js"

10 years agoOfficially deprecate skin autodiscovery
Bartosz Dziewoński [Mon, 26 May 2014 13:54:56 +0000 (15:54 +0200)]
Officially deprecate skin autodiscovery

Corresponding change in REL1_23 (different, because core skins still use
autodiscovery in that version): If9125ef587ce11f0d69f12eacd00ae7236139798.

Bug: 65748
Change-Id: I6fc30f97d4b35820c132c4892abf6d2c86f9482e

10 years agoDon't use autodiscovery for core skins, move them to separate directories
Bartosz Dziewoński [Sun, 25 May 2014 21:58:05 +0000 (23:58 +0200)]
Don't use autodiscovery for core skins, move them to separate directories

Step one on the way to killing the autodiscovery mechanism and making
the core skins less intertwined with core.

This only moves the files and fixes hardcoded paths throughout core.
Any further changes will be done in separate patch(es).

Moved files:
* skins/MonoBook.php → skins/monobook/MonoBook.php
* skins/Vector.php   → skins/vector/Vector.php

Bug: 65748
Change-Id: Ib4bdda5ed3c133fce0113eb17fa39950aa812f87

10 years agoMerge "Remove unused variable"
jenkins-bot [Tue, 10 Jun 2014 00:49:10 +0000 (00:49 +0000)]
Merge "Remove unused variable"

10 years agoRemove unused variable
Max Semenik [Fri, 6 Jun 2014 18:40:27 +0000 (11:40 -0700)]
Remove unused variable

Follows up Ie47649ef45f9eebdfe

Change-Id: I2c6f2a0b4a8f15056ad0b314da7f8086168b1863

10 years agoDo not show page navigation on included Special:Contributions page
JuneHyeon Bae [Mon, 2 Jun 2014 01:12:34 +0000 (10:12 +0900)]
Do not show page navigation on included Special:Contributions page

Bug: 65780
Change-Id: Ie1f96d62e0f7b8c1066aaecc5e8ba528fb94cbf7

10 years agoMerge "Update OOjs UI to v0.1.0-pre (15f4156bac)"
jenkins-bot [Mon, 9 Jun 2014 23:57:26 +0000 (23:57 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (15f4156bac)"

10 years agoMerge "More optimizations to User::saveOptions()"
jenkins-bot [Mon, 9 Jun 2014 23:51:09 +0000 (23:51 +0000)]
Merge "More optimizations to User::saveOptions()"

10 years agoUpdate OOjs UI to v0.1.0-pre (15f4156bac)
James D. Forrester [Mon, 9 Jun 2014 23:46:18 +0000 (16:46 -0700)]
Update OOjs UI to v0.1.0-pre (15f4156bac)

New changes:
15f4156 Follow-up 2334482: actually clear items in clearItems()

Change-Id: I7d4570364690b82a6fb7de3beb7e7e68ff451366

10 years agoAdd mw.track calls for jquery.migrate
Timo Tijhof [Wed, 14 May 2014 13:45:27 +0000 (15:45 +0200)]
Add mw.track calls for jquery.migrate

Can't use mw.log.deprecate because many of these are fired
for specific behaviour within a method, not for access to the method
itself.

And mustn't fire the events with topic "mw.deprecate" as we can't satisfy
all the requires properties of that event schema (such as having a search
phrase to find offending code). These tracking hits would be for hit
counts only, not for finding where it comes from (we'll still have wikiid,
pagename, revision id and referral information from EventLogging though).

Change-Id: I6c868f2ce831d74889ed58b6ab4a69b233b3923f

10 years agoUpdate OOjs UI to v0.1.0-pre (098f84f8a0)
James D. Forrester [Mon, 9 Jun 2014 21:32:31 +0000 (14:32 -0700)]
Update OOjs UI to v0.1.0-pre (098f84f8a0)

New changes:
371fcff Correct TextInputMenuWidget position for RTL
05467d3 Localisation updates from https://translatewiki.net.
2334482 GroupElement: Improve performance by avoiding .add() overhead

Change-Id: I6701dd1bc08343e14f6b3cacdfe0c8d80b350394

10 years agoMerge "ResourceLoaderLESSFunctions: Quote CSS data: URIs if needed"
jenkins-bot [Mon, 9 Jun 2014 21:02:18 +0000 (21:02 +0000)]
Merge "ResourceLoaderLESSFunctions: Quote CSS data: URIs if needed"

10 years agoAdd PPFrame::getTTL() and setTTL()
Jackmcbarn [Wed, 28 May 2014 20:17:41 +0000 (16:17 -0400)]
Add PPFrame::getTTL() and setTTL()

Add functions to frames to control the TTL of their output, and expose
this via expandtemplates in the API.

Bug: 49803
Change-Id: I412febf3469503bf4839fb1ef4dca098a8c79457

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 9 Jun 2014 20:35:47 +0000 (20:35 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I7323b1280bf812e5043d528dea4f32d4b4cde26f

10 years agoVector: Update comments in vector.js
Bartosz Dziewoński [Mon, 9 Jun 2014 20:15:43 +0000 (22:15 +0200)]
Vector: Update comments in vector.js

Change-Id: Ife1364c6f3c7d2dfde2275287e2f85d10c19c526

10 years agoSync up with Parsoid parserTests.
C. Scott Ananian [Mon, 9 Jun 2014 20:14:08 +0000 (16:14 -0400)]
Sync up with Parsoid parserTests.

This now aligns with Parsoid commit d6666187bac33cbdb0ad5f67d20be98680845b24

Change-Id: Ib4fd31e9d1c14e6a171d39510b5621baf1642b9e

10 years agoMerge "Remove unused jquery.cycle.all.js file"
jenkins-bot [Mon, 9 Jun 2014 20:04:10 +0000 (20:04 +0000)]
Merge "Remove unused jquery.cycle.all.js file"

10 years agoVector: Hide the superfluous "Variants" menu label again
Bartosz Dziewoński [Mon, 9 Jun 2014 17:09:41 +0000 (19:09 +0200)]
Vector: Hide the superfluous "Variants" menu label again

Follow-up to I09c8031c.

Also removed a piece of temporary hacky CSS from Iabda8155.
The other hacks from it were removed, this one persisted.

Bug: 66364
Change-Id: I4d5ae0858e1685a60c42d8080fec2753f25ea9ad

10 years agoMerge "Add HKDF as a fast, random number source"
jenkins-bot [Mon, 9 Jun 2014 18:50:06 +0000 (18:50 +0000)]
Merge "Add HKDF as a fast, random number source"

10 years agoMerge "API: Add show=unread to ApiQueryWatchlist"
jenkins-bot [Mon, 9 Jun 2014 18:47:43 +0000 (18:47 +0000)]
Merge "API: Add show=unread to ApiQueryWatchlist"

10 years agoAdd HKDF as a fast, random number source
csteipp [Tue, 3 Jun 2014 18:15:36 +0000 (11:15 -0700)]
Add HKDF as a fast, random number source

This adds an RFC 5869 compatible library for quickly generating
cryptographically secure random keys/numbers. An attacker should be
unable to predict the next number generated, as long as the secret
key (set to wgSecretKey if not explicitly defined for a wiki) remains
secret.

In my testing, this is generating random numbers about 7x faster than
MWCryptRand for 32 hex characters, and shouldn't drain openssl's
entropy source.

This will hopefully speed up maintenance tasks that require secure
random numbers, such as resetting login token, and wrapping user's
passwords in a new format.

Change-Id: I437d9aec0122a0533b0d8723fe8a8624898af909

10 years agoMerge "Lowered the TransactionProfiler threshold"
jenkins-bot [Mon, 9 Jun 2014 18:19:20 +0000 (18:19 +0000)]
Merge "Lowered the TransactionProfiler threshold"

10 years agoAPI: Add show=unread to ApiQueryWatchlist
Brad Jorsch [Tue, 3 Jun 2014 19:06:27 +0000 (15:06 -0400)]
API: Add show=unread to ApiQueryWatchlist

This allows for retrieving only those pages that have changes since the
last visit.

Bug: 65246
Change-Id: I81d2fae39178708efc0f57e5acea93b50463bc7a

10 years agoMerge "Update list item newline handling to follow Parsoid's model"
jenkins-bot [Mon, 9 Jun 2014 18:13:14 +0000 (18:13 +0000)]
Merge "Update list item newline handling to follow Parsoid's model"

10 years agoUpdate list item newline handling to follow Parsoid's model
Gabriel Wicke [Tue, 20 May 2014 16:14:21 +0000 (09:14 -0700)]
Update list item newline handling to follow Parsoid's model

This improves on commit 34bd573144883af9ace7ead32d3be8f692431718 by matching
Parsoid's newline handling in the PHP parser. It is the outcome of a
discussion with Erwin, where we agreed that

* foo
* bar

should produce

<ul><li>foo</li>
<li>bar</li></ul>

See the discussion in https://gerrit.wikimedia.org/r/#/c/94443/

The original rendering issue this tried to address is no longer present after
a change to the template. The pure CSS solution is now working.

Bug: 39617
Bug: 56809
Change-Id: Ib7aa9449bbd994cb23b83b3f23cff944b1cddadf

10 years agoMerge "Vector: Restore old focus animation on the "More" dropdown"
jenkins-bot [Mon, 9 Jun 2014 17:56:40 +0000 (17:56 +0000)]
Merge "Vector: Restore old focus animation on the "More" dropdown"

10 years agoVector: Restore old focus animation on the "More" dropdown
Bartosz Dziewoński [Thu, 5 Jun 2014 17:57:02 +0000 (19:57 +0200)]
Vector: Restore old focus animation on the "More" dropdown

Per post-merge review of I09c8031c, it's not consistent with anything
we have elsewhere.

Bug: 66363
Change-Id: I89cf29fcb92d29d782c4091f39879f3837579bdb

10 years agoMerge "API: Add prop=unreadcount to ApiQueryUserInfo"
jenkins-bot [Mon, 9 Jun 2014 17:48:24 +0000 (17:48 +0000)]
Merge "API: Add prop=unreadcount to ApiQueryUserInfo"

10 years agoMerge "Installer: Re-use ResourceLoader methods instead of duplicating"
jenkins-bot [Mon, 9 Jun 2014 16:57:51 +0000 (16:57 +0000)]
Merge "Installer: Re-use ResourceLoader methods instead of duplicating"

10 years agoMerge "Remove backwards-compatibility modules from I3947eaac"
jenkins-bot [Mon, 9 Jun 2014 16:56:51 +0000 (16:56 +0000)]
Merge "Remove backwards-compatibility modules from I3947eaac"

10 years agoAPI: Add prop=unreadcount to ApiQueryUserInfo
Brad Jorsch [Tue, 3 Jun 2014 19:53:34 +0000 (15:53 -0400)]
API: Add prop=unreadcount to ApiQueryUserInfo

People want to be able to fetch the count of unread pages on the
watchlist.

Bug: 65246
Change-Id: I890f21631ba074a7b3d660534c40e38773d8ea77

10 years agoMerge "Upgrade jQuery UI from 1.8.24 to 1.9.2"
jenkins-bot [Mon, 9 Jun 2014 16:01:51 +0000 (16:01 +0000)]
Merge "Upgrade jQuery UI from 1.8.24 to 1.9.2"

10 years agoResourceLoaderLESSFunctions: Quote CSS data: URIs if needed
Christian Aistleitner [Mon, 9 Jun 2014 10:48:24 +0000 (12:48 +0200)]
ResourceLoaderLESSFunctions: Quote CSS data: URIs if needed

Change-Id: I121cf6b410b17f2b8b880cb3b5cb786f5eeb23b6

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 8 Jun 2014 19:47:14 +0000 (19:47 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I318f55bbd9ba3f99fd2061b61f663f79ec2ca7d6

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 7 Jun 2014 19:29:48 +0000 (19:29 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: If92d90ab5d744d3b82beedbdac92ab3b5bf03a79

10 years agoRemove unused jquery.cycle.all.js file
Matthew Flaschen [Fri, 6 Jun 2014 23:32:12 +0000 (19:32 -0400)]
Remove unused jquery.cycle.all.js file

Originally added in r109828 / 2f1f0abc6b, but without any module
declaration. The only way this file could be used is if an
extension is referencing the file directly, which is unsupported.

Bug: 66292
Change-Id: I730c31cef40ff1cc1c12573ace9bec78ebbc1e7d

10 years agoInstaller: Re-use ResourceLoader methods instead of duplicating
Timo Tijhof [Wed, 4 Jun 2014 19:30:14 +0000 (21:30 +0200)]
Installer: Re-use ResourceLoader methods instead of duplicating

Also:
* Fix incorrect documentation comment of ResourceLoaderModule::getStyles(),
  it doesn't return a string, it never has.
* Remove spurious space in count() call.
* Fix spelling of in "proper".

Change-Id: I000393636f7b9015ad1bacfbb3eb8a6ad8695d72

10 years agoMinor clarification & tweak for Parsoid render testing
Gabriel Wicke [Sat, 7 Jun 2014 05:32:07 +0000 (22:32 -0700)]
Minor clarification & tweak for Parsoid render testing

* Clarify comment

* Set some padding on body

Change-Id: I93c070e997cbf34bfa4a296f99c30d90ee67e59e

10 years agoBug 66287: Proper caption styling
Gabriel Wicke [Sat, 7 Jun 2014 05:10:49 +0000 (22:10 -0700)]
Bug 66287: Proper caption styling

* Make sure borders render properly even in Chrome & with zoom on high-dpi
  devices. overflow: auto is important for this.

* Set borders & background on imagecaption

* Enable border-collapsing; we are rendering this as a table & want the
  caption & figure to show a single border

* Add appropriate margin on the image to create some padding inside the figure
  despite border-collapsing

Tested in Chrome & Firefox.

Change-Id: Ibb46b682138ac703bea364efaeefc376e60c2d5f

10 years agoMerge "Make sure images that don't have an explicit alignment get aligned right"
jenkins-bot [Sat, 7 Jun 2014 00:55:47 +0000 (00:55 +0000)]
Merge "Make sure images that don't have an explicit alignment get aligned right"

10 years agoMake sure images that don't have an explicit alignment get aligned right
kaldari [Fri, 6 Jun 2014 21:11:48 +0000 (14:11 -0700)]
Make sure images that don't have an explicit alignment get aligned right

If the alignment of an image is not explicitly set, Parsoid does not
output an alignment class for the resultant figure element. This can lead
to the image not being aligned/floated.

To fix this we modify content.parsoid.less to apply the default
right-alignment styling to all images and then override this in cases
where the alignment is explicitly set.

Bug: 66282

Change-Id: I4f986f23b0c8ba6f6b66efc07eb38806744123e2

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 6 Jun 2014 21:40:44 +0000 (21:40 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I2b1a64cae75faf8d201ba58305bb3e85fb2f4c4f

10 years agoMore optimizations to User::saveOptions()
Aaron Schulz [Fri, 6 Jun 2014 18:54:50 +0000 (11:54 -0700)]
More optimizations to User::saveOptions()

* Avoid doing the DELETE for unchanged rows. This method is often
  called when one new preference (e.g. watchlist token) is set.
  These cases will now simple result in an INSERT, even if the
  user already has some preferences set.

bug: 36116
Change-Id: Ib7c558e7c06927875086b86ea719ac1323a7b4a8

10 years agoMerge "Update outdated signup page-related message documentation"
jenkins-bot [Fri, 6 Jun 2014 15:18:11 +0000 (15:18 +0000)]
Merge "Update outdated signup page-related message documentation"

10 years agoAdd error 'pagecannotexist' to ApiBase::getTitleOrPageIdErrorMessage
umherirrender [Tue, 20 May 2014 19:10:47 +0000 (21:10 +0200)]
Add error 'pagecannotexist' to ApiBase::getTitleOrPageIdErrorMessage

Function can die with 'pagecannotexist' since
I2123e3a3034cb815cf35f66f2fbf2b94fb27069f

Change-Id: I10c496da147c1bf6ceb6d69b19170a0e62f1318c

10 years agoUpdate OOjs UI to v0.1.0-pre (c9b9f8345d)
James D. Forrester [Fri, 6 Jun 2014 01:43:28 +0000 (18:43 -0700)]
Update OOjs UI to v0.1.0-pre (c9b9f8345d)

New changes:
c9b9f83 Allow programmatic selection of options while disabled

Change-Id: I5624a50e493c9466e3f3ce746425b586639a64f4

10 years agoMerge "Add missing possible errors to ApiQueryLogEvents.php"
jenkins-bot [Fri, 6 Jun 2014 00:46:43 +0000 (00:46 +0000)]
Merge "Add missing possible errors to ApiQueryLogEvents.php"

10 years agoLowered the TransactionProfiler threshold
Aaron Schulz [Thu, 5 Jun 2014 22:59:07 +0000 (15:59 -0700)]
Lowered the TransactionProfiler threshold

Change-Id: Id574e8d2b2a28cba3003d6a344a4afb0307699e3

10 years agoMerge "WikiPage: Allow replaceSection on an nonexistent page"
jenkins-bot [Thu, 5 Jun 2014 21:01:58 +0000 (21:01 +0000)]
Merge "WikiPage: Allow replaceSection on an nonexistent page"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 5 Jun 2014 20:35:07 +0000 (20:35 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I5addd9bd63c2ca3638a2714e94985536a4d875ef

10 years agoWikiPage: Allow replaceSection on an nonexistent page
Adam Roses Wight [Thu, 5 Jun 2014 00:34:42 +0000 (17:34 -0700)]
WikiPage: Allow replaceSection on an nonexistent page

This corrects a regression, where replaceSection would require that the
page have at least one revision in the database.  If the page does not
exist, continue with the replacement, using a null baseRevId.

Also: clean up a few comments in the replaceSection functions.

Bug: 66141
Change-Id: Ieb2cb05aee07a1d8bbdc3bdfe9536dfa8bee529e

10 years agoMerge "chmod -x languages/data/plurals.xml"
jenkins-bot [Thu, 5 Jun 2014 19:58:50 +0000 (19:58 +0000)]
Merge "chmod -x languages/data/plurals.xml"

10 years agoMerge "Load previous tags in ChangeTags::addTags() from DB_MASTER"
jenkins-bot [Thu, 5 Jun 2014 18:30:21 +0000 (18:30 +0000)]
Merge "Load previous tags in ChangeTags::addTags() from DB_MASTER"

10 years agoLoad previous tags in ChangeTags::addTags() from DB_MASTER
Liangent [Thu, 5 Jun 2014 13:00:52 +0000 (13:00 +0000)]
Load previous tags in ChangeTags::addTags() from DB_MASTER

This fixes a bug in mobile [1] that the tag added by MobileApp gets
overwritten by MobileFrontend, where both use ChangeTags::addTags(),
and MobileFrontend is registered (thus called) after MobileApp.

[1] http://lists.wikimedia.org/pipermail/mobile-l/2014-June/007260.html

Change-Id: Ie47649ef45f9eebdfeae73a0698ea5d21b150b56

10 years agoDo not wrap <table> inside <p> on Special:UserRights
umherirrender [Thu, 5 Jun 2014 18:05:34 +0000 (20:05 +0200)]
Do not wrap <table> inside <p> on Special:UserRights

Special:UserRights has a table inside a paragraph which is invalid html.
The validator will except the open <p> but than gives a error on the
closing </p>: "No p element in scope but a p end tag seen."
IE11 also gives a hint on the console (hint HTML1509).

Fixed this by just removing the paragraph.

Change-Id: Ie17725d0b8018853e445142fa9c436db5471dcc6

10 years agoAdd missing possible errors to ApiQueryLogEvents.php
umherirrender [Wed, 28 May 2014 18:15:13 +0000 (20:15 +0200)]
Add missing possible errors to ApiQueryLogEvents.php

requireMaxOneParameter was added in
I53c4c6411e0b9e6383969afced0e4c193f1b64a1,
without update of the possible error list from that function call

Change-Id: I17f0ba8da4b21b2a5527bd4eff0d0e3308e24d9f

10 years agoMerge "Transaction coverage fix for doDeleteArticleReal"
jenkins-bot [Thu, 5 Jun 2014 17:13:36 +0000 (17:13 +0000)]
Merge "Transaction coverage fix for doDeleteArticleReal"

10 years agoMerge "Also set the queue types map when rebuilding the ready queue map"
jenkins-bot [Thu, 5 Jun 2014 17:07:22 +0000 (17:07 +0000)]
Merge "Also set the queue types map when rebuilding the ready queue map"

10 years agoMerge "CSSMin: Add tests for handling existing data: URIs"
jenkins-bot [Thu, 5 Jun 2014 16:52:44 +0000 (16:52 +0000)]
Merge "CSSMin: Add tests for handling existing data: URIs"

10 years agoCSSMin: Add tests for handling existing data: URIs
Bartosz Dziewoński [Thu, 5 Jun 2014 16:38:41 +0000 (18:38 +0200)]
CSSMin: Add tests for handling existing data: URIs

Just a sanity check inspired by bug 66112.

Change-Id: Iac60a1eb15b3ff60822a3f24f2511c4bc64c092a

10 years agoAlso set the queue types map when rebuilding the ready queue map
Aaron Schulz [Thu, 5 Jun 2014 16:24:59 +0000 (09:24 -0700)]
Also set the queue types map when rebuilding the ready queue map

Change-Id: I0686859541661a22131c387d8fac6dc7b074c18c

10 years agoMerge "Cleanup message file documentation"
jenkins-bot [Thu, 5 Jun 2014 15:08:43 +0000 (15:08 +0000)]
Merge "Cleanup message file documentation"

10 years agoMerge "Soften test for incomplete edit POST"
jenkins-bot [Thu, 5 Jun 2014 14:21:03 +0000 (14:21 +0000)]
Merge "Soften test for incomplete edit POST"

10 years agoMerge "Don't die on empty keys in MWMemcached"
jenkins-bot [Thu, 5 Jun 2014 14:19:51 +0000 (14:19 +0000)]
Merge "Don't die on empty keys in MWMemcached"

10 years agoCleanup message file documentation
Niklas Laxström [Thu, 5 Jun 2014 14:06:25 +0000 (14:06 +0000)]
Cleanup message file documentation

* Interface strings are now elsewhere
* MessagesQQQ no longer exists
* Prefer https for translatewiki.net

Change-Id: I76652ea94cca80441cd5d978029e4707ee41c4fd

10 years agochmod -x languages/data/plurals.xml
Reedy [Thu, 5 Jun 2014 13:18:44 +0000 (14:18 +0100)]
chmod -x languages/data/plurals.xml

Bug: 66182
Change-Id: Ic8e15d94fb54b410d21b969b029fac685b2711d6

10 years agoMerge "Add ParserOutput::unsetProperty, add tests"
jenkins-bot [Thu, 5 Jun 2014 12:41:23 +0000 (12:41 +0000)]
Merge "Add ParserOutput::unsetProperty, add tests"

10 years agoDon't die on empty keys in MWMemcached
Niklas Laxström [Wed, 23 Apr 2014 14:18:24 +0000 (14:18 +0000)]
Don't die on empty keys in MWMemcached

Bug: 64287
Change-Id: Iedfec96286212577a181b83957cdc4545be206d2

10 years agoSoften test for incomplete edit POST
Adam Roses Wight [Thu, 5 Jun 2014 00:13:31 +0000 (17:13 -0700)]
Soften test for incomplete edit POST

Do not reject POSTs from forms that were rendered before
wpUltimateParam was added.

There is also an open question about whether we should respect
kludgey scripts which have hardcoded form params.

See Umherirrender's comment on
change I78f1bbcc9bb092568fbfbec19c08d697c9ae75f8

Change-Id: I28bd6d45442bc3ba352f0de7a50709adb98b1c50

10 years agoUpdate OOjs UI to v0.1.0-pre (cbc62ac803)
James D. Forrester [Thu, 5 Jun 2014 00:11:56 +0000 (17:11 -0700)]
Update OOjs UI to v0.1.0-pre (cbc62ac803)

New changes:
47b147e [BREAKING CHANGE] Use promises for confirmation dialog instead of done event
bcbf56b Localisation updates from https://translatewiki.net.
997292b Localisation updates from https://translatewiki.net.

Change-Id: Iafee3075f79f064d2eb9f5528e7d0bf7c1c52c11

10 years agoMerge "Made executeReadyPeriodicTasks avoid using merge() when not needed"
jenkins-bot [Wed, 4 Jun 2014 22:42:57 +0000 (22:42 +0000)]
Merge "Made executeReadyPeriodicTasks avoid using merge() when not needed"

10 years agoMade executeReadyPeriodicTasks avoid using merge() when not needed
Aaron Schulz [Wed, 4 Jun 2014 18:23:23 +0000 (11:23 -0700)]
Made executeReadyPeriodicTasks avoid using merge() when not needed

Change-Id: I9bb3a5af6ebd12ac5a31578e17142fb0a2dba029

10 years agoUpdate outdated signup page-related message documentation
Matthew Flaschen [Wed, 4 Jun 2014 22:33:30 +0000 (18:33 -0400)]
Update outdated signup page-related message documentation

They were pointing to messages that no longer exist at all in core.

Change-Id: I8fba6b2d1b5e493babfafcca1c4cca5514e9a37e

10 years agoTrack the types of queues in the redis queue aggregator
Aaron Schulz [Tue, 3 Jun 2014 20:53:17 +0000 (13:53 -0700)]
Track the types of queues in the redis queue aggregator

* This tracks all queue types in one simple location that
  can be inspected without using MediaWiki.

Change-Id: I197664b9aa620b29f1400e5a60c55a301348120d

10 years agoUpgrade jQuery UI from 1.8.24 to 1.9.2
Timo Tijhof [Wed, 4 Jun 2014 22:20:47 +0000 (00:20 +0200)]
Upgrade jQuery UI from 1.8.24 to 1.9.2

jQuery UI 1.10 has already been released, and 1.11 is on the
horizon (1.9 is marked "legacy" as of writing). 1.10 drops the
compatibility layer for 1.8 API. So, users should definitely be
encouraged to upgrade their code to move away from the deprecated
1.8 APIs. However, to take it one step at a time, this commit
upgrades us to 1.9 first. That way we're at least not using an
unsupported code base anymore, while at the same time not rolling
out breaking changes.

jQuery UI has redesigned many of its APIs[1], but compatibility
with the jQuery UI 1.8 API is maintained throughout 1.9.x.

* Base theme is now called "Smoothness".

* Sorting the entries in Resources.php alphabetically to make it
  easier to ensure all files are listed when comparing them
  side-by-side.

* Update dependencies to match the "Depends:" header inside
  the javascript files.

* In jQuery UI 1.9, effect files were renamed to match the
  jquery.ui.*.js naming pattern.

* New modules:
  - jquery.ui.menu
  - jquery.ui.spinner
  - jquery.ui.tooltip

* Release notes:
  - http://blog.jqueryui.com/2012/10/jquery-ui-1-9-0/
    - http://jqueryui.com/upgrade-guide/1.9/
    - http://jqueryui.com/changelog/1.9.0/
  - http://blog.jqueryui.com/2012/10/jquery-ui-1-9-1/
    - http://jqueryui.com/changelog/1.9.1/
  - http://blog.jqueryui.com/2012/11/jquery-ui-1-9-2/

[1] http://blog.jqueryui.com/2011/03/api-redesigns-the-past-present-and-future/

Bug: 47076
Change-Id: I0e10b42fb7c25b9d4704719f21c44c08f36ddfa7

10 years agoRemove backwards-compatibility modules from I3947eaac
Bartosz Dziewoński [Fri, 2 May 2014 19:26:14 +0000 (21:26 +0200)]
Remove backwards-compatibility modules from I3947eaac

These were not included in any release.

Change-Id: Ieb927fa9ec1dd19e93ccdbf38595ac11b657d3d3

10 years agoSpecialPage: Remove wfSpecial* call syntax
Chad Horohoe [Mon, 5 May 2014 18:54:02 +0000 (11:54 -0700)]
SpecialPage: Remove wfSpecial* call syntax

Should've done this years ago. Anything still using this syntax is long
since broken in half a dozen other ways anyway.

Change-Id: I0e78453544abb5de7935b046c838ae5b3c4da802

10 years agoMerge "Installer: Simplify css request"
jenkins-bot [Wed, 4 Jun 2014 20:04:47 +0000 (20:04 +0000)]
Merge "Installer: Simplify css request"

10 years agoMerge "Localisation updates from https://translatewiki.net."
Translation updater bot [Wed, 4 Jun 2014 19:56:28 +0000 (19:56 +0000)]
Merge "Localisation updates from https://translatewiki.net."

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 4 Jun 2014 19:51:45 +0000 (19:51 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I7c4ffc96032192391b4999840bc5b0044f360ee0

10 years agoMerge "editintro given a css class of its own"
jenkins-bot [Wed, 4 Jun 2014 19:49:18 +0000 (19:49 +0000)]
Merge "editintro given a css class of its own"

10 years agoMerge "Installer: Disable broken CACHE_DB after backend is disabled"
jenkins-bot [Wed, 4 Jun 2014 19:37:35 +0000 (19:37 +0000)]
Merge "Installer: Disable broken CACHE_DB after backend is disabled"

10 years agoInstaller: Simplify css request
Timo Tijhof [Wed, 4 Jun 2014 19:25:55 +0000 (21:25 +0200)]
Installer: Simplify css request

Instead of passing around the direction in the request, just set
'css=1'. We already have the language code and directionality
available and even rely on it between requests to set other
localisation-related things.

Change-Id: I717cb299b3639024e79880039e0d1f2ff273ab44

10 years agoInstaller: Disable broken CACHE_DB after backend is disabled
Timo Tijhof [Wed, 4 Jun 2014 19:22:14 +0000 (21:22 +0200)]
Installer: Disable broken CACHE_DB after backend is disabled

We're currently not hitting any code that calls wfGetCache(), but
this seems like a good thing to do and would allow us to re-use
more code instead of duplicating a large method just because it
has a call to wfGetCache() somewhere.

This is already done for DB access and LocalisationCache in
general by the installer, but via SqlBagOStuff it can still
cause an exception from LBFactoryFake.

Change-Id: I69c1e34365c1d7503aea8ef47942d20c34318e85

10 years agoMerge "Vector: Label the more actions menu "More", not "Actions""
jenkins-bot [Wed, 4 Jun 2014 19:02:28 +0000 (19:02 +0000)]
Merge "Vector: Label the more actions menu "More", not "Actions""

10 years agoMerge "ParserTests: fix `bits` column in uploaded images for test cases."
jenkins-bot [Wed, 4 Jun 2014 16:25:35 +0000 (16:25 +0000)]
Merge "ParserTests: fix `bits` column in uploaded images for test cases."

10 years agoAdd ParserOutput::unsetProperty, add tests
Adrian Lang [Wed, 16 Apr 2014 09:31:29 +0000 (11:31 +0200)]
Add ParserOutput::unsetProperty, add tests

Change-Id: I29af31918c48a1225b6487c74fd638de26f07b28

10 years agoMerge "Add global limit to PoolCounter"
jenkins-bot [Wed, 4 Jun 2014 08:39:48 +0000 (08:39 +0000)]
Merge "Add global limit to PoolCounter"

10 years agoMerge "Documentation for page_props getter in ParserOutput"
jenkins-bot [Wed, 4 Jun 2014 08:00:40 +0000 (08:00 +0000)]
Merge "Documentation for page_props getter in ParserOutput"

10 years agoMerge "Add jMY to Arab date formats ($datePreferences)"
jenkins-bot [Wed, 4 Jun 2014 07:06:42 +0000 (07:06 +0000)]
Merge "Add jMY to Arab date formats ($datePreferences)"

10 years agoAdd wl_user_notificationtimestamp index
Brad Jorsch [Tue, 3 Jun 2014 19:20:04 +0000 (15:20 -0400)]
Add wl_user_notificationtimestamp index

Bug: 65246
Change-Id: If3e9e855c8a21874ca69c4976af207833dcc53f2

10 years agoRCFeed: Use named types instead of exposing internal MW constant
Timo Tijhof [Wed, 4 Jun 2014 04:06:17 +0000 (06:06 +0200)]
RCFeed: Use named types instead of exposing internal MW constant

Like we do in ApiQueryRecentChanges as well, expose the named
rc.type property, not the internal integer constants.

Change-Id: I89a948eee999032bb2e42cc23345affa879afb42

10 years agoVector: Label the more actions menu "More", not "Actions"
James D. Forrester [Sat, 31 May 2014 23:01:41 +0000 (16:01 -0700)]
Vector: Label the more actions menu "More", not "Actions"

Vector has a consistent way of showing most actions – as tabs, or, if
there are too many or the action is unimportant, shunting them into an
additional actions menu. This menu was problematically labelled "Actions"
which though correct is misleading as it is merely /some/ actions,
alongside the generally-promoted "Read", "Edit" and "View history". The
recent change I09c8031c makes the label of this menu much more prominent
(as it is no longer hidden), which makes the labelling issue more acute.

This menu could have many labels, and this is merely a suggestion. Some
alternatives:

 – "Tools" — However, this conflicts with the page tools shown in the
   left-hand nav, which although arguably should be moved into this menu
   is an argument for another day, as it would notably alter the skin for
   readers who otherwise don't get this menu at all.

 – "Tasks" — This feels more like a term that would be used for an
   individual, or perhaps for the article itself, to denote a worklist –
   a list of outstanding issues to be ticked off ("Orphaned article";
   "Needs wikifying"; "Copyedit"; etc.) rather than a set of task actions
   you can do as atomic steps to the page.

 – "More actions" — This is rather wordy and ideally should be
   unnecessary in the minds of editors who should (through the consistent
   use of simple verbs as action labels) already recognise each of the
   tab links along the top-right of the navigation to be page-
   specific actions.

Bug: 44591
Change-Id: I8697beab5695198c0acddcf9ad8eeca189660c94

10 years agoGrunt: Clean up outdated information
Timo Tijhof [Wed, 4 Jun 2014 03:02:55 +0000 (05:02 +0200)]
Grunt: Clean up outdated information

* Use jshintrc:true which lets grunt defer autodiscovery of the file
  to jshint instead of forcing it to '.jshintrc'. This also us to
  override certain settings from a subdirectory, to match behaviour
  of standalone jshint.

* Remove comments about "Known issues" in node-jscs, those have
  been fixed a while back and were applied when we updated jscs
  in df8c455.

* Match load order.

* Use plain string instead of single-value array.

Change-Id: I7fd8db63ba164de705239c4b419de446ca7d6809

10 years agoAdd SpecialPage::getConfig
Kunal Mehta [Tue, 3 Jun 2014 22:14:22 +0000 (15:14 -0700)]
Add SpecialPage::getConfig

This is necessary since SpecialPage doesn't extend ContextSource yet.

Change-Id: I94c28dc88e9eb569eec5c5ab6e2ce97acc6a25e3

10 years agoParserTests: fix `bits` column in uploaded images for test cases.
C. Scott Ananian [Tue, 3 Jun 2014 19:44:53 +0000 (15:44 -0400)]
ParserTests: fix `bits` column in uploaded images for test cases.

When running parser tests on a sqlite3 database, the insertion of the
djvu image before running the test suite will fail because `NULL` is not
a valid value for the `bits` column of the `image` table.  This will
cause the test suite to eventually fail, since {{NUMBEROFFILES}} differs.

Test uploads show that `bits` is usually set to 0 for both SVG and
DJVU uploads, so fix this (in both the standalone test runner and the
phpunit test runner).

Change-Id: I8689a547d34035534723e87c4c2680c4e67245f2

10 years agoMerge "Deprecate Language::getLangObj()"
jenkins-bot [Tue, 3 Jun 2014 21:24:39 +0000 (21:24 +0000)]
Merge "Deprecate Language::getLangObj()"

10 years agoMerge "(bug 56849) Deprecate dangerous edittime-based content update functions"
jenkins-bot [Tue, 3 Jun 2014 21:23:05 +0000 (21:23 +0000)]
Merge "(bug 56849) Deprecate dangerous edittime-based content update functions"

10 years agoMerge "Make "mini" the default alias for "thumb" in German"
jenkins-bot [Tue, 3 Jun 2014 21:22:32 +0000 (21:22 +0000)]
Merge "Make "mini" the default alias for "thumb" in German"