jenkins-bot [Wed, 23 Jan 2013 19:48:22 +0000 (19:48 +0000)]
Merge "Preserve warnings on API error"
Yuri Astrakhan [Fri, 18 Jan 2013 06:45:43 +0000 (01:45 -0500)]
Preserve warnings on API error
* In case of an error, any warnings generated by API modules before
the error will be preserved in the result.
* Spelling
Change-Id: Ib61a1da90e9ce5df60ceccd0de8c6de9e49a22d6
jenkins-bot [Wed, 23 Jan 2013 19:26:19 +0000 (19:26 +0000)]
Merge "(bug 37209) Make TextContentTest and WikitextContentTest work in all cases"
Aaron Schulz [Wed, 23 Jan 2013 19:11:39 +0000 (11:11 -0800)]
Improved some thumb.php error messages.
Change-Id: I5a61e898dd97db67b719a13ca044530c4baecc99
jenkins-bot [Wed, 23 Jan 2013 19:07:29 +0000 (19:07 +0000)]
Merge "Make Job::toString handle non-primitive parameters."
daniel [Wed, 23 Jan 2013 18:39:49 +0000 (19:39 +0100)]
Make Job::toString handle non-primitive parameters.
Depending on PHP version, configuration and platform, Job::toString
would cause warnings like this if non-primitive parameters where
used in the job:
Notice: Array to string conversion in C:\xampp\htdocs\wikidata-client\includes\job\Job.php on line 245
This change takes care of providing a sane representation of
non-primitive values.
Change-Id: I00ac52d40d39d8219626f5116172950f1b7af381
Alexandre Emsenhuber [Wed, 23 Jan 2013 17:14:35 +0000 (18:14 +0100)]
(bug 37209) Make TextContentTest and WikitextContentTest work in all cases
Currently TextContentTest::testDeletionUpdates() and
WikitextContentTest::testGetSecondaryDataUpdates() set a random page ID to
pages that does not exist. This works in most cases, but when a method like
Title::getLatestRevID() is called on these objects, it throws an excpection
"LinkCache doesn't currently knows about this title."
This happens e.g. when SemanticMediaWiki extension is installed.
Intsead of setting a random page ID, really insert the page in the database
before getting table updates so that it won't crash anymore.
Change-Id: I489c406f78897bc38ac41d8d599b778b47b30021
jenkins-bot [Wed, 23 Jan 2013 15:04:15 +0000 (15:04 +0000)]
Merge "Design improvements to sites code"
jenkins-bot [Wed, 23 Jan 2013 08:28:31 +0000 (08:28 +0000)]
Merge "Added a new "api-error-publishfailed" message."
Tim Landscheidt [Sat, 22 Sep 2012 23:50:52 +0000 (23:50 +0000)]
Do not flip partial keys in CSSJanus.
Change-Id: I1ee9d16069c4627aa81024eeb642714ef796cec5
Alexandre Emsenhuber [Mon, 14 Jan 2013 21:09:26 +0000 (22:09 +0100)]
(bug 43964) Invalid value of "link" parameter in <gallery> no longer produces a fatal error
Also added a test for this just in case someone wants to break this :)
Change-Id: I2782cf1a45b574eb5fd69b1c1be561e7bdaef59e
Aaron Schulz [Wed, 23 Jan 2013 01:10:11 +0000 (17:10 -0800)]
Disabled async "from-stash" upload for now.
Change-Id: I81076e55264746dcfe49d2c928d30042aba0c684
Aaron Schulz [Wed, 23 Jan 2013 00:50:08 +0000 (16:50 -0800)]
Added a new "api-error-publishfailed" message.
Change-Id: I1bce2a7df68891ad8254821f55bd2c7f9f35c373
jenkins-bot [Tue, 22 Jan 2013 23:51:37 +0000 (23:51 +0000)]
Merge "Simplify DatabaseBase::tableName()"
Aaron Schulz [Tue, 22 Jan 2013 21:54:01 +0000 (13:54 -0800)]
Improved concurrency of copyFileBackend.php with pipelined downloads.
Change-Id: I0bde212cbba527d89b0c43f5174a77788cd07b71
Rob Moen [Tue, 22 Jan 2013 20:08:19 +0000 (12:08 -0800)]
Fixed check for general browser compatibility.
The test below will effectively return false for all versions of IE:
$client.test( {
ltr: {
msie: false
},
rtl: {
msie: false
}
});
Change-Id: I1bff63c0f792222741d63cfb8f03b1e0729410a7
Translation updater bot [Tue, 22 Jan 2013 20:38:18 +0000 (20:38 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I9f87305f1444d681b657a6abff9b6f8ecfffc0fe
jenkins-bot [Tue, 22 Jan 2013 20:00:42 +0000 (20:00 +0000)]
Merge "Cleanup to ImagePage::openShowImage()"
bsitu [Tue, 22 Jan 2013 19:37:16 +0000 (11:37 -0800)]
Address gender support issues in page enotif subject and intro
Change-Id: I384fe62172357f41589c4978cdb6f9b69e999c3c
Brad Jorsch [Wed, 26 Dec 2012 15:40:43 +0000 (10:40 -0500)]
(bug 31849) API imageinfo correctly handle redirects
RepoGroup::singleton()->findFiles() returns an associative array mapping
the redirect *target* to the image object; the image object refers back
to the original title queried.
If a redirect and its target are both queried,
RepoGroup::singleton()->findFiles() will return an entry for the target
title only, mapping to an image object that may have getOriginalTitle()
returning the redirect. If this happens, prop=imageinfo will never see
an entry for which getOriginalTitle()->isRedirect() is false and so will
not return any information about the image.
The fix is to ignore getOriginalTitle() entirely. Instead, we just go
through each of our queried titles and see if we got any result back.
Note this automatically handles a "redirects=1" query correctly, since
in that case any local redirect will already have been followed before
we ever got the list of titles to query.
Change-Id: I0b2982901e2dc4491e2933291fd97697b2a622a9
Federico Leva [Tue, 22 Jan 2013 18:21:03 +0000 (19:21 +0100)]
(bug 44248) Minor tweak to MediaWiki:Readonlywarning
Change-Id: Id0bb7040988ba165c7a30f34137f1e894727de20
jeroendedauw [Fri, 18 Jan 2013 09:34:14 +0000 (10:34 +0100)]
Design improvements to sites code
Change-Id: I08ffa6a97093abbe85169f664b97498c5f39bf8e
Dévai Tamás [Tue, 15 Jan 2013 17:06:01 +0000 (13:06 -0400)]
(Bug 40860) make purgeRedundantText not fail on pre MW1.5 records
Archive records for deleted pages do not have an ar_text_id,
if they were deleted before big schema overhaul in MW 1.5.
This script was assuming all archive records had an ar_text_id.
Patch by Dévai Tamás.
Change-Id: I4776a8a0f29b8299ec6d27949dc53a96ece81f39
Aaron Schulz [Mon, 21 Jan 2013 23:37:23 +0000 (15:37 -0800)]
[ExternalStore] Various cleanups to ExternalStore class.
* Removed redundant $wgExternalStores check
* Fixed broken (though unused) insert() function
* Added more documentation
* Other small cleanups
Change-Id: I0be5d9ebecd58b4f5673a6205f46bb7368d889c8
Brian Wolff [Fri, 4 Jan 2013 12:02:10 +0000 (08:02 -0400)]
Remove references to non-existent 'execute' right in Title.php
The permission checks in Title will automatically fail
any check against a special page, except for read, execute
and createaccount. However, execute is not a right. It
is not mentioned in any other MW file (or extension for
that matter). It is neither in the list of core user
rights in User.php, nor does it have a system msg
If someone wants to check if they can
run a special page, they should be doing a 'read'
check.
Note: The check in question was added in
bc23aede55e back in 2008
I'm unsure if it is better to just leave it alone, or remove it.
However, its presence could cause some confusion, hence this
commit. Additionally I was unsure if this justified a release
notes entry.
Change-Id: I9cf2b0424b9cb189ac122b8274ec681302f560f7
jenkins-bot [Tue, 22 Jan 2013 07:11:51 +0000 (07:11 +0000)]
Merge "(bug 41477) Add Language::isSupportedLanguage"
jenkins-bot [Tue, 22 Jan 2013 02:15:02 +0000 (02:15 +0000)]
Merge "Use better variable name in CoreParserFunctions::pagesize()"
jenkins-bot [Tue, 22 Jan 2013 02:13:18 +0000 (02:13 +0000)]
Merge "Use a LinkBatch for the creator/last editor user (talk) pages in InfoAction"
Alexandre Emsenhuber [Fri, 18 Jan 2013 21:17:06 +0000 (22:17 +0100)]
Use better variable name in CoreParserFunctions::pagesize()
Also moved the retrieval of the revision ID near the one of the
page ID so that the call of ParserOutput::addTemplate() is much
clearer than the actual one.
Change-Id: Ie71ee76e90cc131eac25c0f339d5250d5163ce2e
jenkins-bot [Mon, 21 Jan 2013 22:33:07 +0000 (22:33 +0000)]
Merge "Links created by Linker::makeExternalLink didn't include rel=nofollow"
jenkins-bot [Mon, 21 Jan 2013 22:22:12 +0000 (22:22 +0000)]
Merge "(bug 44202) Account creation through API no longer leaks IP address of account creator"
jenkins-bot [Mon, 21 Jan 2013 21:51:12 +0000 (21:51 +0000)]
Merge "Update doc comments and code formatting."
jenkins-bot [Mon, 21 Jan 2013 21:47:48 +0000 (21:47 +0000)]
Merge "[FileRepo] Flipped RENDER_FORCE check order to avoid stat."
Siebrand Mazeland [Fri, 11 Jan 2013 15:43:08 +0000 (16:43 +0100)]
Update doc comments and code formatting.
Change-Id: Ib182878e08d19261d9803fd4d7e215570a2ffed4
Aaron Schulz [Mon, 21 Jan 2013 21:36:01 +0000 (13:36 -0800)]
[FileRepo] Flipped RENDER_FORCE check order to avoid stat.
Change-Id: Ia12ea5a1152c49901a7f1157b06fd113c64fdec9
jenkins-bot [Mon, 21 Jan 2013 21:27:21 +0000 (21:27 +0000)]
Merge "(bug 44131) Change InfoAction cache key to use SHA1."
Alexandre Emsenhuber [Mon, 21 Jan 2013 11:03:46 +0000 (12:03 +0100)]
(bug 44202) Account creation through API no longer leaks IP address of account creator
This happens when an anonymous user wants to create an account for himself through
the API. This is due to the fact that User::addNewUserLogEntry() was always using
$wgUser as performer, but the API does not replace $wgUser by the newly created user
object when the peformer is an anonymous user.
Changed User::addNewUserLogEntry() to directly take the log action as first parameter,
rather than a boolean value saying whether the password was sent by e-mail or not,
and force the performer to be the user itself in the log action is "create". This
avoids such problems in that case, no matter the value of $wgUser, and it makes this
parameter much more readable that the old one. Backward compatibility is maintained.
Creating an user and sending its password by e-mail will still log the performer's
IP address in the log if this is made by an anonymous user.
Finally the second parameter of the AddNewAccount is now correct when creating an
account from the API, it was always false previously.
Change-Id: I188ecf420b85e9d1dab6fb933ed50d5f58532109
Translation updater bot [Mon, 21 Jan 2013 20:53:31 +0000 (20:53 +0000)]
Merge "Localisation updates from translatewiki.net."
jenkins-bot [Mon, 21 Jan 2013 20:36:33 +0000 (20:36 +0000)]
Merge "Fix ApiCreateAccountTest for $wgEnableEmail = false;"
Translation updater bot [Mon, 21 Jan 2013 20:36:10 +0000 (20:36 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Iff97ad6983cffcf001a9294765c1864b4b97bca7
Tyler Anthony Romeo [Mon, 21 Jan 2013 19:32:11 +0000 (14:32 -0500)]
(bug 44131) Change InfoAction cache key to use SHA1.
Long title names caused errors in caching of InfoAction
results, so this commit wraps the title in a SHA1 call
so that all titles will have valid cache keys.
Change-Id: I803a7dd58f5bd69070291192d3eead065d0403f1
jenkins-bot [Mon, 21 Jan 2013 18:46:01 +0000 (18:46 +0000)]
Merge "(bug 40354) Add support for formatnum in jqueryMsg parser"
jenkins-bot [Mon, 21 Jan 2013 17:08:06 +0000 (17:08 +0000)]
Merge "Pass database connection to SpecialWatchlist::countItems"
jenkins-bot [Mon, 21 Jan 2013 17:05:08 +0000 (17:05 +0000)]
Merge "Remove hardcoded quotes on integer"
jenkins-bot [Mon, 21 Jan 2013 17:02:16 +0000 (17:02 +0000)]
Merge "Use array for join condition"
jenkins-bot [Mon, 21 Jan 2013 17:00:28 +0000 (17:00 +0000)]
Merge "Trim spaces on user supplied comments"
daniel [Thu, 13 Dec 2012 21:16:05 +0000 (22:16 +0100)]
(bug 43008) Show error to user if content type doesn't support sections.
When trying to edit a page that does not support sections (like a JS or CSS page)
with section=new or so, show an informative error page instead of dying with
a fatal error.
Change-Id: I3d2901b715c10b52fab4fdc6b5e9ab5d887610bd
Santhosh Thottingal [Thu, 10 Jan 2013 17:33:51 +0000 (23:03 +0530)]
(bug 40354) Add support for formatnum in jqueryMsg parser
Support for {{formatnum:$1}} and {{formatnum:$1|R}} syntax in
jqueryMsg parser.
Takes an unformatted number (arab, no group separators and
'.' as decimal separator) and outputs it in the localized digit script
and formatted with decimal separator, according to the current language.
Unlike the result from php for this syntax, this does not do number
grouping(commafy).
See http://www.mediawiki.org/wiki/Help:Magic_words#Formatting.
Includes testcases for a few languages
Change-Id: I912fc719bd25e8b103f87facd05dcb409df7441c
Niklas Laxström [Mon, 14 Jan 2013 07:21:10 +0000 (07:21 +0000)]
(bug 41477) Add Language::isSupportedLanguage
Change-Id: If48c23fd580133bf78c19d4a0e8e00e74a639fa1
Alexandre Emsenhuber [Mon, 21 Jan 2013 06:52:43 +0000 (07:52 +0100)]
Use a LinkBatch for the creator/last editor user (talk) pages in InfoAction
This avoid having to do four single queries to know whether these pages exist.
Change-Id: I98b8c84abb2fc64c00fc2f3177b95c62c9606536
Brent Garber [Thu, 3 Jan 2013 23:05:17 +0000 (23:05 +0000)]
Fix changes for Ia1878588 to work with databases that use non-integer timestamps.
Change-Id: Id51ab135baa35440005b38f2f2f466f4378deb31
Translation updater bot [Sun, 20 Jan 2013 19:27:27 +0000 (19:27 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ib1d13763ee609bc0c239b901b2d431854d1d7413
umherirrender [Sat, 1 Dec 2012 19:11:21 +0000 (20:11 +0100)]
Trim spaces on user supplied comments
This helps on bug 29575
Change-Id: Ic05e5898f8a7c93a95188c9342d22c70d7413b09
jenkins-bot [Sun, 20 Jan 2013 02:06:26 +0000 (02:06 +0000)]
Merge "mediawiki.jqueryMsg: Fix regression and add tests."
Timo Tijhof [Sun, 20 Jan 2013 01:57:21 +0000 (02:57 +0100)]
mediawiki.jqueryMsg: Fix regression and add tests.
From If060b75f.
Thanks to jshint and us using Checkstyle reports in Jenkins
(instead of a boolean good/bad). We also see warnings that are
excluded from the regular count (but can still be useful).
https://integration.mediawiki.org/ci/job/mediawiki-core-lint/4617/checkstyleResult/NORMAL/
> Implied global 'arg'
The html escaping didn't do anything because the condition was
always false (there is no variable there by name of 'arg').
It didn't fail the tests because If060b75f didn't add any tests.
I added proper tests now for "foo [$1 bar]" where $1 is a url
containing characters ("&" specifically) that must not be double
escaped.
The test immediately failed. Addressed the bug in concat instead
of replace. append() is a very powerful jQuery method. It can
append:
* HTMLElement objects
* node lists
* jQuery objects
* Arrays with any of the above
* text strings
* html strings
"html strings" is likely decided by some kind of regex looking
for html-ish characters. Which is exactly what we don't want, we
want it to consider strings always as text, so we make a text
node instead.
And removed the useless if/else block in replace() as it was
always going for the else condition (and should). Effectively
undoing the fix from If060b75f that was supposedly fixing this
bug but didn't.
Change-Id: Ifbeae7e9bd003a33f353d42caffc3ae978c3dc56
jenkins-bot [Sat, 19 Jan 2013 18:54:58 +0000 (18:54 +0000)]
Merge "(bug 42513) mediawiki.Uri: Fix parsing of URIs with @ in path."
Tyler Anthony Romeo [Fri, 18 Jan 2013 17:46:02 +0000 (12:46 -0500)]
(bug 42513) mediawiki.Uri: Fix parsing of URIs with @ in path.
The regexes for URI parsing in mediawiki.Uri did not make sure
there were no slashes (/), question marks (?) or hashes (#) in
the username or password of the URI. As a result an @ symbol
later on in the url messed up the result.
This commit fixes the regexes so that URIs with an @ symbol in
the path, query, or fragment don't get interpreted as having
a username when they actually don't.
Change-Id: I4954bfd3750d5c990e91cc0dc8a175225ccbad1e
Translation updater bot [Sat, 19 Jan 2013 16:00:45 +0000 (16:00 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I53aa9ef0df035d632ceb09d280167003168ebf93
umherirrender [Sat, 19 Jan 2013 11:20:37 +0000 (12:20 +0100)]
Use array for join condition
Change-Id: I52875ebd5fc67e74439faf703b8119fedd70bfc9
jenkins-bot [Sat, 19 Jan 2013 10:17:16 +0000 (10:17 +0000)]
Merge "(bug 44024) ObjectCache changes break XCache 3.x support"
S Page [Fri, 18 Jan 2013 22:47:25 +0000 (14:47 -0800)]
Document that default timestamp is current time.
Change-Id: Ie255ac62a52f5d023f7cd6ffc6c0df91e7a02403
Brent Garber [Sat, 19 Jan 2013 03:43:03 +0000 (03:43 +0000)]
(bug 44024) ObjectCache changes break XCache 3.x support
Changes in the 1.20.x branch altered the add method to check for the return value of get against
false. Xcache 3.x returns NULL for unset values and so this check was erroneously determining that
all values are set when they were not.
This was causing basic ObjectCache usage to fail.
Change-Id: I0975e5c6a60c2813dc2d02aca84245807b8fb828
MatmaRex [Thu, 1 Nov 2012 13:16:41 +0000 (14:16 +0100)]
(bug 17808) (bug 21167) use real links for search suggestions
Use real links for search suggestions. This allows the viewer to, for
example, open the search results in a new tab or right-click them
to copy link's address.
We hook up the result.render callback and wrap the entire container
element (.suggestions-results <div>) in an <a>. This is permitted in HTML5
and appears to work even on IE 6. (It has some quirks related to e.g.
backgrounds handling, but thankfully none of them apply here, as we just
need it to be properly clickable - see http://jsbin.com/ejurub/2 for
a minimal test.)
We do the same for the special.render callback, although it has to be
handled slightly differently due to inconsistencies in $.suggestions that
would require a rewrite to fix.
We have to do some pretty ugly mangling to determine the links' hrefs,
but well, that's life.
This required some changes to $.suggestions:
* pass the necessary data to the render callback
* do not interfere with clicks with a mouse button other than left
or with modifier keys active, to allow for the standard link behavior
described above
* adjusting the width of suggestions container and applying autoellipsis
should be done regardless of the render callback being used or not
* add some flexibility to $.suggestions.highlight, so it doesn't break
down when DOM is modified
Also did some good-to-have changes to $.suggestions:
* detect suggestions elements in various places by their classes, not by
them being <div>s
Change-Id: I87940ca86a2b3776969cbcee8cdf93e3c66b0cd9
Aaron Schulz [Fri, 18 Jan 2013 20:30:56 +0000 (12:30 -0800)]
Align comment whitespace a bit.
Change-Id: I0e52a610586aab95021424eac28175b1a3b6d861
jenkins-bot [Fri, 18 Jan 2013 20:05:26 +0000 (20:05 +0000)]
Merge "(Bug 17970) {{PROTECTIONLEVEL}} should be able to return the status for pages besides the one it's on"
jenkins-bot [Fri, 18 Jan 2013 19:49:12 +0000 (19:49 +0000)]
Merge "Make redirect update in refreshLinks.php bypass the redirect table"
IAlex [Fri, 18 Jan 2013 19:21:47 +0000 (19:21 +0000)]
Merge "Moved $function definition up to make IDE happy."
jenkins-bot [Fri, 18 Jan 2013 19:15:30 +0000 (19:15 +0000)]
Merge "(bug 43762) Mark slow unit test as @group medium"
Brad Jorsch [Fri, 18 Jan 2013 19:02:28 +0000 (14:02 -0500)]
(bug 43762) Mark slow unit test as @group medium
All tests based on APITestCase can be slow. I've also seen more than one
Jenkins failure due to GlobalTest::testMerge timing out.
Also, added a meta-test on APITestCase to make sure that all its
subclasses are marked with @group medium or @group large, to prevent new
tests from re-causing the bug.
Change-Id: I48630736a3d06574876fd1fa3d90899cfbc48012
Niklas Laxström [Fri, 18 Jan 2013 18:50:38 +0000 (18:50 +0000)]
Check for no title and throw an exception
Fatal errors break test execution, exceptions not
See also bug 42145
PS: how many months does it take to fix a bug that
prevents running unit tests? Answer below.
Change-Id: I0b351a05be9d0850b467046e807651be254dcae2
Pavel Selitskas [Fri, 18 Jan 2013 19:03:01 +0000 (22:03 +0300)]
(Bug 17970) {{PROTECTIONLEVEL}} should be able to return the status for pages besides the one it's on
Change-Id: I4c60a5f25c739583eb087024c5e949ebcd2def72
Aaron Schulz [Fri, 18 Jan 2013 18:55:01 +0000 (10:55 -0800)]
Http function logic cleanups and comments.
Change-Id: Ibe309246960491958870610f69c253bf3ccc1637
jenkins-bot [Fri, 18 Jan 2013 18:49:04 +0000 (18:49 +0000)]
Merge "(bug 43959) Add ability to reset certain option kinds in API."
IAlex [Fri, 18 Jan 2013 18:43:38 +0000 (18:43 +0000)]
Merge "Do not send data for 0 increment calls in wfIncrStats()."
Tyler Anthony Romeo [Tue, 15 Jan 2013 01:45:01 +0000 (20:45 -0500)]
(bug 43959) Add ability to reset certain option kinds in API.
Added the "resetkinds" option to action=options, so that when the
"reset" option is set, the user can control which kinds of options
are reset, rather than having to do all or none.
Also added documentation to the "change" parameter, since passing
it option keys without any "=value" after it will result in resetting
that specific option to its default value.
Change-Id: Id5bc1fffa0d487c0f152b79115205d2722f380d3
Aaron Schulz [Fri, 18 Jan 2013 18:26:54 +0000 (10:26 -0800)]
Do not send data for 0 increment calls in wfIncrStats().
Change-Id: I5f1ca83ad56e129b42a96a5c73ec42cd2d978901
umherirrender [Fri, 18 Jan 2013 18:25:38 +0000 (19:25 +0100)]
Remove hardcoded quotes on integer
Change-Id: Ifb1e9777fe1338a5b97d061d80355d51d52ea8da
umherirrender [Sun, 13 Jan 2013 19:35:28 +0000 (20:35 +0100)]
Fix hardcode database quotes in Special:Watchlist
Change-Id: I0d53a24b35a855a541fb73d8bbfcace9de74e549
Yuri Astrakhan [Fri, 18 Jan 2013 15:23:17 +0000 (10:23 -0500)]
API debugging flag $wgDebugAPI to disable some security checks
Intentionally introduce a big security hole for debugging only.
Just like $wgShowDebug, $wgShowExceptionDetails, and $wgShowSQLErrors,
that introduce security vulnarabilities for debugging purposes,
this flag allows developers to remove some security checks in their
LocalSettings.php. This is a much safer approach than temporarily
changing production code to ignore certain conditions and later
forgetting to remove those changes before commiting the code.
Whenever enabled, a warning will allways be added to all output.
Change-Id: Ideb271dc1c9087f0843da03d024d70cc2cd776ae
Yuri Astrakhan [Mon, 14 Jan 2013 22:01:42 +0000 (17:01 -0500)]
(bug 35885) remove api version string and parameter
API was using SVN's version keyword which GIT does not support.
All related methods were either removed, or for those that
could have been used from extensions, emptied out.
api.php?version now shows unrecognized param warning.
Change-Id: I910ca1448ed2ed697ac19b17c486d130aa1d7e03
umherirrender [Fri, 18 Jan 2013 15:15:41 +0000 (16:15 +0100)]
Use array for database fields
Also reuse a existing database object
Change-Id: I42cc0636b25ba6266ab37ce0a7422e5863edf741
IAlex [Fri, 18 Jan 2013 14:50:55 +0000 (14:50 +0000)]
Merge "Fix return type doc. On SQLite ResultWrapper is returned"
jeroendedauw [Fri, 18 Jan 2013 14:40:05 +0000 (15:40 +0100)]
Fix return type doc. On SQLite ResultWrapper is returned
Change-Id: Ia18a0c6418d230d0a11b53efe40c3caeaa86300b
jenkins-bot [Fri, 18 Jan 2013 14:22:42 +0000 (14:22 +0000)]
Merge "Made upload stash cleanup script scan the temp dir for old files."
Antoine Musso [Thu, 22 Nov 2012 10:25:30 +0000 (11:25 +0100)]
testDecodeTagAttributes now use a data provider
We had a huge pile of assertEquals in a single test function, this patch
convert the mess in a nicer dataprovider.
The parameters passed to assertEquals() were mixed up, the expected
values should be passed as the first argument, I thus exchange the first
two parameters in each case.
Change-Id: Ib74804a7aa84a1e59fffb8c85abbf0b95995d897
Antoine Musso [Thu, 22 Nov 2012 10:23:13 +0000 (11:23 +0100)]
normalize sanitizerTest and add coverage tips
* @cover let us mention which function the test is using, help out when
building coverage report to make sure we only record traces for that
function.
* Normalized test functions so they look alike and make use of an
optional message.
Change-Id: I3e431b28e377f2ca21d06300537f63b2df4a3a99
Alexandre Emsenhuber [Fri, 18 Jan 2013 12:46:36 +0000 (13:46 +0100)]
Correct method name in ContentHandler comment
Change-Id: Iffc5a975cd7ae311d33147c35e59ba674d5e687b
Article::getReason() does not exist, but Article::generateReason() does.
jenkins-bot [Fri, 18 Jan 2013 12:08:12 +0000 (12:08 +0000)]
Merge "Made ORMTable and ORMRow non-abstract"
Liangent [Thu, 10 Jan 2013 06:18:27 +0000 (14:18 +0800)]
Disable template expansion in message <autoblocker>.
Sometimes sysops put template calls in block messages and they will be
expanded in the <blockedtext> interface. However in corresponding
autoblocks, template calls get expanded to long strings and truncated.
Change-Id: I3150192ec8c95d2e4807f058a855856e467145de
IAlex [Fri, 18 Jan 2013 10:00:59 +0000 (10:00 +0000)]
Merge "(bug 44010) Pass context to UserGetLanguageObject"
Niklas Laxström [Wed, 16 Jan 2013 09:47:06 +0000 (09:47 +0000)]
(bug 44010) Pass context to UserGetLanguageObject
Only way to avoid messing with wrong request contexts.
Had to add recursion guard too.
Change-Id: Idc11b54752450321e01d92004e08fc95fb6170e6
umherirrender [Sun, 13 Jan 2013 18:48:02 +0000 (19:48 +0100)]
Fix message movepagetext: Move to a empty page not possible
Change-Id: I55409499ce21f6155c4f92ea1f8858b5f4ae46c1
jeroendedauw [Fri, 18 Jan 2013 09:29:18 +0000 (10:29 +0100)]
Made ORMTable and ORMRow non-abstract
ORMTable now optionally takes info such as table name and field definitions in its constructor
Change-Id: I9cee11fdb58d4ef57d442f69650c6640d767cfa1
jenkins-bot [Fri, 18 Jan 2013 08:11:10 +0000 (08:11 +0000)]
Merge "Adding SpecialSearchResultsPrepend/Append hooks"
Ryan Finnie [Fri, 18 Jan 2013 00:46:40 +0000 (16:46 -0800)]
Adding SpecialSearchResultsPrepend/Append hooks
These hooks allow you to prepend, append or replace the search results
in Special:Search.
SpecialSearchResultsPrepend is executed immediately before the results
HTML begin to output. It can be used to include an external search
provider like Google CSE, for example. If the hook returns true, the
MediaWiki search results continue to output. If returned false, they
are suppressed.
SpecialSearchResultsAppend is executed immediately after the last
results HTML (including search navigation) are output. This hook is of
limited use since it will not be run in certain circumstances (there are
several points in the previous output logic where the function returns),
but is included for completeness.
Change-Id: Ib38433141979de999cdcab5eca26ba5416331aaa
Matthew Flaschen [Mon, 14 Jan 2013 03:40:18 +0000 (22:40 -0500)]
Revert "Overriding Vector's footer margin when in print mode"
This is not necessary since stylesheets with screen media queries are no longer shown in print mode.
This reverts commit
2b9e9f6a4a4c3bcfe04270194fd4f9a5b9f5a931.
Change-Id: I645f25837275bdddf9e6389e2ace279fd46b7c12
jenkins-bot [Fri, 18 Jan 2013 04:01:58 +0000 (04:01 +0000)]
Merge "Add guard to Resources.php"
jenkins-bot [Fri, 18 Jan 2013 03:42:33 +0000 (03:42 +0000)]
Merge "(bug 43942) Skip screen sheets with media queries when printing"
csteipp [Thu, 17 Jan 2013 18:58:13 +0000 (10:58 -0800)]
Add guard to Resources.php
Prevent direct calling of this file, just as we do in many other
places. Resources.php threw a fatal when called directly.
Change-Id: I10f5c013e81beaeb48d48e3eeaf1041d7236e9e9
Aaron Schulz [Fri, 18 Jan 2013 00:32:19 +0000 (16:32 -0800)]
Moved $function definition up to make IDE happy.
Change-Id: Ie42ba484c8c2f65a2ae233f0176a286578555cb2