From: Brion Vibber <brion@users.mediawiki.org>
Date: Thu, 3 Jul 2008 19:59:09 +0000 (+0000)
Subject: Revert r36907, 36908 ("(bug 13862) Add TOC to Special:SpecialPages.")
X-Git-Tag: 1.31.0-rc.0~46769
X-Git-Url: https://git.cyclocoop.org/admin/?a=commitdiff_plain;h=f629d7eb6bda682369e0c90bbad926a12a5f918a;p=lhc%2Fweb%2Fwiklou.git

Revert r36907, 36908 ("(bug 13862) Add TOC to Special:SpecialPages.")
* I'm not sure I really like the look of the horizontal layout for this many items.
* It reuses the "filetoc" ID, which is a poor practice as this isn't a file description page TOC. :)

The IDs for the sections are definitely useful as link anchors, but they may be ambiguous ("user", "wiki", etc) as well
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 047c8a6d5a..057193b871 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -177,8 +177,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * Add meta generator tag to HTML output
 * MediawikiPerformAction hook is now passed the Mediawiki object
 * Added blank special page Special:BlankPage for benchmarking, etc.
-* (bug 13862) Specialpages now has a horizontal TOC if there's three or more
-  groups.
 * Foreign repo file descriptions and thumbnails are now cached.
  
 === Bug fixes in 1.13 ===
diff --git a/includes/specials/SpecialSpecialpages.php b/includes/specials/SpecialSpecialpages.php
index 8c1299bc3f..ca91ad514b 100644
--- a/includes/specials/SpecialSpecialpages.php
+++ b/includes/specials/SpecialSpecialpages.php
@@ -48,21 +48,13 @@ function wfSpecialSpecialpages() {
 		$groups['other'] = $other;
 	}
 
-	if ( count( $groups ) >= 3 ) {
-		$wgOut->addHTML('<ul id="filetoc">');
-		foreach( $groups as $group => $pages ) {
-			$wgOut->addHTML('<li><a href="#' . $group . '">' . wfMsgHtml("specialpages-group-$group") . '</a></li>');
-		}
-		$wgOut->addHTML('</ul>');
-	}
-
 	/** Now output the HTML */
 	foreach ( $groups as $group => $sortedPages ) {
 		$middle = ceil( count($sortedPages)/2 );
 		$total = count($sortedPages);
 		$count = 0;
 
-		$wgOut->addHTML( "<h4 class='mw-specialpagesgroup' id='$group'>".wfMsgHtml("specialpages-group-$group")."</h4>\n" );
+		$wgOut->addHTML( "<h4 class='mw-specialpagesgroup'>".wfMsgHtml("specialpages-group-$group")."</h4>\n" );
 		$wgOut->addHTML( "<table style='width: 100%;' class='mw-specialpages-table'><tr>" );
 		$wgOut->addHTML( "<td width='30%' valign='top'><ul>\n" );
 		foreach( $sortedPages as $desc => $specialpage ) {