Use switch, not if/elseif/else
authorAryeh Gregor <simetrical@users.mediawiki.org>
Wed, 11 Apr 2007 04:09:48 +0000 (04:09 +0000)
committerAryeh Gregor <simetrical@users.mediawiki.org>
Wed, 11 Apr 2007 04:09:48 +0000 (04:09 +0000)
languages/classes/LanguageSl.php

index ec486af..e8f9456 100644 (file)
@@ -18,84 +18,54 @@ class LanguageSl extends Language {
 
                switch ( $case ) {
                        case 'rodilnik': # genitive
-                               if ( $word == 'Wikipedija' ) {
-                                       $word = 'Wikipedije';
-                               } elseif ( $word == 'Wikiknjige' ) {
-                                       $word = 'Wikiknjig';
-                               } elseif ( $word == 'Wikinovice' ) {
-                                       $word = 'Wikinovic';
-                               } elseif ( $word == 'Wikinavedek' ) {
-                                       $word = 'Wikinavedka';
-                               } elseif ( $word == 'Wikivir' ) {
-                                       $word = 'Wikivira';
-                               } elseif ( $word == 'Wikislovar' ) {
-                                       $word = 'Wikislovarja';
+                               switch ( $word ) {
+                                       case 'Wikipedija': $word = 'Wikipedije'; break 2;
+                                       case 'Wikiknjige': $word = 'Wikiknjig'; break 2;
+                                       case 'Wikinovice': $word = 'Wikinovic'; break 2;
+                                       case 'Wikinavedek': $word = 'Wikinavedka'; break 2;
+                                       case 'Wikivir': $word = 'Wikivira'; break 2;
+                                       case 'Wikislovar': $word = 'Wikislovarja'; break 2;
                                }
-                       break;
                        case 'dajalnik': # dativ
-                               if ( $word == 'Wikipedija' ) {
-                                       $word = 'Wikipediji';
-                               } elseif ( $word == 'Wikiknjige' ) {
-                                       $word = 'Wikiknjigam';
-                               } elseif ( $word == 'Wikinovice' ) {
-                                       $word = 'Wikinovicam';
-                               } elseif ( $word == 'Wikinavedek' ) {
-                                       $word = 'Wikinavedku';
-                               } elseif ( $word == 'Wikivir' ) {
-                                       $word = 'Wikiviru';
-                               } elseif ( $word == 'Wikislovar' ) {
-                                       $word = 'Wikislovarju';
+                               switch ( $word ) {
+                                       case 'Wikipedija': $word = 'Wikipediji'; break 2;
+                                       case 'Wikiknjige': $word = 'Wikiknjigam'; break 2;
+                                       case 'Wikinovice': $word = 'Wikinovicam'; break 2;
+                                       case 'Wikinavedek': $word = 'Wikinavedku'; break 2;
+                                       case 'Wikivir': $word = 'Wikiviru'; break 2;
+                                       case 'Wikislovar': $word = 'Wikislovarju'; break 2;
                                }
-                       break;
                        case 'tožilnik': # akuzatív
-                               if ( $word == 'Wikipedija' ) {
-                                       $word = 'Wikipedijo';
-                               } elseif ( $word == 'Wikiknjige' ) {
-                                       $word = 'Wikiknjige';
-                               } elseif ( $word == 'Wikinovice' ) {
-                                       $word = 'Wikinovice';
-                               } elseif ( $word == 'Wikinavedek' ) {
-                                       $word = 'Wikinavedek';
-                               } elseif ( $word == 'Wikivir' ) {
-                                       $word = 'Wikivir';
-                               } elseif ( $word == 'Wikislovar' ) {
-                                       $word = 'Wikislovar';
+                               switch ( $word ) {
+                                       case 'Wikipedija': $word = 'Wikipedijo'; break 2;
+                                       case 'Wikiknjige':
+                                       case 'Wikinovice':
+                                       case 'Wikinavedek':
+                                       case 'Wikivir':
+                                       case 'Wikislovar':
+                                               // Don't change, just fall through
+                                               break 2;
                                }
-                       break;
                        case 'mestnik': # locative
-                               if ( $word == 'Wikipedija' ) {
-                                       $word = 'o Wikipediji';
-                               } elseif ( $word == 'Wikiknjige' ) {
-                                       $word = 'o Wikiknjigah';
-                               } elseif ( $word == 'Wikinovice' ) {
-                                       $word = 'o Wikinovicah';
-                               } elseif ( $word == 'Wikinavedek' ) {
-                                       $word = 'o Wikinavedku';
-                               } elseif ( $word == 'Wikivir' ) {
-                                       $word = 'o Wikiviru';
-                               } elseif ( $word == 'Wikislovar' ) {
-                                       $word = 'o Wikislovarju';
-                               } else {
-                                       $word = 'o ' . $word;
+                               switch ( $word ) {
+                                       case 'Wikipedija': $word = 'o Wikipediji'; break 2;
+                                       case 'Wikiknjige': $word = 'o Wikiknjigah'; break 2;
+                                       case 'Wikinovice': $word = 'o Wikinovicah'; break 2;
+                                       case 'Wikinavedek': $word = 'o Wikinavedku'; break 2;
+                                       case 'Wikivir': $word = 'o Wikiviru'; break 2;
+                                       case 'Wikislovar': $word = 'o Wikislovarju'; break 2;
+                                       default: $word = 'o ' . $word; break 2;
                                }
-                       break;
                        case 'orodnik': # instrumental
-                               if ( $word == 'Wikipedija' ) {
-                                       $word = 'z Wikipedijo';
-                               } elseif ( $word == 'Wikiknjige' ) {
-                                       $word = 'z Wikiknjigami';
-                               } elseif ( $word == 'Wikinovice' ) {
-                                       $word = 'z Wikinovicami';
-                               } elseif ( $word == 'Wikinavedek' ) {
-                                       $word = 'z Wikinavedkom';
-                               } elseif ( $word == 'Wikivir' ) {
-                                       $word = 'z Wikivirom';
-                               } elseif ( $word == 'Wikislovar' ) {
-                                       $word = 'z Wikislovarjem';
-                               } else {
-                                       $word = 'z ' . $word;
+                               switch ( $word ) {
+                                       case 'Wikipedija': $word = 'z Wikipedijo'; break 2;
+                                       case 'Wikiknjige': $word = 'z Wikiknjigami'; break 2;
+                                       case 'Wikinovice': $word = 'z Wikinovicami'; break 2;
+                                       case 'Wikinavedek': $word = 'z Wikinavedkom'; break 2;
+                                       case 'Wikivir': $word = 'z Wikivirom'; break 2;
+                                       case 'Wikislovar': $word = 'z Wikislovarjem'; break 2;
+                                       default: $word = 'z ' . $word;
                                }
-                       break;
                }
 
                return $word; # this will return the original value for 'imenovalnik' (nominativ) and all undefined case values