Followup r74392. Also cache result of getUser call (may be called twice)
authorSam Reed <reedy@users.mediawiki.org>
Sun, 17 Oct 2010 18:54:39 +0000 (18:54 +0000)
committerSam Reed <reedy@users.mediawiki.org>
Sun, 17 Oct 2010 18:54:39 +0000 (18:54 +0000)
includes/api/ApiQueryRevisions.php

index a8f83a2..c495d3b 100644 (file)
@@ -376,13 +376,14 @@ class ApiQueryRevisions extends ApiQueryBase {
                                if ( $this->fld_user ) {
                                        $vals['user'] = $revision->getUserText();
                                }
-                               if ( $this->fld_userid ) {
-                                       $user = User::newFromName( $revision->getUserText() );
-                                       $vals['userid'] = $user->getId();
-                               }
-                               if ( !$revision->getUser() ) {
+                               $userid = $revision->getUser();
+                               if ( !$userid ) {
                                        $vals['anon'] = '';
                                }
+
+                               if ( $this->fld_userid ) {
+                                       $vals['userid'] = $userid;
+                               }
                        }
                }