* Finish fixing bug 3205, and bump up $wgStyleVersion.

* Added $wgStyleVersion to a stylesheet call that brion missed.
* Add informative comment to the top of common_rtl.css to the effect that it is really common to all skins, unlike common.css.

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index cf974f1..50694b6 100644 (file)
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -1030,7 +1030,7 @@ $wgCacheEpoch = '20030516000000';
  * to ensure that client-side caches don't keep obsolete copies of global
  * styles.
  */
-$wgStyleVersion = '13';
+$wgStyleVersion = '14';
 
 # Server-side caching:
 

diff --git a/includes/Skin.php b/includes/Skin.php
index 6baad7e..764817b 100644 (file)
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -364,7 +364,7 @@ class Skin extends Linker {
                $sheet = $this->getStylesheet();
                $action = $wgRequest->getText('action');
                $s = "@import \"$wgStylePath/$sheet?$wgStyleVersion\";\n";
-               if($wgContLang->isRTL()) $s .= "@import \"$wgStylePath/common/common_rtl.css?1\";\n";
+               if($wgContLang->isRTL()) $s .= "@import \"$wgStylePath/common/common_rtl.css?$wgStyleVersion\";\n";
 
                $query = "usemsgcache=yes&action=raw&ctype=text/css&smaxage=$wgSquidMaxage";
                $s .= '@import "' . self::makeNSUrl( 'Common.css', $query, NS_MEDIAWIKI ) . "\";\n" .

diff --git a/skins/common/common.css b/skins/common/common.css
index 1e143ad..64dbff7 100644 (file)
--- a/skins/common/common.css
+++ b/skins/common/common.css
@@ -4,7 +4,7 @@
  */
 #footer { clear: both }
 /* images */
-div.floatright { float: right; margin: 0 0 1em 1em; }
+div.floatright { float: right; clear: right; margin: 0 0 1em 1em; }
 div.floatright p { font-style: italic; }
 div.floatleft { float: left; margin: 0.3em 0.5em 0.5em 0; }
 div.floatleft p { font-style: italic; }

diff --git a/skins/common/commonPrint.css b/skins/common/commonPrint.css
index e23c50b..1bda4fd 100644 (file)
--- a/skins/common/commonPrint.css
+++ b/skins/common/commonPrint.css
@@ -28,7 +28,8 @@ a.new{ color:#ba0000; text-decoration:none; }
 
 /* images */
 div.floatright { 
-    float: right; 
+    float: right;
+    clear: right;
     margin: 0;
     position:relative;
     border: 0.5em solid White;
@@ -136,7 +137,7 @@ h1, h2, h3, h4, h5, h6
 
 p, .documentDescription {
     margin: 1em 0 ! important;
-    line-height: 1.2em;    
+    line-height: 1.2em;
 }
 
 .tocindent p {

diff --git a/skins/common/common_rtl.css b/skins/common/common_rtl.css
index 5a7bf05..651c4dc 100644 (file)
--- a/skins/common/common_rtl.css
+++ b/skins/common/common_rtl.css
@@ -1,3 +1,6 @@
+/* This CSS file is called from absolutely every wiki that's RTL: unlike
+ * common.css, it's actually common to all skins. */
+
 /* js pref toc */
 #preftoc { float: right; }
 /* workaround for moz bug, displayed bullets on left side */
@@ -17,9 +20,9 @@ div.editsection {
        float: left;
        margin-right: 5px;
 }
-div.tright {
+div.tright, div.floatright {
        clear: none;
 }
-div.tleft {
+div.tleft, div.floatleft {
        clear: left;
 }
\ No newline at end of file