* Right-align diff line numbers in RTL language display

Use .diff-lineno class instead of hardcoding a <strong> and an alignment. Leaving default alignment does the right thing in both LTR and RTL; forcing left was unnecessary.
Also swapping alignment for the +/- marker column to improve look on RTL.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index dddfec6..1533729 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -64,6 +64,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   and the dupes removed from the default skin files.
   Skins can still override the default rules.
 * (bug 1229) Balance columns in diff display evenly
+* Right-align diff line numbers in RTL language display
 
 
 == MediaWiki API changes since 1.10 ==

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index aaff730..de3cdaa 100644 (file)
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -1125,7 +1125,7 @@ $wgCacheEpoch = '20030516000000';
  * to ensure that client-side caches don't keep obsolete copies of global
  * styles.
  */
-$wgStyleVersion = '70';
+$wgStyleVersion = '71';
 
 
 # Server-side caching:

diff --git a/includes/DifferenceEngine.php b/includes/DifferenceEngine.php
index 5634a4c..3b9f885 100644 (file)
--- a/includes/DifferenceEngine.php
+++ b/includes/DifferenceEngine.php
@@ -1734,8 +1734,8 @@ class TableDiffFormatter extends DiffFormatter
        }
 
        function _block_header( $xbeg, $xlen, $ybeg, $ylen ) {
-               $r = '<tr><td colspan="2" align="left"><strong><!--LINE '.$xbeg."--></strong></td>\n" .
-                 '<td colspan="2" align="left"><strong><!--LINE '.$ybeg."--></strong></td></tr>\n";
+               $r = '<tr><td colspan="2" class="diff-lineno"><!--LINE '.$xbeg."--></td>\n" .
+                 '<td colspan="2" class="diff-lineno"><!--LINE '.$ybeg."--></td></tr>\n";
                return $r;
        }
 

diff --git a/skins/common/diff.css b/skins/common/diff.css
index 0e7fd06..f8825a3 100644 (file)
--- a/skins/common/diff.css
+++ b/skins/common/diff.css
@@ -11,6 +11,12 @@ td.diff-ntitle {
 td.diff-marker {
        text-align: right;
 }
+.rtl td.diff-marker {
+       text-align: left;
+}
+td.diff-lineno {
+       font-weight: bold;
+}
 td.diff-addedline {
        background: #cfc;
        font-size: smaller;