'Special-case optimization' seems to be already included in User::getId, in a smarter...

diff --git a/includes/SpecialUserrights.php b/includes/SpecialUserrights.php
index c5ab965..a2d78c7 100644 (file)
--- a/includes/SpecialUserrights.php
+++ b/includes/SpecialUserrights.php
@@ -208,7 +208,7 @@ class UserrightsForm extends HTMLForm {
                        $user = UserRightsProxy::newFromName( $database, $name );
                }
                
-               if( !$user || $user->getId() == 0 ) {
+               if( !$user || $user->isAnon() ) {
                        $wgOut->addWikiText( wfMsg( 'nosuchusershort', wfEscapeWikiText( $username ) ) );
                        return null;
                }

diff --git a/includes/User.php b/includes/User.php
index c22ed5f..756355a 100644 (file)
--- a/includes/User.php
+++ b/includes/User.php
@@ -1729,13 +1729,8 @@ class User {
         * Returns true if the user is not an anonymous visitor.
         *
         * @return bool
-        * @fixme "special-case optimization" may fail for an object referring to a user that doesn't exist in the system.
         */
        function isLoggedIn() {
-               if( $this->mId === null and $this->mName !== null ) {
-                       // Special-case optimization
-                       return !self::isIP( $this->mName );
-               }
                return $this->getID() != 0;
        }