This will result in a neat little test failure instead of an
unreadable thirty-line traceback when the test fails.
Change-Id: Ie0b564a95586d72eb730ab8a70a6175eb3ae743d
* @param string $file
* @param ResourceLoaderModule $module The ResourceLoader module that
* contains the file
* @param string $file
* @param ResourceLoaderModule $module The ResourceLoader module that
* contains the file
- * @throws PHPUnit_Framework_Exception When the file parameter isn't a
- * string or readable file
*/
public function __construct( $file, ResourceLoaderModule $module ) {
*/
public function __construct( $file, ResourceLoaderModule $module ) {
- if ( !is_string( $file ) || !is_file( $file ) || !is_readable( $file ) ) {
- throw PHPUnit_Util_InvalidArgumentHelper::factory( 1, 'readable file' );
- }
-
parent::__construct( 'testLessFileCompilation' );
$this->file = $file;
parent::__construct( 'testLessFileCompilation' );
$this->file = $file;
}
public function testLessFileCompilation() {
}
public function testLessFileCompilation() {
+ $thisString = $this->toString();
+ $this->assertTrue(
+ is_string( $this->file ) && is_file( $this->file ) && is_readable( $this->file ),
+ "$thisString must refer to a readable file"
+ );
+
$compiler = ResourceLoader::getLessCompiler();
$this->assertNotNull( $compiler->compileFile( $this->file ) );
}
$compiler = ResourceLoader::getLessCompiler();
$this->assertNotNull( $compiler->compileFile( $this->file ) );
}