we must have a session when testing Api upload.
authorAntoine Musso <hashar@users.mediawiki.org>
Thu, 27 Oct 2011 10:28:25 +0000 (10:28 +0000)
committerAntoine Musso <hashar@users.mediawiki.org>
Thu, 27 Oct 2011 10:28:25 +0000 (10:28 +0000)
commit7f2e429c17da4db5e1ed3e9001420f03b5127551
treedb64894fd1104191b8172491f9c8af1b78370118
parent911df0bdfa705f2649be602023f515b0686450c9
we must have a session when testing Api upload.

For some reason, the ApiUploadTest::testLogin method no more returns a valid
session. Since most, if not all, of the ApiUploadTest tests depends on it
we want that testLogin method to fail so we can skip the rest of the tests.

Test command:
  ./phpunit.php --filter ApiUpload --tap

BEFORE:
=======

TAP version 13
array(0) {
}
ok 1 - ApiUploadTest::testLogin
ok 2 - ApiUploadTest::testUploadRequiresToken
not ok 3 - Error: ApiUploadTest::testUploadMissingParams
not ok 4 - Error: ApiUploadTest::testUpload
^C

AFTER:
======

TAP version 13
not ok 1 - Failure: ApiUploadTest::testLogin
  ---
  message: 'API Login must return a session'
  severity: fail
  ...
ok 1 - # SKIP This test depends on "ApiUploadTest::testLogin" to pass.
ok 1 - # SKIP This test depends on "ApiUploadTest::testLogin" to pass.
^C ... more skips
tests/phpunit/includes/api/ApiUploadTest.php