function newFromId( $id ) {
return Revision::newFromConds(
array( 'page_id=rev_page',
- 'rev_id' => IntVal( $id ) ) );
+ 'rev_id' => intval( $id ) ) );
}
-
+
/**
* Load either the current, or a specified, revision
* that's attached to a given title. If not attached
*/
function newFromTitle( &$title, $id = 0 ) {
if( $id ) {
- $matchId = IntVal( $id );
+ $matchId = intval( $id );
} else {
$matchId = 'page_latest';
}
'page_namespace' => $title->getNamespace(),
'page_title' => $title->getDbkey() ) );
}
-
+
/**
* Load either the current, or a specified, revision
* that's attached to a given page. If not attached
* @access public
*/
function loadFromPageId( &$db, $pageid, $id = 0 ) {
+ $conds=array('page_id=rev_page','rev_page'=>intval( $pageid ), 'page_id'=>intval( $pageid ));
if( $id ) {
- $matchId = IntVal( $id );
+ $conds['rev_id']=intval($id);
} else {
- $matchId = 'page_latest';
+ $conds[]='rev_id=page_latest';
}
- return Revision::loadFromConds(
- $db,
- array( "rev_id=$matchId",
- 'rev_page' => IntVal( $pageid ),
- 'page_id=rev_page' ) );
+ return Revision::loadFromConds( $db, $conds );
}
-
+
/**
* Load either the current, or a specified, revision
* that's attached to a given page. If not attached
*/
function loadFromTitle( &$db, $title, $id = 0 ) {
if( $id ) {
- $matchId = IntVal( $id );
+ $matchId = intval( $id );
} else {
$matchId = 'page_latest';
}
'page_namespace' => $title->getNamespace(),
'page_title' => $title->getDbkey() ) );
}
-
+
/**
* Load the revision for the given title with the given timestamp.
* WARNING: Timestamps may in some circumstances not be unique,
'page_namespace' => $title->getNamespace(),
'page_title' => $title->getDbkey() ) );
}
-
+
/**
* Given a set of conditions, fetch a revision.
*
}
return $row;
}
-
+
/**
* Given a set of conditions, fetch a revision from
* the given database connection.
$row = $res->fetchObject();
$res->free();
if( $row ) {
- return new Revision( $row );
+ $ret = new Revision( $row );
+ return $ret;
}
}
- return null;
+ $ret = null;
+ return $ret;
}
-
+
/**
* Return a wrapper for a series of database rows to
* fetch all of a given page's revisions in turn.
wfGetDB( DB_SLAVE ),
array( 'page_namespace' => $title->getNamespace(),
'page_title' => $title->getDbkey(),
- 'page_id=rev_page' ) );
+ 'page_id=rev_page' ) );
}
-
+
/**
* Return a wrapper for a series of database rows to
* fetch all of a given page's revisions in turn.
array( 'rev_id=page_latest',
'page_namespace' => $title->getNamespace(),
'page_title' => $title->getDbkey(),
- 'page_id=rev_page' ) );
+ 'page_id=rev_page' ) );
}
-
+
/**
* Given a set of conditions, return a ResultWrapper
* which will return matching database rows with the
$conditions,
'Revision::fetchRow',
array( 'LIMIT' => 1 ) );
- return $db->resultObject( $res );
+ $ret = $db->resultObject( $res );
+ return $ret;
}
-
+
/**
* @param object $row
* @access private
*/
function Revision( $row ) {
if( is_object( $row ) ) {
- $this->mId = IntVal( $row->rev_id );
- $this->mPage = IntVal( $row->rev_page );
- $this->mTextId = IntVal( $row->rev_text_id );
+ $this->mId = intval( $row->rev_id );
+ $this->mPage = intval( $row->rev_page );
+ $this->mTextId = intval( $row->rev_text_id );
$this->mComment = $row->rev_comment;
$this->mUserText = $row->rev_user_text;
- $this->mUser = IntVal( $row->rev_user );
- $this->mMinorEdit = IntVal( $row->rev_minor_edit );
+ $this->mUser = intval( $row->rev_user );
+ $this->mMinorEdit = intval( $row->rev_minor_edit );
$this->mTimestamp = $row->rev_timestamp;
- $this->mDeleted = IntVal( $row->rev_deleted );
-
+ $this->mDeleted = intval( $row->rev_deleted );
+
$this->mCurrent = ( $row->rev_id == $row->page_latest );
$this->mTitle = Title::makeTitle( $row->page_namespace,
$row->page_title );
-
+
if( isset( $row->old_text ) ) {
$this->mText = $this->getRevisionText( $row );
} else {
} elseif( is_array( $row ) ) {
// Build a new revision to be saved...
global $wgUser;
-
- $this->mId = isset( $row['id'] ) ? IntVal( $row['id'] ) : null;
- $this->mPage = isset( $row['page'] ) ? IntVal( $row['page'] ) : null;
- $this->mTextId = isset( $row['text_id'] ) ? IntVal( $row['text_id'] ) : null;
- $this->mUserText = isset( $row['user_text'] ) ? StrVal( $row['user_text'] ) : $wgUser->getName();
- $this->mUser = isset( $row['user'] ) ? IntVal( $row['user'] ) : $wgUser->getId();
- $this->mMinorEdit = isset( $row['minor_edit'] ) ? IntVal( $row['minor_edit'] ) : 0;
- $this->mTimestamp = isset( $row['timestamp'] ) ? StrVal( $row['timestamp'] ) : wfTimestamp( TS_MW );
- $this->mDeleted = isset( $row['deleted'] ) ? IntVal( $row['deleted'] ) : 0;
-
+
+ $this->mId = isset( $row['id'] ) ? intval( $row['id'] ) : null;
+ $this->mPage = isset( $row['page'] ) ? intval( $row['page'] ) : null;
+ $this->mTextId = isset( $row['text_id'] ) ? intval( $row['text_id'] ) : null;
+ $this->mUserText = isset( $row['user_text'] ) ? strval( $row['user_text'] ) : $wgUser->getName();
+ $this->mUser = isset( $row['user'] ) ? intval( $row['user'] ) : $wgUser->getId();
+ $this->mMinorEdit = isset( $row['minor_edit'] ) ? intval( $row['minor_edit'] ) : 0;
+ $this->mTimestamp = isset( $row['timestamp'] ) ? strval( $row['timestamp'] ) : wfTimestamp( TS_MW );
+ $this->mDeleted = isset( $row['deleted'] ) ? intval( $row['deleted'] ) : 0;
+
// Enforce spacing trimming on supplied text
- $this->mComment = isset( $row['comment'] ) ? trim( StrVal( $row['comment'] ) ) : null;
- $this->mText = isset( $row['text'] ) ? rtrim( StrVal( $row['text'] ) ) : null;
-
+ $this->mComment = isset( $row['comment'] ) ? trim( strval( $row['comment'] ) ) : null;
+ $this->mText = isset( $row['text'] ) ? rtrim( strval( $row['text'] ) ) : null;
+
$this->mTitle = null; # Load on demand if needed
$this->mCurrent = false;
} else {
wfDebugDieBacktrace( 'Revision constructor passed invalid row format.' );
}
}
-
+
/**#@+
* @access public
*/
-
+
/**
* @return int
*/
function getId() {
return $this->mId;
}
-
+
/**
* @return int
*/
function getTextId() {
return $this->mTextId;
}
-
+
/**
* Returns the title of the page associated with this entry.
* @return Title
}
return $this->mTitle;
}
-
+
/**
* @return int
*/
function getPage() {
return $this->mPage;
}
-
+
/**
* @return int
*/
function getUser() {
return $this->mUser;
}
-
+
/**
* @return string
*/
function getUserText() {
return $this->mUserText;
}
-
+
/**
* @return string
*/
function getComment() {
return $this->mComment;
}
-
+
/**
* @return bool
*/
function isMinor() {
return (bool)$this->mMinorEdit;
}
-
+
/**
* @return bool
*/
function isDeleted() {
return (bool)$this->mDeleted;
}
-
+
/**
* @return string
*/
}
return $this->mText;
}
-
+
/**
* @return string
*/
function getTimestamp() {
- return $this->mTimestamp;
+ return wfTimestamp(TS_MW, $this->mTimestamp);
}
-
+
/**
* @return bool
*/
function isCurrent() {
return $this->mCurrent;
}
-
+
/**
* @return Revision
*/
function getPrevious() {
$prev = $this->mTitle->getPreviousRevisionID( $this->mId );
- return Revision::newFromTitle( $this->mTitle, $prev );
+ if ( $prev ) {
+ return Revision::newFromTitle( $this->mTitle, $prev );
+ } else {
+ return null;
+ }
}
/**
*/
function getNext() {
$next = $this->mTitle->getNextRevisionID( $this->mId );
- return Revision::newFromTitle( $this->mTitle, $next );
+ if ( $next ) {
+ return Revision::newFromTitle( $this->mTitle, $next );
+ } else {
+ return null;
+ }
}
/**#@-*/
function getRevisionText( $row, $prefix = 'old_' ) {
$fname = 'Revision::getRevisionText';
wfProfileIn( $fname );
-
+
# Get data
$textField = $prefix . 'text';
$flagsField = $prefix . 'flags';
$text=ExternalStore::fetchFromURL($url);
}
- if( in_array( 'gzip', $flags ) ) {
- # Deal with optional compression of archived pages.
- # This can be done periodically via maintenance/compressOld.php, and
- # as pages are saved if $wgCompressRevisions is set.
- $text = gzinflate( $text );
- }
-
- if( in_array( 'object', $flags ) ) {
- # Generic compressed storage
- $obj = unserialize( $text );
-
- # Bugger, corrupted my test database by double-serializing
- if ( !is_object( $obj ) ) {
- $obj = unserialize( $obj );
+ // If the text was fetched without an error, convert it
+ if ( $text !== false ) {
+ if( in_array( 'gzip', $flags ) ) {
+ # Deal with optional compression of archived pages.
+ # This can be done periodically via maintenance/compressOld.php, and
+ # as pages are saved if $wgCompressRevisions is set.
+ $text = gzinflate( $text );
}
- $text = $obj->getText();
- }
-
- global $wgLegacyEncoding;
- if( $wgLegacyEncoding && !in_array( 'utf-8', $flags ) ) {
- # Old revisions kept around in a legacy encoding?
- # Upconvert on demand.
- global $wgInputEncoding, $wgContLang;
- $text = $wgContLang->iconv( $wgLegacyEncoding, $wgInputEncoding, $text );
+ if( in_array( 'object', $flags ) ) {
+ # Generic compressed storage
+ $obj = unserialize( $text );
+ $text = $obj->getText();
+ }
+
+ global $wgLegacyEncoding;
+ if( $wgLegacyEncoding && !in_array( 'utf-8', $flags ) ) {
+ # Old revisions kept around in a legacy encoding?
+ # Upconvert on demand.
+ global $wgInputEncoding, $wgContLang;
+ $text = $wgContLang->iconv( $wgLegacyEncoding, $wgInputEncoding . '//IGNORE', $text );
+ }
}
wfProfileOut( $fname );
return $text;
function compressRevisionText( &$text ) {
global $wgCompressRevisions;
$flags = array();
-
+
# Revisions not marked this way will be converted
# on load if $wgLegacyCharset is set in the future.
$flags[] = 'utf-8';
-
+
if( $wgCompressRevisions ) {
if( function_exists( 'gzdeflate' ) ) {
$text = gzdeflate( $text );
}
return implode( ',', $flags );
}
-
+
/**
* Insert a new revision into the database, returning the new revision ID
* number on success and dies horribly on failure.
* @return int
*/
function insertOn( &$dbw ) {
+ global $wgDefaultExternalStore;
+
$fname = 'Revision::insertOn';
wfProfileIn( $fname );
-
- $mungedText = $this->mText;
- $flags = Revision::compressRevisionText( $mungedText );
-
- # Record the text to the text table
+
+ $data = $this->mText;
+ $flags = Revision::compressRevisionText( $data );
+
+ # Write to external storage if required
+ if ( $wgDefaultExternalStore ) {
+ require_once('ExternalStore.php');
+ // Store and get the URL
+ $data = ExternalStore::insert( $wgDefaultExternalStore, $data );
+ if ( !$data ) {
+ # This should only happen in the case of a configuration error, where the external store is not valid
+ wfDebugDieBacktrace( "Unable to store text to external storage $wgDefaultExternalStore" );
+ }
+ if ( $flags ) {
+ $flags .= ',';
+ }
+ $flags .= 'external';
+ }
+
+ # Record the text (or external storage URL) to the text table
if( !isset( $this->mTextId ) ) {
$old_id = $dbw->nextSequenceValue( 'text_old_id_val' );
$dbw->insert( 'text',
array(
'old_id' => $old_id,
- 'old_text' => $mungedText,
+ 'old_text' => $data,
'old_flags' => $flags,
), $fname
);
$this->mTextId = $dbw->insertId();
}
-
+
# Record the edit in revisions
$rev_id = isset( $this->mId )
? $this->mId
'rev_deleted' => $this->mDeleted,
), $fname
);
-
- $this->mId = $dbw->insertId();
-
+
+ $this->mId = !is_null($rev_id) ? $rev_id : $dbw->insertId();
+
wfProfileOut( $fname );
return $this->mId;
}
-
+
/**
* Lazy-load the revision's text.
* Currently hardcoded to the 'text' table storage engine.
function loadText() {
$fname = 'Revision::loadText';
wfProfileIn( $fname );
-
+
$dbr =& wfGetDB( DB_SLAVE );
$row = $dbr->selectRow( 'text',
array( 'old_text', 'old_flags' ),
array( 'old_id' => $this->getTextId() ),
$fname);
-
+
if( !$row ) {
$dbw =& wfGetDB( DB_MASTER );
$row = $dbw->selectRow( 'text',
array( 'old_id' => $this->getTextId() ),
$fname);
}
-
+
$text = Revision::getRevisionText( $row );
wfProfileOut( $fname );
-
+
return $text;
}
function newNullRevision( &$dbw, $pageId, $summary, $minor ) {
$fname = 'Revision::newNullRevision';
wfProfileIn( $fname );
-
+
$current = $dbw->selectRow(
array( 'page', 'revision' ),
array( 'page_latest', 'rev_text_id' ),
'page_latest=rev_id',
),
$fname );
-
+
if( $current ) {
$revision = new Revision( array(
'page' => $pageId,
} else {
$revision = null;
}
-
+
wfProfileOut( $fname );
return $revision;
}
-
+
}
?>