replace TYPE= with ENGINE=, (supported since 4.0, TYPE deprecated since 4.1)
[lhc/web/wiklou.git] / includes / Article.php
index ac18a18..cd7ff01 100644 (file)
@@ -49,6 +49,56 @@ class Article {
                $this->mOldId = $oldId;
                $this->clear();
        }
+       
+       /**
+        * Tell the page view functions that this view was redirected
+        * from another page on the wiki.
+        * @param Title $from
+        */
+       function setRedirectedFrom( $from ) {
+               $this->mRedirectedFrom = $from;
+       }
+       
+       /**
+        * @return mixed false, Title of in-wiki target, or string with URL
+        */
+       function followRedirect() {
+               $text = $this->getContent();
+               $rt = Title::newFromRedirect( $text );
+               
+               # process if title object is valid and not special:userlogout
+               if( $rt ) {
+                       if( $rt->getInterwiki() != '' ) {
+                               if( $rt->isLocal() ) {
+                                       // Offsite wikis need an HTTP redirect.
+                                       //
+                                       // This can be hard to reverse and may produce loops,
+                                       // so they may be disabled in the site configuration.
+                                       
+                                       $source = $this->mTitle->getFullURL( 'redirect=no' );
+                                       return $rt->getFullURL( 'rdfrom=' . urlencode( $source ) );
+                               }
+                       } else {
+                               if( $rt->getNamespace() == NS_SPECIAL ) {
+                                       // Gotta hand redirects to special pages differently:
+                                       // Fill the HTTP response "Location" header and ignore
+                                       // the rest of the page we're on.
+                                       //
+                                       // This can be hard to reverse, so they may be disabled.
+                                       
+                                       if( $rt->getNamespace() == NS_SPECIAL && $rt->getText() == 'Userlogout' ) {
+                                               // rolleyes
+                                       } else {
+                                               return $rt->getFullURL();
+                                       }
+                               }
+                               return $rt;
+                       }
+               }
+               
+               // No or invalid redirect
+               return false;
+       }
 
        /**
         * get the title object of the article
@@ -66,7 +116,8 @@ class Article {
                $this->mContentLoaded = false;
 
                $this->mCurID = $this->mUser = $this->mCounter = -1; # Not loaded
-               $this->mRedirectedFrom = $this->mUserText =
+               $this->mRedirectedFrom = null; # Title object if set
+               $this->mUserText =
                $this->mTimestamp = $this->mComment = $this->mFileCache = '';
                $this->mGoodAdjustment = $this->mTotalAdjustment = 0;
                $this->mTouched = '19700101000000';
@@ -77,13 +128,17 @@ class Article {
        }
 
        /**
-        * Note that getContent/loadContent may follow redirects if
-        * not told otherwise, and so may cause a change to mTitle.
+        * Note that getContent/loadContent do not follow redirects anymore.
+        * If you need to fetch redirectable content easily, try
+        * the shortcut in Article::followContent()
+        *
+        * @fixme There are still side-effects in this!
+        *        In general, you should use the Revision class, not Article,
+        *        to fetch text for purposes other than page views.
         *
-        * @param $noredir
         * @return Return the text of this revision
        */
-       function getContent( $noredir ) {
+       function getContent() {
                global $wgRequest, $wgUser, $wgOut;
 
                # Get variables from query string :P
@@ -117,7 +172,7 @@ class Article {
 
                        return "<div class='noarticletext'>$ret</div>";
                } else {
-                       $this->loadContent( $noredir );
+                       $this->loadContent();
                        # check if we're displaying a [[User talk:x.x.x.x]] anonymous talk page
                        if ( $this->mTitle->getNamespace() == NS_USER_TALK &&
                          $wgUser->isIP($this->mTitle->getText()) &&
@@ -150,11 +205,6 @@ class Article {
        /**
         * Get the contents of a page from its title and remove includeonly tags
         *
-        * TODO FIXME: This is only here because of the inputbox extension and
-        * should be moved there
-        *
-        * @deprecated
-        *
         * @param string The title of the page
         * @return string The contents of the page
         */
@@ -295,14 +345,11 @@ class Article {
        /**
         * Load the revision (including text) into this object
         */
-       function loadContent( $noredir = false ) {
-               global $wgOut, $wgRequest;
-
+       function loadContent() {
                if ( $this->mContentLoaded ) return;
 
                # Query variables :P
                $oldid = $this->getOldID();
-               $redirect = $wgRequest->getVal( 'redirect' );
 
                $fname = 'Article::loadContent';
 
@@ -311,10 +358,8 @@ class Article {
 
                $t = $this->mTitle->getPrefixedText();
 
-               $noredir = $noredir || ($wgRequest->getVal( 'redirect' ) == 'no')
-                       || $wgRequest->getCheck( 'rdfrom' );
                $this->mOldId = $oldid;
-               $this->fetchContent( $oldid, $noredir, true );
+               $this->fetchContent( $oldid );
        }
 
 
@@ -372,6 +417,7 @@ class Article {
         * @access private
         */
        function loadPageData( $data ) {
+               $this->mTitle->mArticleID = $data->page_id;
                $this->mTitle->loadRestrictions( $data->page_restrictions );
                $this->mTitle->mRestrictionsLoaded = true;
 
@@ -385,12 +431,11 @@ class Article {
 
        /**
         * Get text of an article from database
+        * Does *NOT* follow redirects.
         * @param int $oldid 0 for whatever the latest revision is
-        * @param bool $noredir Set to false to follow redirects
-        * @param bool $globalTitle Set to true to change the global $wgTitle object when following redirects or other unexpected title changes
         * @return string
         */
-       function fetchContent( $oldid = 0, $noredir = true, $globalTitle = false ) {
+       function fetchContent( $oldid = 0 ) {
                if ( $this->mContentLoaded ) {
                        return $this->mContent;
                }
@@ -404,10 +449,6 @@ class Article {
                if( $oldid ) {
                        $t .= ',oldid='.$oldid;
                }
-               if( isset( $redirect ) ) {
-                       $redirect = ($redirect == 'no') ? 'no' : 'yes';
-                       $t .= ',redirect='.$redirect;
-               }
                $this->mContent = wfMsg( 'missingarticle', $t ) ;
 
                if( $oldid ) {
@@ -439,53 +480,6 @@ class Article {
                        }
                }
 
-               # If we got a redirect, follow it (unless we've been told
-               # not to by either the function parameter or the query
-               if ( !$oldid && !$noredir ) {
-                       $rt = Title::newFromRedirect( $revision->getText() );
-                       # process if title object is valid and not special:userlogout
-                       if ( $rt && ! ( $rt->getNamespace() == NS_SPECIAL && $rt->getText() == 'Userlogout' ) ) {
-                               # Gotta hand redirects to special pages differently:
-                               # Fill the HTTP response "Location" header and ignore
-                               # the rest of the page we're on.
-                               global $wgDisableHardRedirects;
-                               if( $globalTitle && !$wgDisableHardRedirects ) {
-                                       global $wgOut;
-                                       if ( $rt->getInterwiki() != '' && $rt->isLocal() ) {
-                                               $source = $this->mTitle->getFullURL( 'redirect=no' );
-                                               $wgOut->redirect( $rt->getFullURL( 'rdfrom=' . urlencode( $source ) ) ) ;
-                                               return false;
-                                       }
-                                       if ( $rt->getNamespace() == NS_SPECIAL ) {
-                                               $wgOut->redirect( $rt->getFullURL() );
-                                               return false;
-                                       }
-                               }
-                               if( $rt->getInterwiki() == '' ) {
-                                       $redirData = $this->pageDataFromTitle( $dbr, $rt );
-                                       if( $redirData ) {
-                                               $redirRev = Revision::newFromId( $redirData->page_latest );
-                                               if( !is_null( $redirRev ) ) {
-                                                       $this->mRedirectedFrom = $this->mTitle->getPrefixedText();
-                                                       $this->mTitle = $rt;
-                                                       $data = $redirData;
-                                                       $this->loadPageData( $data );
-                                                       $revision = $redirRev;
-                                               }
-                                       }
-                               }
-                       }
-               }
-
-               # if the title's different from expected, update...
-               if( $globalTitle ) {
-                       global $wgTitle;
-                       if( !$this->mTitle->equals( $wgTitle ) ) {
-                               $wgTitle = $this->mTitle;
-                       }
-               }
-
-               # Back to the business at hand...
                $this->mContent   = $revision->getText();
 
                $this->mUser      = $revision->getUser();
@@ -502,19 +496,6 @@ class Article {
                return $this->mContent;
        }
 
-       /**
-        * Gets the article text without using so many damn globals
-        *
-        * Used by maintenance/importLogs.php
-        *
-        * @param int $oldid
-        * @param bool $noredir Whether to follow redirects
-        * @return mixed the content (string) or false on error
-        */
-       function getContentWithoutUsingSoManyDamnGlobals( $oldid = 0, $noredir = false ) {
-               return $this->fetchContent( $oldid, $noredir, false );
-       }
-
        /**
         * Read/write accessor to select FOR UPDATE
         *
@@ -633,8 +614,6 @@ class Article {
         * @access private
         */
        function loadLastEdit() {
-               global $wgOut;
-
                if ( -1 != $this->mUser )
                        return;
 
@@ -791,6 +770,30 @@ class Article {
                        wfIncrStats( 'pcache_miss_stub' );
                }
 
+               $wasRedirected = false;
+               if ( isset( $this->mRedirectedFrom ) ) {
+                       // This is an internally redirected page view.
+                       // We'll need a backlink to the source page for navigation.
+                       if ( wfRunHooks( 'ArticleViewRedirect', array( &$this ) ) ) {
+                               $sk = $wgUser->getSkin();
+                               $redir = $sk->makeKnownLinkObj( $this->mRedirectedFrom, '', 'redirect=no' );
+                               $s = wfMsg( 'redirectedfrom', $redir );
+                               $wgOut->setSubtitle( $s );
+                               $wasRedirected = true;
+                       }
+               } elseif ( !empty( $rdfrom ) ) {
+                       // This is an externally redirected view, from some other wiki.
+                       // If it was reported from a trusted site, supply a backlink.
+                       global $wgRedirectSources;
+                       if( $wgRedirectSources && preg_match( $wgRedirectSources, $rdfrom ) ) {
+                               $sk = $wgUser->getSkin();
+                               $redir = $sk->makeExternalLink( $rdfrom, $rdfrom );
+                               $s = wfMsg( 'redirectedfrom', $redir );
+                               $wgOut->setSubtitle( $s );
+                               $wasRedirected = true;
+                       }
+               }
+               
                $outputDone = false;
                if ( $pcache ) {
                        if ( $wgOut->tryParserCache( $this, $wgUser ) ) {
@@ -798,21 +801,19 @@ class Article {
                        }
                }
                if ( !$outputDone ) {
-                       $text = $this->getContent( false ); # May change mTitle by following a redirect
+                       $text = $this->getContent();
                        if ( $text === false ) {
                                # Failed to load, replace text with error message
                                $t = $this->mTitle->getPrefixedText();
                                if( $oldid ) {
                                        $t .= ',oldid='.$oldid;
+                                       $text = wfMsg( 'missingarticle', $t );
+                               } else {
+                                       $text = wfMsg( 'noarticletext', $t );
                                }
-                               if( isset( $redirect ) ) {
-                                       $redirect = ($redirect == 'no') ? 'no' : 'yes';
-                                       $t .= ',redirect='.$redirect;
-                               }
-                               $text = wfMsg( 'missingarticle', $t );
                        }
 
-                       # Another whitelist check in case oldid or redirects are altering the title
+                       # Another whitelist check in case oldid is altering the title
                        if ( !$this->mTitle->userCanRead() ) {
                                $wgOut->loginToUse();
                                $wgOut->output();
@@ -825,32 +826,6 @@ class Article {
                                $this->setOldSubtitle( isset($this->mOldId) ? $this->mOldId : $oldid );
                                $wgOut->setRobotpolicy( 'noindex,follow' );
                        }
-                       $wasRedirected = false;
-                       if ( '' != $this->mRedirectedFrom ) {
-                               if ( wfRunHooks( 'ArticleViewRedirect', array( &$this ) ) ) {
-                                       $sk = $wgUser->getSkin();
-                                       $redir = $sk->makeKnownLink( $this->mRedirectedFrom, '', 'redirect=no' );
-                                       $s = wfMsg( 'redirectedfrom', $redir );
-                                       $wgOut->setSubtitle( $s );
-
-                                       // Check the parser cache again, for the target page
-                                       if( $pcache ) {
-                                               if( $wgOut->tryParserCache( $this, $wgUser ) ) {
-                                                       $outputDone = true;
-                                               }
-                                       }
-                                       $wasRedirected = true;
-                               }
-                       } elseif ( !empty( $rdfrom ) ) {
-                               global $wgRedirectSources;
-                               if( $wgRedirectSources && preg_match( $wgRedirectSources, $rdfrom ) ) {
-                                       $sk = $wgUser->getSkin();
-                                       $redir = $sk->makeExternalLink( $rdfrom, $rdfrom );
-                                       $s = wfMsg( 'redirectedfrom', $redir );
-                                       $wgOut->setSubtitle( $s );
-                                       $wasRedirected = true;
-                               }
-                       }
                }
                if( !$outputDone ) {
                        /**
@@ -893,7 +868,8 @@ class Article {
                                if( !$this->isCurrent() ) {
                                        $oldEditSectionSetting = $wgOut->mParserOptions->setEditSection( false );
                                }
-                               $wgOut->addWikiText( $text );
+                               # Display content and don't save to parser cache
+                               $wgOut->addPrimaryWikiText( $text, $this, false );
 
                                if( !$this->isCurrent() ) {
                                        $wgOut->mParserOptions->setEditSection( $oldEditSectionSetting );
@@ -993,23 +969,16 @@ class Article {
                $this->view();
        }
 
+       /**
+        * Handle action=purge
+        */
        function purge() {
-               global $wgUser, $wgRequest, $wgOut, $wgUseSquid;
-
-               if ( $wgUser->isLoggedIn() || $wgRequest->wasPosted() || ! wfRunHooks( 'ArticlePurge', array( &$this ) ) ) {
-                       // Invalidate the cache
-                       $this->mTitle->invalidateCache();
+               global $wgUser, $wgRequest, $wgOut;
 
-                       if ( $wgUseSquid ) {
-                               // Commit the transaction before the purge is sent
-                               $dbw = wfGetDB( DB_MASTER );
-                               $dbw->immediateCommit();
-
-                               // Send purge
-                               $update = SquidUpdate::newSimplePurge( $this->mTitle );
-                               $update->doUpdate();
+               if ( $wgUser->isLoggedIn() || $wgRequest->wasPosted() ) {
+                       if( wfRunHooks( 'ArticlePurge', array( &$this ) ) ) {
+                               $this->doPurge();
                        }
-                       $this->view();
                } else {
                        $msg = $wgOut->parse( wfMsg( 'confirm_purge' ) );
                        $action = $this->mTitle->escapeLocalURL( 'action=purge' );
@@ -1024,6 +993,26 @@ class Article {
                        $wgOut->addHTML( $msg );
                }
        }
+       
+       /**
+        * Perform the actions of a page purging
+        */
+       function doPurge() {
+               global $wgUseSquid;
+               // Invalidate the cache
+               $this->mTitle->invalidateCache();
+
+               if ( $wgUseSquid ) {
+                       // Commit the transaction before the purge is sent
+                       $dbw = wfGetDB( DB_MASTER );
+                       $dbw->immediateCommit();
+
+                       // Send purge
+                       $update = SquidUpdate::newSimplePurge( $this->mTitle );
+                       $update->doUpdate();
+               }
+               $this->view();
+       }
 
        /**
         * Insert a new empty page record for this article.
@@ -1137,14 +1126,11 @@ class Article {
        }
 
        /**
-        * Theoretically we could defer these whole insert and update
-        * functions for after display, but that's taking a big leap
-        * of faith, and we want to be able to report database
-        * errors at some point.
+        * Insert a new article into the database
         * @access private
         */
        function insertNewArticle( $text, $summary, $isminor, $watchthis, $suppressRC=false, $comment=false ) {
-               global $wgOut, $wgUser, $wgUseSquid;
+               global $wgUser;
 
                $fname = 'Article::insertNewArticle';
                wfProfileIn( $fname );
@@ -1199,10 +1185,10 @@ class Article {
                }
 
                if ($watchthis) {
-                       if(!$this->mTitle->userIsWatching()) $this->watch();
+                       if(!$this->mTitle->userIsWatching()) $this->doWatch();
                } else {
                        if ( $this->mTitle->userIsWatching() ) {
-                               $this->unwatch();
+                               $this->doUnwatch();
                        }
                }
 
@@ -1335,7 +1321,7 @@ class Article {
         * first set $wgUser, and clean up $wgDeferredUpdates after each edit.
         */
        function updateArticle( $text, $summary, $minor, $watchthis, $forceBot = false, $sectionanchor = '' ) {
-               global $wgOut, $wgUser, $wgDBtransactions, $wgMwRedir, $wgUseSquid;
+               global $wgUser, $wgDBtransactions, $wgUseSquid;
                global $wgPostCommitUpdateList, $wgUseFileCache;
 
                $fname = 'Article::updateArticle';
@@ -1366,7 +1352,7 @@ class Article {
                        $userAbort = ignore_user_abort( true );
                }
 
-               $oldtext = $this->getContent( true );
+               $oldtext = $this->getContent();
                $oldsize = strlen( $oldtext );
                $newsize = strlen( $text );
                $lastRevision = 0;
@@ -1425,14 +1411,14 @@ class Article {
                                if (!$this->mTitle->userIsWatching()) {
                                        $dbw->immediateCommit();
                                        $dbw->begin();
-                                       $this->watch();
+                                       $this->doWatch();
                                        $dbw->commit();
                                }
                        } else {
                                if ( $this->mTitle->userIsWatching() ) {
                                        $dbw->immediateCommit();
                                        $dbw->begin();
-                                       $this->unwatch();
+                                       $this->doUnwatch();
                                        $dbw->commit();
                                }
                        }
@@ -1481,8 +1467,7 @@ class Article {
         * the link tables and redirect to the new page.
         */
        function showArticle( $text, $subtitle , $sectionanchor = '', $me2, $now, $summary, $oldid ) {
-               global $wgOut, $wgUser;
-               global $wgUseEnotif;
+               global $wgOut;
 
                $fname = 'Article::showArticle';
                wfProfileIn( $fname );
@@ -1541,7 +1526,7 @@ class Article {
        }
 
        /**
-        * Add this page to $wgUser's watchlist
+        * User-interface handler for the "watch" action
         */
 
        function watch() {
@@ -1556,14 +1541,8 @@ class Article {
                        $wgOut->readOnlyPage();
                        return;
                }
-
-               if (wfRunHooks('WatchArticle', array(&$wgUser, &$this))) {
-
-                       $wgUser->addWatch( $this->mTitle );
-                       $wgUser->saveSettings();
-
-                       wfRunHooks('WatchArticleComplete', array(&$wgUser, &$this));
-
+               
+               if( $this->doWatch() ) {
                        $wgOut->setPagetitle( wfMsg( 'addedwatch' ) );
                        $wgOut->setRobotpolicy( 'noindex,follow' );
 
@@ -1574,11 +1553,30 @@ class Article {
 
                $wgOut->returnToMain( true, $this->mTitle->getPrefixedText() );
        }
-
+       
        /**
-        * Stop watching a page
+        * Add this page to $wgUser's watchlist
+        * @return bool true on successful watch operation
         */
+       function doWatch() {
+               global $wgUser;
+               if( $wgUser->isAnon() ) {
+                       return false;
+               }
+               
+               if (wfRunHooks('WatchArticle', array(&$wgUser, &$this))) {
+                       $wgUser->addWatch( $this->mTitle );
+                       $wgUser->saveSettings();
+
+                       return wfRunHooks('WatchArticleComplete', array(&$wgUser, &$this));
+               }
+               
+               return false;
+       }
 
+       /**
+        * User interface handler for the "unwatch" action.
+        */
        function unwatch() {
 
                global $wgUser, $wgOut;
@@ -1591,14 +1589,8 @@ class Article {
                        $wgOut->readOnlyPage();
                        return;
                }
-
-               if (wfRunHooks('UnwatchArticle', array(&$wgUser, &$this))) {
-
-                       $wgUser->removeWatch( $this->mTitle );
-                       $wgUser->saveSettings();
-
-                       wfRunHooks('UnwatchArticleComplete', array(&$wgUser, &$this));
-
+               
+               if( $this->doUnwatch() ) {
                        $wgOut->setPagetitle( wfMsg( 'removedwatch' ) );
                        $wgOut->setRobotpolicy( 'noindex,follow' );
 
@@ -1609,6 +1601,26 @@ class Article {
 
                $wgOut->returnToMain( true, $this->mTitle->getPrefixedText() );
        }
+       
+       /**
+        * Stop watching a page
+        * @return bool true on successful unwatch
+        */
+       function doUnwatch() {
+               global $wgUser;
+               if( $wgUser->isAnon() ) {
+                       return false;
+               }
+
+               if (wfRunHooks('UnwatchArticle', array(&$wgUser, &$this))) {
+                       $wgUser->removeWatch( $this->mTitle );
+                       $wgUser->saveSettings();
+
+                       return wfRunHooks('UnwatchArticleComplete', array(&$wgUser, &$this));
+               }
+               
+               return false;
+       }
 
        /**
         * action=protect handler
@@ -1634,7 +1646,7 @@ class Article {
         * @return bool true on success
         */
        function updateRestrictions( $limit = array(), $reason = '' ) {
-               global $wgUser, $wgOut, $wgRequest;
+               global $wgUser;
 
                if ( !$wgUser->isAllowed( 'protect' ) ) {
                        return false;
@@ -1816,7 +1828,7 @@ class Article {
        }
 
        /**
-        * Get the last N authors 
+        * Get the last N authors
         * @param int $num Number of revisions to get
         * @param string $revLatest The latest rev_id, selected from the master (optional)
         * @return array Array of authors, duplicates not removed
@@ -1836,7 +1848,7 @@ class Article {
                                        'page_namespace' => $this->mTitle->getNamespace(),
                                        'page_title' => $this->mTitle->getDBkey(),
                                        'rev_page = page_id'
-                               ), $fname, $this->getSelectOptions( array( 
+                               ), $fname, $this->getSelectOptions( array(
                                        'ORDER BY' => 'rev_timestamp DESC',
                                        'LIMIT' => $num
                                ) )
@@ -1910,7 +1922,7 @@ class Article {
         * Perform a deletion and output success or failure messages
         */
        function doDelete( $reason ) {
-               global $wgOut, $wgUser, $wgContLang;
+               global $wgOut, $wgUser;
                $fname = 'Article::doDelete';
                wfDebug( $fname."\n" );
 
@@ -1939,7 +1951,7 @@ class Article {
         * Returns success
         */
        function doDeleteArticle( $reason ) {
-               global $wgUser, $wgUseSquid, $wgDeferredUpdateList;
+               global $wgUseSquid, $wgDeferredUpdateList;
                global $wgPostCommitUpdateList, $wgUseTrackbacks;
 
                $fname = 'Article::doDeleteArticle';
@@ -1954,7 +1966,7 @@ class Article {
                        return false;
                }
 
-               $u = new SiteStatsUpdate( 0, 1, -(int)$this->isCountable( $this->getContent( true ) ), -1 );
+               $u = new SiteStatsUpdate( 0, 1, -(int)$this->isCountable( $this->getContent() ), -1 );
                array_push( $wgDeferredUpdateList, $u );
 
                $linksTo = $this->mTitle->getLinksTo();
@@ -2021,6 +2033,8 @@ class Article {
                $dbw->delete( 'pagelinks', array( 'pl_from' => $id ) );
                $dbw->delete( 'imagelinks', array( 'il_from' => $id ) );
                $dbw->delete( 'categorylinks', array( 'cl_from' => $id ) );
+               $dbw->delete( 'templatelinks', array( 'tl_from' => $id ) );
+               $dbw->delete( 'externallinks', array( 'el_from' => $id ) );
 
                # Log the deletion
                $log = new LogPage( 'delete' );
@@ -2050,7 +2064,7 @@ class Article {
                }
 
                if ( wfReadOnly() ) {
-                       $wgOut->readOnlyPage( $this->getContent( true ) );
+                       $wgOut->readOnlyPage( $this->getContent() );
                        return;
                }
                if( !$wgUser->matchEditToken( $wgRequest->getVal( 'token' ),
@@ -2188,6 +2202,7 @@ class Article {
 
                # Parse the text
                $options = new ParserOptions;
+               $options->setTidy(true);
                $poutput = $wgParser->parse( $text, $this->mTitle, $options, true, true, $newid );
 
                # Save it to the parser cache
@@ -2229,14 +2244,16 @@ class Article {
                # If this is another user's talk page, update newtalk
 
                if ($this->mTitle->getNamespace() == NS_USER_TALK && $shortTitle != $wgUser->getName()) {
-                       $other = User::newFromName( $shortTitle );
-                       if( is_null( $other ) && User::isIP( $shortTitle ) ) {
-                               // An anonymous user
-                               $other = new User();
-                               $other->setName( $shortTitle );
-                       }
-                       if( $other ) {
-                               $other->setNewtalk( true );
+                       if (wfRunHooks('ArticleEditUpdateNewTalk', array(&$this)) ) {
+                               $other = User::newFromName( $shortTitle );
+                               if( is_null( $other ) && User::isIP( $shortTitle ) ) {
+                                       // An anonymous user
+                                       $other = new User();
+                                       $other->setName( $shortTitle );
+                               }
+                               if( $other ) {
+                                       $other->setNewtalk( true );
+                               }
                        }
                }
 
@@ -2248,7 +2265,11 @@ class Article {
        }
 
        /**
-        * @todo document this function
+        * Generate the navigation links when browsing through an article revisions
+        * It shows the information as:
+        *   Revision as of <date>; view current revision
+        *   <- Previous version | Next Version ->
+        *
         * @access private
         * @param string $oldid         Revision ID of this article revision
         */
@@ -2261,7 +2282,10 @@ class Article {
                $lnk = $current
                        ? wfMsg( 'currentrevisionlink' )
                        : $lnk = $sk->makeKnownLinkObj( $this->mTitle, wfMsg( 'currentrevisionlink' ) );
-               $prevlink = $sk->makeKnownLinkObj( $this->mTitle, wfMsg( 'previousrevision' ), 'direction=prev&oldid='.$oldid );
+               $prev = $this->mTitle->getPreviousRevisionID( $oldid ) ;
+               $prevlink = $prev
+                       ? $sk->makeKnownLinkObj( $this->mTitle, wfMsg( 'previousrevision' ), 'direction=prev&oldid='.$oldid )
+                       : wfMsg( 'previousrevision' );
                $nextlink = $current
                        ? wfMsg( 'nextrevision' )
                        : $sk->makeKnownLinkObj( $this->mTitle, wfMsg( 'nextrevision' ), 'direction=next&oldid='.$oldid );
@@ -2298,7 +2322,6 @@ class Article {
                        $touched = $this->mTouched;
                        $cache = new CacheManager( $this->mTitle );
                        if($cache->isFileCacheGood( $touched )) {
-                               global $wgOut;
                                wfDebug( " tryFileCache() - about to load\n" );
                                $cache->loadFromFileCache();
                                return true;
@@ -2432,7 +2455,7 @@ class Article {
                        $old_user_abort = ignore_user_abort( true );
 
                        $dbw->query("LOCK TABLES $hitcounterTable WRITE");
-                       $dbw->query("CREATE TEMPORARY TABLE $acchitsTable TYPE=HEAP ".
+                       $dbw->query("CREATE TEMPORARY TABLE $acchitsTable ENGINE=HEAP ".
                                "SELECT hc_id,COUNT(*) AS hc_n FROM $hitcounterTable ".
                                'GROUP BY hc_id');
                        $dbw->query("DELETE FROM $hitcounterTable");
@@ -2624,6 +2647,9 @@ class Article {
        function getUsedTemplates() {
                $result = array();
                $id = $this->mTitle->getArticleID();
+               if( $id == 0 ) {
+                       return array();
+               }
 
                $dbr =& wfGetDB( DB_SLAVE );
                $res = $dbr->select( array( 'templatelinks' ),