Get rollback working on new schema
[lhc/web/wiklou.git] / includes / Article.php
index a216fc9..c885c59 100644 (file)
@@ -702,6 +702,77 @@ class Article {
                $wgUser->clearNotification( $this->mTitle );
        }
 
+       /**
+        * Insert a new empty page record for this article.
+        * This *must* be followed up by creating a revision
+        * and running $this->updateToLatest( $rev_id );
+        * or else the record will be left in a funky state.
+        * Best if all done inside a transaction.
+        *
+        * @param Database $dbw
+        * @return int The newly created page_id key
+        * @access private
+        */
+       function insertOn( &$dbw ) {
+               $fname = 'Article::insertOn';
+               wfProfileIn( $fname );
+               
+               $page_id = $dbw->nextSequenceValue( 'page_page_id_seq' );
+               $dbw->insert( 'page', array(
+                       'page_id'           => $page_id,
+                       'page_namespace'    => $this->mTitle->getNamespace(),
+                       'page_title'        => $this->mTitle->getDBkey(),
+                       'page_counter'      => 0,
+                       'page_restrictions' => '',
+                       'page_is_redirect'  => 0, # Will set this shortly...
+                       'page_is_new'       => 1,
+                       'page_random'       => wfRandom(),
+                       'page_touched'      => $dbw->timestamp(),
+                       'page_latest'       => 0, # Fill this in shortly...
+               ), $fname );
+               $newid = $dbw->insertId();
+               
+               wfProfileOut( $fname );
+               return $newid;
+       }
+       
+       /**
+        * Update the page record to point to a newly saved revision.
+        *
+        * @param Database $dbw
+        * @param int $revId
+        * @param string $text -- used to set length and redirect status if given
+        * @param int $lastRevision -- if given, will not overwrite the page field
+        *                             when different from the currently set value.
+        *                             Giving 0 indicates the new page flag should
+        *                             be set on.
+        * @return bool true on success, false on failure
+        * @access private
+        */
+       function updateRevisionOn( &$dbw, $revId, $text = '', $lastRevision = null ) {
+               $fname = 'Article::updateToRevision';
+               wfProfileIn( $fname );
+               
+               $conditions = array( 'page_id' => $this->getId() );
+               if( !is_null( $lastRevision ) ) {
+                       # An extra check against threads stepping on each other
+                       $conditions['page_latest'] = $lastRevision;
+               }
+               $dbw->update( 'page',
+                       array( /* SET */
+                               'page_latest'      => $revId,
+                               'page_touched'     => $dbw->timestamp(),
+                               'page_is_new'      => ($lastRevision === 0) ? 0 : 1,
+                               'page_is_redirect' => Article::isRedirect( $text ),
+                               'page_len'         => strlen( $text ),
+                       ),
+                       $conditions,
+                       $fname );
+               
+               wfProfileOut( $fname );
+               return ( $dbw->affectedRows() != 0 );
+       }
+       
        /**
         * Theoretically we could defer these whole insert and update
         * functions for after display, but that's taking a big leap
@@ -720,53 +791,26 @@ class Article {
                $ns = $this->mTitle->getNamespace();
                $ttl = $this->mTitle->getDBkey();
                $text = $this->preSaveTransform( $text );
-               if ( $this->isRedirect( $text ) ) { $redir = 1; }
-               else { $redir = 0; }
-
-               $now = wfTimestampNow();
-               wfSeedRandom();
-               $rand = wfRandom();
                $isminor = ( $isminor && $wgUser->isLoggedIn() ) ? 1 : 0;
-               
-               $mungedText = $text;
-               $flags = Revision::compressRevisionText( $mungedText );
 
                $dbw =& wfGetDB( DB_MASTER );
 
-               $old_id = $dbw->nextSequenceValue( 'text_old_id_seq' );
-               $dbw->insert( 'text', array(
-                       'old_id' => $old_id,
-                       'old_text' => $mungedText,
-                       'old_flags' => $flags,
-               ), $fname );
-               $revisionId = $dbw->insertId();
+               # Add the page record; stake our claim on this title!
+               $newid = $this->insertOn( $dbw );
                
-               $page_id = $dbw->nextSequenceValue( 'page_page_id_seq' );
-               $dbw->insert( 'page', array(
-                       'page_id' => $page_id,
-                       'page_namespace' => $ns,
-                       'page_title' => $ttl,
-                       'page_counter' => 0,
-                       'page_restrictions' => '',
-                       'page_is_redirect' => $redir,
-                       'page_is_new' => 1,
-                       'page_random' => $rand,
-                       'page_touched' => $dbw->timestamp($now),
-                       'page_latest' => $revisionId,
-               ), $fname );
-               $newid = $dbw->insertId();
-
-               $dbw->insert( 'revision', array(
-                       'rev_page' => $newid,
-                       'rev_id' => $revisionId,
-                       'rev_comment' => $summary,
-                       'rev_user' => $wgUser->getID(),
-                       'rev_timestamp' => $dbw->timestamp($now),
-                       'rev_minor_edit' => $isminor,
-                       'rev_user_text' => $wgUser->getName(),
-               ), $fname );
+               # Save the revision text...
+               $revision = new Revision( array(
+                       'page'       => $newid,
+                       'comment'    => $summary,
+                       'minor_edit' => $isminor,
+                       'text'       => $text
+                       ) );
+               $revisionId = $revision->insertOn( $dbw );
 
                $this->mTitle->resetArticleID( $newid );
+               
+               # Update the page record with revision data
+               $this->updateRevisionOn( $dbw, $revisionId, $text, 0 );
 
                Article::onArticleCreate( $this->mTitle );
                RecentChange::notifyNew( $now, $this->mTitle, $isminor, $wgUser, $summary );
@@ -918,8 +962,7 @@ class Article {
                $fname = 'Article::updateArticle';
                $good = true;
 
-               if ( $this->mMinorEdit ) { $me1 = 1; } else { $me1 = 0; }
-               if ( $minor && $wgUser->isLoggedIn() ) { $me2 = 1; } else { $me2 = 0; }
+               $isminor = ( $minor && $wgUser->isLoggedIn() );
                if ( $this->isRedirect( $text ) ) {
                        # Remove all content but redirect
                        # This could be done by reconstructing the redirect from a title given by 
@@ -953,50 +996,21 @@ class Article {
                          - $this->isCountable( $oldtext );
                        $now = wfTimestampNow();
 
-                       $mungedText = $text;
-                       $flags = Revision::compressRevisionText( $mungedText );
-                       
                        $lastRevision = $dbw->selectField(
                                'page', 'page_latest', array( 'page_id' => $this->getId() ) );
                        
-                       # Record the text to the text table
-                       $old_id = $dbw->nextSequenceValue( 'text_old_id_val' );
-                       $dbw->insert( 'text',
-                               array(
-                                       'old_id' => $old_id,
-                                       'old_text' => $mungedText,
-                                       'old_flags' => $flags,
-                               ), $fname
-                       );
-                       $revisionId = $dbw->insertId();
-                       
-                       # Record the edit in revisions
-                       $dbw->insert( 'revision',
-                               array(
-                                       'rev_id' => $revisionId,
-                                       'rev_page' => $this->getID(),
-                                       'rev_comment' => $summary,
-                                       'rev_minor_edit' => $me2,
-                                       'rev_user' => $wgUser->getID(),
-                                       'rev_user_text' => $wgUser->getName(),
-                                       'rev_timestamp' => $dbw->timestamp( $now ),
-                               ), $fname
-                       );
+                       $revision = new Revision( array(
+                               'page'       => $this->getId(),
+                               'comment'    => $summary,
+                               'minor_edit' => $isminor,
+                               'text'       => $text
+                               ) );
+                       $revisionId = $revision->insertOn( $dbw );
                        
                        # Update page
-                       $dbw->update( 'page',
-                               array( /* SET */
-                                       'page_latest' => $revisionId,
-                                       'page_touched' => $dbw->timestamp( $now ),
-                                       'page_is_new' => 0,
-                                       'page_is_redirect' => $redir,
-                               ), array( /* WHERE */
-                                       'page_id' => $this->getID(),
-                                       'page_latest' => $lastRevision, # Paranoia
-                               ), $fname
-                       );
+                       $ok = $this->updateRevisionOn( $dbw, $revisionId, $text, $lastRevision );
 
-                       if( $dbw->affectedRows() == 0 ) {
+                       if( !$ok ) {
                                /* Belated edit conflict! Run away!! */
                                $good = false;
                        } else {
@@ -1015,38 +1029,38 @@ class Article {
                }
 
                if ( $good ) {
-               if ($watchthis) {
-                       if (!$this->mTitle->userIsWatching()) $this->watch();
-               } else {
-                       if ( $this->mTitle->userIsWatching() ) {
-                               $this->unwatch();
+                       if ($watchthis) {
+                               if (!$this->mTitle->userIsWatching()) $this->watch();
+                       } else {
+                               if ( $this->mTitle->userIsWatching() ) {
+                                       $this->unwatch();
+                               }
                        }
-               }
-               # standard deferred updates
-               $this->editUpdates( $text, $summary, $minor, $now );
-
-
-               $urls = array();
-               # Template namespace
-               # Purge all articles linking here
-               if ( $this->mTitle->getNamespace() == NS_TEMPLATE) {
-                       $titles = $this->mTitle->getLinksTo();
-                       Title::touchArray( $titles );
+                       # standard deferred updates
+                       $this->editUpdates( $text, $summary, $minor, $now );
+       
+       
+                       $urls = array();
+                       # Template namespace
+                       # Purge all articles linking here
+                       if ( $this->mTitle->getNamespace() == NS_TEMPLATE) {
+                               $titles = $this->mTitle->getLinksTo();
+                               Title::touchArray( $titles );
+                               if ( $wgUseSquid ) {
+                                               foreach ( $titles as $title ) {
+                                                       $urls[] = $title->getInternalURL();
+                                               }
+                               }
+                       }
+       
+                       # Squid updates
                        if ( $wgUseSquid ) {
-                                       foreach ( $titles as $title ) {
-                                               $urls[] = $title->getInternalURL();
-                                       }
+                               $urls = array_merge( $urls, $this->mTitle->getSquidURLs() );
+                               $u = new SquidUpdate( $urls );
+                               array_push( $wgPostCommitUpdateList, $u );
                        }
-               }
-
-               # Squid updates
-               if ( $wgUseSquid ) {
-                       $urls = array_merge( $urls, $this->mTitle->getSquidURLs() );
-                       $u = new SquidUpdate( $urls );
-                       array_push( $wgPostCommitUpdateList, $u );
-               }
-
-               $this->showArticle( $text, wfMsg( 'updated' ), $sectionanchor, $me2, $now, $summary, $lastRevision );
+       
+                       $this->showArticle( $text, wfMsg( 'updated' ), $sectionanchor, $me2, $now, $summary, $lastRevision );
                }
                return $good;
        }
@@ -1216,8 +1230,7 @@ class Article {
                        return;
                }
 
-               $confirm = $wgRequest->getBool( 'wpConfirmProtect' ) &&
-                       $wgRequest->wasPosted() &&
+               $confirm = $wgRequest->wasPosted() &&
                        $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) );
                $moveonly = $wgRequest->getBool( 'wpMoveOnly' );
                $reason = $wgRequest->getText( 'wpReasonProtect' );
@@ -1285,14 +1298,12 @@ class Article {
                        $wgOut->setPageTitle( wfMsg( 'confirmunprotect' ) );
                        $wgOut->setSubtitle( wfMsg( 'unprotectsub', $sub ) );
                        $wgOut->addWikiText( wfMsg( 'confirmunprotecttext' ) );
-                       $check = htmlspecialchars( wfMsg( 'confirmunprotect' ) );
                        $protcom = htmlspecialchars( wfMsg( 'unprotectcomment' ) );
                        $formaction = $this->mTitle->escapeLocalURL( 'action=unprotect' . $par );
                } else {
                        $wgOut->setPageTitle( wfMsg( 'confirmprotect' ) );
                        $wgOut->setSubtitle( wfMsg( 'protectsub', $sub ) );
                        $wgOut->addWikiText( wfMsg( 'confirmprotecttext' ) );
-                       $check = htmlspecialchars( wfMsg( 'confirmprotect' ) );
                        $moveonly = htmlspecialchars( wfMsg( 'protectmoveonly' ) );
                        $protcom = htmlspecialchars( wfMsg( 'protectcomment' ) );
                        $formaction = $this->mTitle->escapeLocalURL( 'action=protect' . $par );
@@ -1314,15 +1325,7 @@ class Article {
                </tr>
                <tr>
                        <td>&nbsp;</td>
-               </tr>
-               <tr>
-                       <td align='right'>
-                               <input type='checkbox' name='wpConfirmProtect' value='1' id='wpConfirmProtect' />
-                       </td>
-                       <td>
-                               <label for='wpConfirmProtect'>{$check}</label>
-                       </td>
-               </tr> " );
+               </tr>" );
                if($moveonly != '') {
                        $wgOut->AddHTML( "
                <tr>
@@ -1361,8 +1364,7 @@ class Article {
        function delete() {
                global $wgUser, $wgOut, $wgMessageCache, $wgRequest;
                $fname = 'Article::delete';
-               $confirm = $wgRequest->getBool( 'wpConfirm' ) &&
-                       $wgRequest->wasPosted() &&
+               $confirm = $wgRequest->wasPosted() &&
                        $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) );
                $reason = $wgRequest->getText( 'wpReason' );
 
@@ -1484,7 +1486,6 @@ class Article {
                $formaction = $this->mTitle->escapeLocalURL( 'action=delete' . $par );
 
                $confirm = htmlspecialchars( wfMsg( 'confirm' ) );
-               $check = htmlspecialchars( wfMsg( 'confirmcheck' ) );
                $delcom = htmlspecialchars( wfMsg( 'deletecomment' ) );
                $token = htmlspecialchars( $wgUser->editToken() );
 
@@ -1502,14 +1503,6 @@ class Article {
                <tr>
                        <td>&nbsp;</td>
                </tr>
-               <tr>
-                       <td align='right'>
-                               <input type='checkbox' name='wpConfirm' value='1' id='wpConfirm' />
-                       </td>
-                       <td>
-                               <label for='wpConfirm'>{$check}</label>
-                       </td>
-               </tr>
                <tr>
                        <td>&nbsp;</td>
                        <td>
@@ -1603,15 +1596,16 @@ class Article {
 
                $dbw->insertSelect( 'archive', array( 'page','revision', 'text' ),
                        array(
-                               'ar_namespace' => 'page_namespace',
-                               'ar_title' => 'page_title',
-                               'ar_text' => 'old_text',
-                               'ar_comment' => 'rev_comment',
-                               'ar_user' => 'rev_user',
-                               'ar_user_text' => 'rev_user_text',
-                               'ar_timestamp' => 'rev_timestamp',
+                               'ar_namespace'  => 'page_namespace',
+                               'ar_title'      => 'page_title',
+                               'ar_text'       => 'old_text',
+                               'ar_comment'    => 'rev_comment',
+                               'ar_user'       => 'rev_user',
+                               'ar_user_text'  => 'rev_user_text',
+                               'ar_timestamp'  => 'rev_timestamp',
                                'ar_minor_edit' => 'rev_minor_edit',
-                               'ar_flags' => 0,
+                               'ar_flags'      => 'old_flags',
+                               'ar_rev_id'     => 'rev_id',
                        ), array(
                                'page_namespace' => $ns,
                                'page_title' => $t,
@@ -1690,70 +1684,76 @@ class Article {
                $n = $this->mTitle->getNamespace();
 
                # Get the last editor, lock table exclusively
-               $s = $dbw->selectRow( array( 'page', 'revision' ),
-                       array( 'page_id','rev_user','rev_user_text','rev_comment' ),
-                       array( 'page_title' => $tt, 'page_namespace' => $n ),
-                       $fname, 'FOR UPDATE'
-               );
-               if( $s === false ) {
-                       # Something wrong
+               $dbw->begin();
+               $current = Revision::newFromTitle( $this->mTitle );
+               if( is_null( $current ) ) {
+                       # Something wrong... no page?
+                       $dbw->rollback();
                        $wgOut->addHTML( wfMsg( 'notanarticle' ) );
                        return;
                }
-               $ut = $dbw->strencode( $s->cur_user_text );
-               $uid = $s->rev_user;
-               $pid = $s->page_id;
 
                $from = str_replace( '_', ' ', $wgRequest->getVal( 'from' ) );
-               if( $from != $s->rev_user_text ) {
+               if( $from != $current->getUserText() ) {
                        $wgOut->setPageTitle(wfmsg('rollbackfailed'));
                        $wgOut->addWikiText( wfMsg( 'alreadyrolled',
                                htmlspecialchars( $this->mTitle->getPrefixedText()),
                                htmlspecialchars( $from ),
-                               htmlspecialchars( $s->rev_user_text ) ) );
-                       if($s->rev_comment != '') {
+                               htmlspecialchars( $current->getUserText() ) ) );
+                       if( $current->getComment() != '') {
                                $wgOut->addHTML(
-                                       wfMsg('editcomment',
-                                       htmlspecialchars( $s->rev_comment ) ) );
+                                       wfMsg( 'editcomment',
+                                       htmlspecialchars( $current->getComment() ) ) );
                        }
                        return;
                }
 
                # Get the last edit not by this guy
-               $s = $dbw->selectRow( 'old',
-                       array( 'old_text','old_user','old_user_text','old_timestamp','old_flags' ),
+               $user = IntVal( $current->getUser() );
+               $user_text = $dbw->addQuotes( $current->getUserText() );
+               $s = $dbw->selectRow( 'revision',
+                       array( 'rev_id', 'rev_timestamp' ),
                        array(
-                               'old_namespace' => $n,
-                               'old_title' => $tt,
-                               "old_user <> {$uid} OR old_user_text <> '{$ut}'"
-                       ), $fname, array( 'FOR UPDATE', 'USE INDEX' => 'name_title_timestamp' )
-               );
+                               'rev_page' => $current->getPage(),
+                               "rev_user <> {$user} OR rev_user_text <> {$user_text}"
+                       ), $fname,
+                       array(
+                               'USE INDEX' => 'page_timestamp',
+                               'ORDER BY'  => 'rev_timestamp DESC' )
+                       );
                if( $s === false ) {
                        # Something wrong
+                       $dbw->rollback();
                        $wgOut->setPageTitle(wfMsg('rollbackfailed'));
                        $wgOut->addHTML( wfMsg( 'cantrollback' ) );
                        return;
                }
-
+               
                if ( $bot ) {
                        # Mark all reverted edits as bot
                        $dbw->update( 'recentchanges',
                                array( /* SET */
                                        'rc_bot' => 1
                                ), array( /* WHERE */
-                                       'rc_user' => $uid,
-                                       "rc_timestamp > '{$s->old_timestamp}'",
+                                       'rc_cur_id'    => $current->getPage(),
+                                       'rc_user_text' => $current->getUserText(),
+                                       "rc_timestamp > '{$s->rev_timestamp}'",
                                ), $fname
                        );
                }
 
                # Save it!
-               $newcomment = wfMsg( 'revertpage', $s->old_user_text, $from );
+               $target = Revision::newFromId( $s->rev_id );
+               $newcomment = wfMsg( 'revertpage', $target->getUserText(), $from );
+               
                $wgOut->setPagetitle( wfMsg( 'actioncomplete' ) );
                $wgOut->setRobotpolicy( 'noindex,nofollow' );
                $wgOut->addHTML( '<h2>' . htmlspecialchars( $newcomment ) . "</h2>\n<hr />\n" );
-               $this->updateArticle( Revision::getRevisionText( $s ), $newcomment, 1, $this->mTitle->userIsWatching(), $bot );
+               
+               $this->updateArticle( $target->getText(), $newcomment, 1, $this->mTitle->userIsWatching(), $bot );
                Article::onArticleEdit( $this->mTitle );
+               
+               $dbw->commit();
                $wgOut->returnToMain( false );
        }
 
@@ -1935,50 +1935,29 @@ class Article {
 
        /**
         * Edit an article without doing all that other stuff
+        * The article must already exist; link tables etc
+        * are not updated, caches are not flushed.
         *
         * @param string $text text submitted
         * @param string $comment comment submitted
-        * @param integer $minor whereas it's a minor modification
+        * @param bool $minor whereas it's a minor modification
         */
        function quickEdit( $text, $comment = '', $minor = 0 ) {
-               global $wgUser;
                $fname = 'Article::quickEdit';
-
-               #wfDebugDieBacktrace( "$fname called." );
-
                wfProfileIn( $fname );
 
                $dbw =& wfGetDB( DB_MASTER );
-               $ns = $this->mTitle->getNamespace();
-               $dbkey = $this->mTitle->getDBkey();
-               $encDbKey = $dbw->strencode( $dbkey );
-               $timestamp = $dbw->timestamp();
-               # insert new text
-               $dbw->insert( 'text', array(
-                               'old_text' => $text,
-                               'old_flags' => "" ), $fname );
-               $text_id = $dbw->insertID();
-
-               # update page
-               $dbw->update( 'page', array(
-                       'page_is_new' => 0,
-                       'page_touched' => $timestamp,
-                       'page_is_redirect' => $this->isRedirect( $text ) ? 1 : 0,
-                       'page_latest' => $text_id ),
-                       array( 'page_namespace' => $ns, 'page_title' => $dbkey ), $fname );
-               # Retrieve page ID
-               $page_id = $dbw->selectField( 'page', 'page_id', array( 'page_namespace' => $ns, 'page_title' => $dbkey ), $fname );
-
-               # update revision
-               $dbw->insert( 'revision', array(
-                       'rev_id' => $text_id,
-                       'rev_page' => $page_id,
-                       'rev_comment' => $comment,
-                       'rev_user' => $wgUser->getID(),
-                       'rev_user_text' => $wgUser->getName(),
-                       'rev_timestamp' => $timestamp,
-                       'rev_minor_edit' => intval($minor) ),
-                       $fname );
+               $dbw->begin();
+               $revision = new Revision( array(
+                       'page'       => $this->getId(),
+                       'text'       => $text,
+                       'comment'    => $comment,
+                       'minor_edit' => $minor ? 1 : 0,
+                       ) );
+               $revisionId = $revision->insertOn( $dbw );
+               $this->updateRevisionOn( $dbw, $revisionId, $text );
+               $dbw->commit();
+               
                wfProfileOut( $fname );
        }
 
@@ -2166,32 +2145,5 @@ class Article {
        }
 }
 
-/**
- * Check whether an article is a stub
- *
- * @public
- * @param integer $articleID   ID of the article that is to be checked
- */
-function wfArticleIsStub( $articleID ) {
-       global $wgUser;
-       $fname = 'wfArticleIsStub';
-
-       wfDebugDieBacktrace( 'This function seems to be unused. Pending removal.' );
-
-       $threshold = $wgUser->getOption('stubthreshold') ;
-       if ( $threshold > 0 ) {
-               $dbr =& wfGetDB( DB_SLAVE );
-               $s = $dbr->selectRow( array('page', 'text'),
-                       array( 'LENGTH(old_text) AS len', 'page_namespace', 'page_is_redirect' ),
-                       array( 'page_id' => $articleID, "page.page_latest=text.old_id" ),
-                       $fname ) ;
-               if ( $s == false OR $s->page_is_redirect OR $s->page_namespace != NS_MAIN ) {
-                       return false;
-               }
-               $size = $s->len;
-               return ( $size < $threshold );
-       }
-       return false;
-}
 
 ?>