From b5ace113e7879a461c1886feeb4541eafbf6115f Mon Sep 17 00:00:00 2001 From: Alangi Derick Date: Mon, 3 Dec 2018 15:09:14 +0100 Subject: [PATCH] mail: Correct return value of sendPersonalised() method If email is not successfully sent, return Status (with appropriate status error) and also, if successfully sent, return Status::newGood(). Change-Id: I602e30641b88614087d9aff83cf8c93e32af7b81 --- includes/mail/EmailNotification.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/includes/mail/EmailNotification.php b/includes/mail/EmailNotification.php index fa5ebfc93c..739dbec035 100644 --- a/includes/mail/EmailNotification.php +++ b/includes/mail/EmailNotification.php @@ -444,11 +444,12 @@ class EmailNotification { /** * Does the per-user customizations to a notification e-mail (name, * timestamp in proper timezone, etc) and sends it out. - * Returns true if the mail was sent successfully. + * Returns Status if email was sent successfully or not (Status::newGood() + * or Status::newFatal() respectively). * * @param User $watchingUser * @param string $source - * @return bool + * @return Status * @private */ function sendPersonalised( $watchingUser, $source ) { -- 2.20.1