From 3779d16d59a6d777c941145d6ea067ad79fec214 Mon Sep 17 00:00:00 2001
From: umherirrender <umherirrender_de.wp@web.de>
Date: Sat, 9 Feb 2013 23:55:46 +0100
Subject: [PATCH] remove not needed return and break

break after throw is not executed

return; at end of function is not needed

Change-Id: I7c1c1799f78da11b7607a753d4f215c4547f0428
---
 includes/Export.php           | 2 --
 includes/db/DatabaseMssql.php | 1 -
 includes/media/XMP.php        | 7 -------
 3 files changed, 10 deletions(-)

diff --git a/includes/Export.php b/includes/Export.php
index eea1988052..666f653b36 100644
--- a/includes/Export.php
+++ b/includes/Export.php
@@ -940,7 +940,6 @@ class DumpOutput {
 	 * @param $newname mixed File name. May be a string or an array with one element
 	 */
 	function closeRenameAndReopen( $newname ) {
-		return;
 	}
 
 	/**
@@ -951,7 +950,6 @@ class DumpOutput {
 	 * @param $open bool If true, a new file with the old filename will be opened again for writing (default: false)
 	 */
 	function closeAndRename( $newname, $open = false ) {
-		return;
 	}
 
 	/**
diff --git a/includes/db/DatabaseMssql.php b/includes/db/DatabaseMssql.php
index fcbbec7127..6ce545fba0 100644
--- a/includes/db/DatabaseMssql.php
+++ b/includes/db/DatabaseMssql.php
@@ -1132,6 +1132,5 @@ class MssqlResult {
 
 	public function free() {
 		unset( $this->mRows );
-		return;
 	}
 }
diff --git a/includes/media/XMP.php b/includes/media/XMP.php
index e4833fc5cd..d9e86c9e21 100644
--- a/includes/media/XMP.php
+++ b/includes/media/XMP.php
@@ -276,10 +276,7 @@ class XMPReader {
 						default:
 							//this should be impossible to get to
 							throw new MWException( "Invalid BOM" );
-							break;
-
 					}
-
 				} else {
 					// standard specifically says, if no bom assume utf-8
 					$this->charset = 'UTF-8';
@@ -421,13 +418,10 @@ class XMPReader {
 	* @param $elm String Namespace of element followed by a space and then tag name of element.
 	*/
 	private function endElementModeIgnore ( $elm ) {
-
 		if ( $this->curItem[0] === $elm ) {
 			array_shift( $this->curItem );
 			array_shift( $this->mode );
 		}
-		return;
-
 	}
 
 	/**
@@ -1103,7 +1097,6 @@ class XMPReader {
 				break;
 			default:
 				throw new MWException( 'StartElement in unknown mode: ' . $this->mode[0] );
-				break;
 		}
 	}
 
-- 
2.20.1