From: addshore <addshorewiki@gmail.com>
Date: Mon, 18 Apr 2016 10:06:09 +0000 (+0100)
Subject: Fix RecentChange::parseParams @return docs
X-Git-Tag: 1.31.0-rc.0~7264^2
X-Git-Url: https://git.cyclocoop.org/admin/%7B%24plugin.url%7Cescape%7D?a=commitdiff_plain;h=e2572a0b2f4c5488c69ba4d7a8d3c1e04f272636;p=lhc%2Fweb%2Fwiklou.git

Fix RecentChange::parseParams @return docs

Per the docs of unserialize:
In case the passed string is not unserializeable, false is returned.

Also as we can not guarentee an array was serialized in
rc_params we cant say it will always be an array...
Quite often this is just an empty string which will
result in: "s:0:"";" (not an array)....

Change-Id: Ib22f9f7468a23ce3d4f145d47f8514d08be6c957
---

diff --git a/includes/changes/RecentChange.php b/includes/changes/RecentChange.php
index 2508304ce1..3fe5f2f75b 100644
--- a/includes/changes/RecentChange.php
+++ b/includes/changes/RecentChange.php
@@ -973,7 +973,7 @@ class RecentChange {
 	 *
 	 * @since 1.26
 	 *
-	 * @return array|null
+	 * @return mixed|bool false on failed unserialization
 	 */
 	public function parseParams() {
 		$rcParams = $this->getAttribute( 'rc_params' );