From 9c78fa03997fd41905092b29ac7959b5237f9921 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Wed, 3 Oct 2018 15:39:55 -0700 Subject: [PATCH] rdbms: clarfiy some comments about commitMasterChanges() methods Change-Id: I2c9f3cb9b4dcd16f561e55d119849b526e9d402b --- includes/libs/rdbms/lbfactory/ILBFactory.php | 2 +- includes/libs/rdbms/loadbalancer/ILoadBalancer.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/libs/rdbms/lbfactory/ILBFactory.php b/includes/libs/rdbms/lbfactory/ILBFactory.php index 8e35456904..57f60cafbb 100644 --- a/includes/libs/rdbms/lbfactory/ILBFactory.php +++ b/includes/libs/rdbms/lbfactory/ILBFactory.php @@ -200,7 +200,7 @@ interface ILBFactory { public function beginMasterChanges( $fname = __METHOD__ ); /** - * Commit changes on all master connections + * Commit changes and clear view snapshots on all master connections * @param string $fname Caller name * @param array $options Options map: * - maxWriteDuration: abort if more than this much time was spent in write queries diff --git a/includes/libs/rdbms/loadbalancer/ILoadBalancer.php b/includes/libs/rdbms/loadbalancer/ILoadBalancer.php index 9f7d0502ae..78815f201a 100644 --- a/includes/libs/rdbms/loadbalancer/ILoadBalancer.php +++ b/includes/libs/rdbms/loadbalancer/ILoadBalancer.php @@ -445,7 +445,7 @@ interface ILoadBalancer { public function beginMasterChanges( $fname = __METHOD__ ); /** - * Issue COMMIT on all master connections where writes where done + * Issue COMMIT on all open master connections to flush changes and view snapshots * @param string $fname Caller name * @throws DBExpectedError */ -- 2.20.1