From 38129123f24174d701af1c013f60cf9543687e10 Mon Sep 17 00:00:00 2001
From: Kunal Mehta <legoktm@member.fsf.org>
Date: Mon, 7 May 2018 01:22:40 -0700
Subject: [PATCH] tests: Add some more @covers tags

Change-Id: I84b66879773d97593152b683ff69d034ed67aa3d
---
 tests/phpunit/includes/MovePageTest.php                        | 2 ++
 tests/phpunit/includes/OutputPageTest.php                      | 1 +
 tests/phpunit/includes/SampleTest.php                          | 3 +++
 .../EmailNotificationSecondaryAuthenticationProviderTest.php   | 3 +++
 .../includes/preferences/DefaultPreferencesFactoryTest.php     | 2 ++
 5 files changed, 11 insertions(+)

diff --git a/tests/phpunit/includes/MovePageTest.php b/tests/phpunit/includes/MovePageTest.php
index 2bde97b66b..583b75184d 100644
--- a/tests/phpunit/includes/MovePageTest.php
+++ b/tests/phpunit/includes/MovePageTest.php
@@ -43,6 +43,8 @@ class MovePageTest extends MediaWikiTestCase {
 	/**
 	 * Integration test to catch regressions like T74870. Taken and modified
 	 * from SemanticMediaWiki
+	 *
+	 * @covers Title::moveTo
 	 */
 	public function testTitleMoveCompleteIntegrationTest() {
 		$oldTitle = Title::newFromText( 'Help:Some title' );
diff --git a/tests/phpunit/includes/OutputPageTest.php b/tests/phpunit/includes/OutputPageTest.php
index a5a7364488..91655eaeee 100644
--- a/tests/phpunit/includes/OutputPageTest.php
+++ b/tests/phpunit/includes/OutputPageTest.php
@@ -151,6 +151,7 @@ class OutputPageTest extends MediaWikiTestCase {
 
 	/**
 	 * @dataProvider provideCdnCacheEpoch
+	 * @covers OutputPage::getCdnCacheEpoch
 	 */
 	public function testCdnCacheEpoch( $params ) {
 		$out = TestingAccessWrapper::newFromObject( $this->newInstance() );
diff --git a/tests/phpunit/includes/SampleTest.php b/tests/phpunit/includes/SampleTest.php
index 3d74ae3efc..474746626d 100644
--- a/tests/phpunit/includes/SampleTest.php
+++ b/tests/phpunit/includes/SampleTest.php
@@ -1,5 +1,8 @@
 <?php
 
+/**
+ * @coversNothing Just a sample
+ */
 class SampleTest extends MediaWikiLangTestCase {
 
 	/**
diff --git a/tests/phpunit/includes/auth/EmailNotificationSecondaryAuthenticationProviderTest.php b/tests/phpunit/includes/auth/EmailNotificationSecondaryAuthenticationProviderTest.php
index 1a7ed12da7..ff22def7f8 100644
--- a/tests/phpunit/includes/auth/EmailNotificationSecondaryAuthenticationProviderTest.php
+++ b/tests/phpunit/includes/auth/EmailNotificationSecondaryAuthenticationProviderTest.php
@@ -5,6 +5,9 @@ namespace MediaWiki\Auth;
 use Psr\Log\LoggerInterface;
 use Wikimedia\TestingAccessWrapper;
 
+/**
+ * @covers \MediaWiki\Auth\EmailNotificationSecondaryAuthenticationProvider
+ */
 class EmailNotificationSecondaryAuthenticationProviderTest extends \PHPUnit\Framework\TestCase {
 	public function testConstructor() {
 		$config = new \HashConfig( [
diff --git a/tests/phpunit/includes/preferences/DefaultPreferencesFactoryTest.php b/tests/phpunit/includes/preferences/DefaultPreferencesFactoryTest.php
index c10152344b..f45bb935f0 100644
--- a/tests/phpunit/includes/preferences/DefaultPreferencesFactoryTest.php
+++ b/tests/phpunit/includes/preferences/DefaultPreferencesFactoryTest.php
@@ -170,6 +170,8 @@ class DefaultPreferencesFactoryTest extends MediaWikiTestCase {
 
 	/**
 	 * The rclimit preference should accept non-integer input and filter it to become an integer.
+	 *
+	 * @covers \MediaWiki\Preferences\DefaultPreferencesFactory::saveFormData
 	 */
 	public function testIntvalFilter() {
 		// Test a string with leading zeros (i.e. not octal) and spaces.
-- 
2.20.1