From: Timo Tijhof Date: Sat, 15 Sep 2018 21:13:37 +0000 (+0100) Subject: resourceloader: Remove unused makeCustomLoaderScript() method X-Git-Tag: 1.34.0-rc.0~4077^2 X-Git-Url: https://git.cyclocoop.org/admin/%7B%24admin_url%7Dmembres/%7B%7B%20url_for%28%27edit_vote%27%2C%20voteid=vote.id%29%20%7D%7D?a=commitdiff_plain;h=f31e866653d4a491868a01b734883cd5d05ed71c;p=lhc%2Fweb%2Fwiklou.git resourceloader: Remove unused makeCustomLoaderScript() method Follows-up a0809dfa5 (2015) which removed the feature for which this would be used. No callers in MediaWiki core, Wikimedia Git, or elsewhere indexed by Codesearch. Bug: T65240 Change-Id: I56af8df3d072cd76a38595254812af6be268b134 --- diff --git a/includes/resourceloader/ResourceLoader.php b/includes/resourceloader/ResourceLoader.php index 9764549e84..0d9eade991 100644 --- a/includes/resourceloader/ResourceLoader.php +++ b/includes/resourceloader/ResourceLoader.php @@ -1317,31 +1317,6 @@ MESSAGE; ); } - /** - * Returns JS code which calls the script given by $script. The script will - * be called with local variables name, version, dependencies and group, - * which will have values corresponding to $name, $version, $dependencies - * and $group as supplied. - * - * @param string $name Module name - * @param string $version Module version hash - * @param array $dependencies List of module names on which this module depends - * @param string $group Group which the module is in. - * @param string $source Source of the module, or 'local' if not foreign. - * @param string $script JavaScript code - * @return string JavaScript code - */ - public static function makeCustomLoaderScript( $name, $version, $dependencies, - $group, $source, $script - ) { - $script = str_replace( "\n", "\n\t", trim( $script ) ); - return Xml::encodeJsCall( - "( function ( name, version, dependencies, group, source ) {\n\t$script\n} )", - [ $name, $version, $dependencies, $group, $source ], - self::inDebugMode() - ); - } - private static function isEmptyObject( stdClass $obj ) { foreach ( $obj as $key => $value ) { return false;