From: Moriel Schottlender Date: Mon, 26 Mar 2018 20:00:25 +0000 (+0300) Subject: RCFilters: Bidi isolate tag names and descriptions X-Git-Tag: 1.31.0-rc.0~262^2 X-Git-Url: https://git.cyclocoop.org/admin/%7B%24admin_url%7Dmembres/import.php?a=commitdiff_plain;h=057fa7a39b06626443526070dc6b670d2b310300;p=lhc%2Fweb%2Fwiklou.git RCFilters: Bidi isolate tag names and descriptions Tags can be untranslated in wikis; most often remain in English even in an RTL wiki. Since that text is inserted by external input that can be outside normal translation, we should expect any directional string in there, and these should be bidi isolated. Bug: T190718 Change-Id: Iebc3176c5d0f5097badd0dde565a5a6cbfa3a3c2 --- diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ItemMenuOptionWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ItemMenuOptionWidget.js index 15085105f0..8c349e5686 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ItemMenuOptionWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ItemMenuOptionWidget.js @@ -42,13 +42,13 @@ $label.append( $( '
' ) .addClass( 'mw-rcfilters-ui-itemMenuOptionWidget-label-title' ) - .append( this.$label ) + .append( $( '' ).append( this.$label ) ) ); if ( this.itemModel.getDescription() ) { $label.append( $( '
' ) .addClass( 'mw-rcfilters-ui-itemMenuOptionWidget-label-desc' ) - .text( this.itemModel.getDescription() ) + .append( $( '' ).text( this.itemModel.getDescription() ) ) ); }