From 2d94629f3cd65d8cfe4220b672998d9127d726a6 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 18 Apr 2018 02:59:36 +0100 Subject: [PATCH] installer: Open skin screenshot in new window By default the plain links hijack the current window, thus causing the user to lose their current changes to the installer form. It may also cause confusion as to how to get back. Absence a modal way to view the image, at least it should default to opening the image in a new tab. Change-Id: I4a25f1f51e04a33f1f359f12af25b8e1db5fbd20 (cherry picked from commit d37ee8e91e0b08a937e3721bee406e16ab84c0de) --- includes/installer/WebInstallerOptions.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/installer/WebInstallerOptions.php b/includes/installer/WebInstallerOptions.php index c62eb6572f..2027c978af 100644 --- a/includes/installer/WebInstallerOptions.php +++ b/includes/installer/WebInstallerOptions.php @@ -331,7 +331,7 @@ class WebInstallerOptions extends WebInstallerPage { foreach ( $screenshots as $shot ) { $links[] = Html::element( 'a', - [ 'href' => $shot ], + [ 'href' => $shot, 'target' => '_blank' ], $wgLang->formatNum( $counter++ ) ); } @@ -341,7 +341,7 @@ class WebInstallerOptions extends WebInstallerPage { } else { $link = Html::element( 'a', - [ 'href' => $screenshots[0] ], + [ 'href' => $screenshots[0], 'target' => '_blank' ], wfMessage( 'config-screenshot' )->text() ); return wfMessage( 'config-skins-screenshot', $name )->rawParams( $link )->escaped(); -- 2.20.1