lhc/web/wiklou.git
14 years agoAdd yet another parameter for Block construction, so this doesn't show runJobs.php...
Platonides [Sat, 17 Apr 2010 21:06:21 +0000 (21:06 +0000)]
Add yet another parameter for Block construction, so this doesn't show runJobs.php blocking anyone when run from the job queue :)
Follow up r65184.

14 years agoFollow up r64982. Autoblocks aren't automatically set just by storing ipb_enable_auto...
Platonides [Sat, 17 Apr 2010 20:59:05 +0000 (20:59 +0000)]
Follow up r64982. Autoblocks aren't automatically set just by storing ipb_enable_autoblock, we need to look for them.
So do this properly and use Block class to insert the block.

14 years agoStylize Api upto date
Sam Reed [Sat, 17 Apr 2010 20:58:04 +0000 (20:58 +0000)]
Stylize Api upto date

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Sat, 17 Apr 2010 20:47:45 +0000 (20:47 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-17 20:20:00 UTC)

14 years agoFix
Sam Reed [Sat, 17 Apr 2010 20:03:10 +0000 (20:03 +0000)]
Fix

<siebrand> PHP Warning:  Missing argument 4 for UploadFromUrl::initialize(), called in /www/w/includes/upload/UploadFromUrl.php on line 99 and defined in /www/w/includes/upload/UploadFromUrl.php on line 38

14 years agoeol ws cleanup
Mark A. Hershberger [Sat, 17 Apr 2010 17:09:11 +0000 (17:09 +0000)]
eol ws cleanup

14 years agore: r65152
Mark A. Hershberger [Sat, 17 Apr 2010 16:49:20 +0000 (16:49 +0000)]
re: r65152
* Make Job::insert() return true on success
* Change from Status object to array for API result on URL upload.

14 years agore: r65152 fix translatewiki problems
Mark A. Hershberger [Sat, 17 Apr 2010 16:36:48 +0000 (16:36 +0000)]
re: r65152 fix translatewiki problems
* Recover lost $permErrorsUpload in uploadBase::verifyPermissions
* Use Http::isValidURI() to replace UploadFromUrl::isvalidurl()

14 years agoTweaks for messages added in r65152.
Siebrand Mazeland [Sat, 17 Apr 2010 15:44:00 +0000 (15:44 +0000)]
Tweaks for messages added in r65152.

14 years agoBug 23190#c7 Mark tex text as class="tex".
Platonides [Sat, 17 Apr 2010 15:31:58 +0000 (15:31 +0000)]
Bug 23190#c7 Mark tex text as class="tex".

14 years agoLocalization update for he, updating messages.inc, and rebuilding en.
Rotem Liss [Sat, 17 Apr 2010 08:25:25 +0000 (08:25 +0000)]
Localization update for he, updating messages.inc, and rebuilding en.

14 years ago* New UploadFromUrlJob class to handle Upload-by-Copy
Mark A. Hershberger [Sat, 17 Apr 2010 02:43:13 +0000 (02:43 +0000)]
* New UploadFromUrlJob class to handle Upload-by-Copy
* Define variable for ApiUserrights.php that wasn't defined before.
* Add convertVerifyErrorToStatus and getVerificationErrorCode to
  UploadBase to translate error consts since UploadFromUrl will
  need a message to display to end-users.
* refactor mime-checking out of UploadBase::verifyFile into
  UploadBase::verifyMimeType
* Make UploadBase::verifyFile always return arrays for errors
* Use HttpFunctions instead of custom curl handler for async downloading
* TODO: Need a way to feed errors back to the requestor
* TODO: Need to add watchlist param handling and warnings checks.

14 years agooverride isMetadataValid() so that we don't regenerate GIF metadata every time
Ilmari Karonen [Sat, 17 Apr 2010 01:37:32 +0000 (01:37 +0000)]
override isMetadataValid() so that we don't regenerate GIF metadata every time

14 years agoMediaWiki messages show content on view and edit even if they don't actually exist...
Platonides [Fri, 16 Apr 2010 22:29:11 +0000 (22:29 +0000)]
MediaWiki messages show content on view and edit even if they don't actually exist on db, so show edit instead of create, per thread.gmane.org/gmane.org.wikimedia.mediawiki/33792

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Fri, 16 Apr 2010 20:41:14 +0000 (20:41 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-16 20:20:00 UTC)

14 years ago* part of bug 23119: removed WikiError stuff for Special:Userrights, also updated...
Alexandre Emsenhuber [Fri, 16 Apr 2010 15:56:48 +0000 (15:56 +0000)]
* part of bug 23119: removed WikiError stuff for Special:Userrights, also updated CentralAuth extension
* fixed E_NOTICE in Special:GlobalGroupMembership when the user cannot change global permissions

14 years agoUpdate comments: file stuff no longer uses WikiError
Alexandre Emsenhuber [Fri, 16 Apr 2010 15:20:12 +0000 (15:20 +0000)]
Update comments: file stuff no longer uses WikiError

14 years agoFix hooks.txt SpecialSearchNogomatch $title to &$title
Sam Reed [Fri, 16 Apr 2010 10:19:50 +0000 (10:19 +0000)]
Fix hooks.txt SpecialSearchNogomatch $title to &$title

* (bug 23206) Add Special::Search hook for detecting successful "Go"

Not implemented completely as per patch, $term removed, seems a bit useless/redundant (and doesn't exist for Nomatch)

14 years agoChange Czech talk namespaces names. Patch by Danny B
Roan Kattouw [Fri, 16 Apr 2010 09:33:27 +0000 (09:33 +0000)]
Change Czech talk namespaces names. Patch by Danny B

14 years agoFollowup to r65104, PG updater/table def
OverlordQ [Fri, 16 Apr 2010 02:35:37 +0000 (02:35 +0000)]
Followup to r65104, PG updater/table def

14 years ago* (bug 14473) Add iwlinks table to track inline interwiki link usage
Brion Vibber [Fri, 16 Apr 2010 01:40:05 +0000 (01:40 +0000)]
* (bug 14473) Add iwlinks table to track inline interwiki link usage

Like langlinks, this stores the interwiki prefix (as iwl_prefix) and full page title (as iwl_title), attached to the page doing the liking (as iwl_from -> page_id).
Unlike langlinks, there can be multiple entries stored per interwiki prefix.

Updater to add the table confirmed on MySQL, untested on SQLite but should work.
Someone may still need to add and test a PostgreSQL updater.

Refactored makeWhereFrom2d() out of LinkBatch to Database so it could be re-used for the similar mapping for the interwiki links, which need a string prefix rather than an int namespace key.
Also cleaned it up internally to reuse existing code for building where clauses from arrays. (Tim & Domas -- if the previous more verbose code was there to reduce function call and array processing overhead on very large link lists, feel free to unroll it again if the difference is measurable. Just swap the var names around from the old LinkBatch code and escape the base key value if it's not an integer, it'll be functionally equivalent.)

14 years agoRELEASE-NOTES for r65101
Conrad Irwin [Thu, 15 Apr 2010 22:43:29 +0000 (22:43 +0000)]
RELEASE-NOTES for r65101

14 years agoPut a 235 byte limit on usernames to allow /thelongskinname.css to work (bug 23080)
Conrad Irwin [Thu, 15 Apr 2010 22:41:49 +0000 (22:41 +0000)]
Put a 235 byte limit on usernames to allow /thelongskinname.css to work (bug 23080)

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Thu, 15 Apr 2010 21:03:42 +0000 (21:03 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-15 20:30:00 UTC)

14 years agoUpdate indentation/formatting and add braces where missing in if() and foreach()
Siebrand Mazeland [Thu, 15 Apr 2010 18:36:12 +0000 (18:36 +0000)]
Update indentation/formatting and add braces where missing in if() and foreach()

14 years agoRemove the 'editwidth' preference and related code.
Siebrand Mazeland [Thu, 15 Apr 2010 18:11:24 +0000 (18:11 +0000)]
Remove the 'editwidth' preference and related code.

I was not able to find any scenario that changed editor behavior anymore in monobook, modern, vector, classic or chick skin.

14 years agoCompliment to r65046 - Removing duplicate css from Vector's css file
Adam Miller [Thu, 15 Apr 2010 13:26:07 +0000 (13:26 +0000)]
Compliment to r65046 - Removing duplicate css from Vector's css file

14 years agoRemove jobqueue length from the user interface
Niklas Laxström [Thu, 15 Apr 2010 12:47:05 +0000 (12:47 +0000)]
Remove jobqueue length from the user interface

It causes more confusion than it is worth:
* The figures are essentially random, so it does not help to detect problems
* There shouldn't be any problems with default configuration anyway
* The number is still accessible by other means

14 years agoSome cleanups
Niklas Laxström [Thu, 15 Apr 2010 12:41:19 +0000 (12:41 +0000)]
Some cleanups

14 years agoSpecial:Random now carries over query string parameters
Roan Kattouw [Thu, 15 Apr 2010 11:54:16 +0000 (11:54 +0000)]
Special:Random now carries over query string parameters

14 years agoDocumentation fix for r65049.
Bryan Tong Minh [Thu, 15 Apr 2010 10:16:45 +0000 (10:16 +0000)]
Documentation fix for r65049.

14 years ago(bug 17941) $wgMaxUploadSize is now honored by all upload sources
Bryan Tong Minh [Thu, 15 Apr 2010 09:28:33 +0000 (09:28 +0000)]
(bug 17941) $wgMaxUploadSize is now honored by all upload sources

14 years agoRELEASE-NOTES for r65043.
Bryan Tong Minh [Thu, 15 Apr 2010 08:46:19 +0000 (08:46 +0000)]
RELEASE-NOTES for r65043.

14 years agoRefactored UploadFromUrl to use HttpFunctions.
Bryan Tong Minh [Thu, 15 Apr 2010 08:44:25 +0000 (08:44 +0000)]
Refactored UploadFromUrl to use HttpFunctions.
Errors while fetching the file are now properly handled and also displayed in a reasonable way to the user (bug 22015).

14 years agoFrom r64866, more consistent behaviour of hidden field names. May affect r65029.
Happy-melon [Wed, 14 Apr 2010 21:42:37 +0000 (21:42 +0000)]
From r64866, more consistent behaviour of hidden field names.  May affect r65029.

14 years agoReplace the new lines in plain math with spaces.
Platonides [Wed, 14 Apr 2010 21:22:38 +0000 (21:22 +0000)]
Replace the new lines in plain math with spaces.
This avoids interactions with the parser taking those new lines into account for the wikitext.
Fixes bug 22818 and bug 23190.

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Wed, 14 Apr 2010 20:03:13 +0000 (20:03 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-14 19:30:00 UTC)

14 years ago* (bug 21456) "Bad title" error when showing non-local interwiki pages no longer...
Alexandre Emsenhuber [Wed, 14 Apr 2010 19:27:25 +0000 (19:27 +0000)]
* (bug 21456) "Bad title" error when showing non-local interwiki pages no longer displays incorrect tabs

14 years agoFollow-up to r65013: Preserve username when clicking navigation links.
Bryan Tong Minh [Wed, 14 Apr 2010 16:15:14 +0000 (16:15 +0000)]
Follow-up to r65013: Preserve username when clicking navigation links.

14 years agoFollow-up to r65027: Prefix all hidden fields with wp. This was not necessary since...
Bryan Tong Minh [Wed, 14 Apr 2010 14:47:50 +0000 (14:47 +0000)]
Follow-up to r65027: Prefix all hidden fields with wp. This was not necessary since HTMLForm.php r64866, which needs reverting or fixing.

14 years agoFix regression in unwatch links sent out by enotif. {{FULLPAGENAMEE}} happens to...
Chad Horohoe [Wed, 14 Apr 2010 14:00:53 +0000 (14:00 +0000)]
Fix regression in unwatch links sent out by enotif. {{FULLPAGENAMEE}} happens to be "RunJobs.php," so hack around it by adding another $NAMEDVAR to enotif_body

14 years ago(bug 23176) Fixed regression: "upload new version" link should not trigger a file...
Bryan Tong Minh [Wed, 14 Apr 2010 13:53:20 +0000 (13:53 +0000)]
(bug 23176) Fixed regression: "upload new version" link should not trigger a file-exists warning

Also fixed a mislabeled form field.

14 years agoFollowup to r64962: Fixed watchlist parameter in API. User options watchdeletions...
Bryan Tong Minh [Wed, 14 Apr 2010 12:17:39 +0000 (12:17 +0000)]
Followup to r64962: Fixed watchlist parameter in API. User options watchdeletions and watchmoves can now by overridden. Unwatching while editting is now possible.

14 years agoRemove space in <div id="content" > to unbreak certain screenscraping clients. (Yes...
Roan Kattouw [Wed, 14 Apr 2010 10:04:33 +0000 (10:04 +0000)]
Remove space in <div id="content" > to unbreak certain screenscraping clients. (Yes, their breaking on this is ridiculous.)

14 years agoSpecial:Listfiles now supports a username parameter. This is indexed using the img_us...
Bryan Tong Minh [Wed, 14 Apr 2010 09:03:28 +0000 (09:03 +0000)]
Special:Listfiles now supports a username parameter. This is indexed using the img_user_text_timestamp index.

14 years ago* EOL ws clean on ApiBase.php
Mark A. Hershberger [Wed, 14 Apr 2010 04:57:27 +0000 (04:57 +0000)]
* EOL ws clean on ApiBase.php
* Use an actual value for ApiUpload.php
* Commit some code I must've missed for r64852

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Tue, 13 Apr 2010 19:19:15 +0000 (19:19 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-13 18:40:00 UTC)

14 years agoFixed some doxygen warnings and documented a bit
Alexandre Emsenhuber [Tue, 13 Apr 2010 18:06:54 +0000 (18:06 +0000)]
Fixed some doxygen warnings and documented a bit

14 years agoDocumented hooks added in r64903
Alexandre Emsenhuber [Tue, 13 Apr 2010 17:33:22 +0000 (17:33 +0000)]
Documented hooks added in r64903

14 years agoStop using obsolete <big>[1]. Also fixes bug 19858 requesting to remove it in 'mainpa...
Siebrand Mazeland [Mon, 12 Apr 2010 21:32:11 +0000 (21:32 +0000)]
Stop using obsolete <big>[1]. Also fixes bug 19858 requesting to remove it in 'mainpagetext'.

[1] http://www.w3.org/TR/html5/obsolete.html

14 years agoFix encoding
Raimond Spekking [Mon, 12 Apr 2010 21:28:52 +0000 (21:28 +0000)]
Fix encoding

14 years ago(bug 23156) Commafy and search normalization update for Belarusian (Taraškievica...
Siebrand Mazeland [Mon, 12 Apr 2010 21:12:34 +0000 (21:12 +0000)]
(bug 23156) Commafy and search normalization update for Belarusian (Taraškievica). Contributed by Jaska Zedlik.

14 years agoFix documentation introduced in r64403
Alexandre Emsenhuber [Mon, 12 Apr 2010 20:38:30 +0000 (20:38 +0000)]
Fix documentation introduced in r64403

14 years agore r64962 clean up the logic for watchlist a little
Mark A. Hershberger [Mon, 12 Apr 2010 20:15:04 +0000 (20:15 +0000)]
re r64962 clean up the logic for watchlist a little

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Mon, 12 Apr 2010 19:48:26 +0000 (19:48 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-12 19:15:00 UTC)

14 years agoUpdate the Chinese conversion tables.
Philip Tzou [Mon, 12 Apr 2010 18:04:29 +0000 (18:04 +0000)]
Update the Chinese conversion tables.

14 years agoIf an article Special:Foo exists (eg. because of a new alias), cleanupTitles moved...
Platonides [Mon, 12 Apr 2010 17:55:44 +0000 (17:55 +0000)]
If an article Special:Foo exists (eg. because of a new alias), cleanupTitles moved it to Foo on namespace -1.
Now it is moved to Broken/Special:Foo. Pages in negative namespaces (broken from past cleanupTitles) are moved back to ns 0.
See bug 23147#c4.

14 years agoRELEASE-NOTES for bug 23167 r64957 and r94958
Sam Reed [Mon, 12 Apr 2010 15:56:38 +0000 (15:56 +0000)]
RELEASE-NOTES for bug 23167 r64957 and r94958

14 years agore r64291 and r64852 use ApiBase::setWatch instead of wgUser->*Watch to set watches...
Mark A. Hershberger [Mon, 12 Apr 2010 15:44:33 +0000 (15:44 +0000)]
re r64291 and r64852 use ApiBase::setWatch instead of wgUser->*Watch to set watches so that all api watch changes act the same.

14 years agoRevert r64955
Sam Reed [Mon, 12 Apr 2010 10:44:45 +0000 (10:44 +0000)]
Revert r64955

Again partial fix to bug 23167

Bugfix watch on creation (edit and upload), in current form, setting unwatch, or nochange would follow watchcreation, which wasn't requested

14 years ago(bug 23167) Check the watch checkbox by default if the watchcreations preference...
Bryan Tong Minh [Mon, 12 Apr 2010 10:40:03 +0000 (10:40 +0000)]
(bug 23167) Check the watch checkbox by default if the watchcreations preference is set

14 years agoPartial fix to bug 23167
Sam Reed [Mon, 12 Apr 2010 10:23:09 +0000 (10:23 +0000)]
Partial fix to bug 23167

Api doesn't watch new file on upload (and didn't previously). Now watches on creation

14 years ago(bug 22970) Made upload.js compatible with FF<3.5.
Bryan Tong Minh [Sun, 11 Apr 2010 21:01:56 +0000 (21:01 +0000)]
(bug 22970) Made upload.js compatible with FF<3.5.

14 years agoFollow up r64936. Even better, provide the bug number and imagemagick doc page.
Platonides [Sun, 11 Apr 2010 20:47:41 +0000 (20:47 +0000)]
Follow up r64936. Even better, provide the bug number and imagemagick doc page.

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Sun, 11 Apr 2010 19:24:28 +0000 (19:24 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-11 18:45:00 UTC)

14 years agoFix param names mismatch in code/doc from r64852 and r64397
Alexandre Emsenhuber [Sun, 11 Apr 2010 19:10:15 +0000 (19:10 +0000)]
Fix param names mismatch in code/doc from r64852 and r64397

14 years agoDefine our own posix_isatty if posix extension is not installed.
Platonides [Sun, 11 Apr 2010 15:44:28 +0000 (15:44 +0000)]
Define our own posix_isatty if posix extension is not installed.
Removes the extension dependency on non-windows for parserTests.
Currently used on install-utils.inc readconsole(), eval.php and parserTests.inc

Maintenance scripts receive it via commandLine.inc -> Maintenance.php .. doMaintenance.php -> install-utils.inc

14 years ago$_SERVER['REQUEST_URI'] is not available using IIS with rewrite rules, so use HTTP_X_...
Bryan Tong Minh [Sun, 11 Apr 2010 15:38:58 +0000 (15:38 +0000)]
$_SERVER['REQUEST_URI'] is not available using IIS with rewrite rules, so use HTTP_X_ORIGINAL_URL as alternative.

14 years agoFollow up r64935: Add whitespace and clarify comment a bit more.
Bryan Tong Minh [Sun, 11 Apr 2010 13:59:01 +0000 (13:59 +0000)]
Follow up r64935: Add whitespace and clarify comment a bit more.

14 years agoFollow up r64932: Add comment on why % is escaped
Bryan Tong Minh [Sun, 11 Apr 2010 13:54:22 +0000 (13:54 +0000)]
Follow up r64932: Add comment on why % is escaped

14 years agoFollow up r64876. Try to fix pagetitle-view-mainpage.
Philip Tzou [Sun, 11 Apr 2010 13:04:58 +0000 (13:04 +0000)]
Follow up r64876. Try to fix pagetitle-view-mainpage.

14 years ago(bug 23148) Escape % in ImageMagick comments. Patch by Derk-Jan Hartman
Roan Kattouw [Sun, 11 Apr 2010 12:38:28 +0000 (12:38 +0000)]
(bug 23148) Escape % in ImageMagick comments. Patch by Derk-Jan Hartman

14 years agoLocalization update for he, and whitespace fix in en.
Rotem Liss [Sun, 11 Apr 2010 12:23:29 +0000 (12:23 +0000)]
Localization update for he, and whitespace fix in en.

14 years agoi18n update
Meno25 [Sun, 11 Apr 2010 11:40:57 +0000 (11:40 +0000)]
i18n update

14 years agoFixes for r64903:
Alexandre Emsenhuber [Sun, 11 Apr 2010 07:57:12 +0000 (07:57 +0000)]
Fixes for r64903:
* changed execute() signature to be compatible with SpecialPage::execute()
* changed $to to $target since the former is not defined at this point, and corrected message name
* removed trailing spaces

14 years agoFix so that toolbox entries correctly show on user subpages
OverlordQ [Sun, 11 Apr 2010 05:19:44 +0000 (05:19 +0000)]
Fix so that toolbox entries correctly show on user subpages

14 years agoFix for issue noted on CR r64876: fatal error on CSS/JS subpage display
Tim Starling [Sat, 10 Apr 2010 23:52:07 +0000 (23:52 +0000)]
Fix for issue noted on CR r64876: fatal error on CSS/JS subpage display

14 years agofix capitalization of "wpSourceTypeurl" to match the actual id generated in SpecialUp...
Ilmari Karonen [Sat, 10 Apr 2010 23:50:37 +0000 (23:50 +0000)]
fix capitalization of "wpSourceTypeurl" to match the actual id generated in SpecialUpload.php

14 years agofix fatal error in Special:Preferences if $wgDefaultUserOptions['date'] is not valid...
Ilmari Karonen [Sat, 10 Apr 2010 23:46:58 +0000 (23:46 +0000)]
fix fatal error in Special:Preferences if $wgDefaultUserOptions['date'] is not valid for the user's interface language

14 years agoFollow-up r64901: make "e-mail" consistent
Raimond Spekking [Sat, 10 Apr 2010 21:34:52 +0000 (21:34 +0000)]
Follow-up r64901: make "e-mail" consistent

14 years agoAdd messages.inc entry for r64903.
Happy-melon [Sat, 10 Apr 2010 21:23:30 +0000 (21:23 +0000)]
Add messages.inc entry for r64903.

14 years ago* fixed some doxygen warnings
Alexandre Emsenhuber [Sat, 10 Apr 2010 21:14:49 +0000 (21:14 +0000)]
* fixed some doxygen warnings

14 years agoOverhaul Special:EmailUser, use HTMLForm, a SpecialPage-derived class, and general...
Happy-melon [Sat, 10 Apr 2010 21:14:35 +0000 (21:14 +0000)]
Overhaul Special:EmailUser, use HTMLForm, a SpecialPage-derived class, and general tidy up.  Message change got muddled into r64901.

14 years agoFollow-up to r64866 - add message, and apply the same validation to TextareaField...
Happy-melon [Sat, 10 Apr 2010 21:10:22 +0000 (21:10 +0000)]
Follow-up to r64866 - add message, and apply the same validation to TextareaField as well.

14 years agoTweak 'fileduplicatesearch-summary'. Spotted by Lloffiwr.
Siebrand Mazeland [Sat, 10 Apr 2010 18:58:35 +0000 (18:58 +0000)]
Tweak 'fileduplicatesearch-summary'. Spotted by Lloffiwr.

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Sat, 10 Apr 2010 18:57:02 +0000 (18:57 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-10 18:25:00 UTC)

14 years agoFollow up r64876 setHTMLTitle with boolean parameter left.
Platonides [Sat, 10 Apr 2010 18:29:24 +0000 (18:29 +0000)]
Follow up r64876 setHTMLTitle with boolean parameter left.

14 years agoFollow-up to r64407 - a perfect example of why we encourage using braces for one...
Happy-melon [Sat, 10 Apr 2010 16:44:10 +0000 (16:44 +0000)]
Follow-up to r64407 - a perfect example of why we encourage using braces for one-line conditionals in the first place.

14 years agofixing bug 23139 (introduced in r59655) which broke edit conflict resolution
Tobias [Sat, 10 Apr 2010 14:11:40 +0000 (14:11 +0000)]
fixing bug 23139 (introduced in r59655) which broke edit conflict resolution

14 years agoFollow up r62006 readding return $ok; to what is now runTests()
Platonides [Sat, 10 Apr 2010 14:06:16 +0000 (14:06 +0000)]
Follow up r62006 readding return $ok; to what is now runTests()
This fixes parserTests.php not returning 0 on success.

14 years agoProposed cleanup of recent LanguageConverter-related commits:
Tim Starling [Sat, 10 Apr 2010 13:38:50 +0000 (13:38 +0000)]
Proposed cleanup of recent LanguageConverter-related commits:

* Moved the responsibility for calling $wgOut->setPageTitle() from OutputPage::addParserOutputNoText() to the OutputPage/Parser caller. Previously, every call to $wgOut->addWikiText() (or any other message parsing function) was resulting in the title being reset to a converted version of $wgTitle, producing bug 23124. Moving responsibility to the caller seems to work fairly well, since there are apparently only two callers that really want {{DISPLAYTITLE}} etc. to work (EditPage and Article::view).
* Reverted data flow obfuscation in OutputPage::setHTMLTitle() from r64851, replaced by the above. The caller decides what overrides what.
* Reverted inappropriate, cache-polluting references to $wgUser and $wgRequest in Parser::parse(), introduced in r64819.
* Reverted incomprehensible boolean parameter to Language::convert() from r64851, reintroduced Language::convertTitle() instead. Gave it a simpler implementation than before.
* Fixed broken {{DISPLAYTITLE}} feature, was being unconditionally overwritten by the ParserOutput::setTitleText() call in Parser::parse(). Give {{DISPLAYTITLE}} precedence over autoconverted title, like we do for -{T|...}-.
* Tested extensively (perhaps not exhaustively)

14 years agoRefactor getTokenSalt to use caching getUser/getTitle in ApiRollback and ApiUserrights
Sam Reed [Sat, 10 Apr 2010 13:33:24 +0000 (13:33 +0000)]
Refactor getTokenSalt to use caching getUser/getTitle in ApiRollback and ApiUserrights

14 years agoFix total breakage of search engine in zh wikis due to incorrect variable name
Tim Starling [Sat, 10 Apr 2010 13:16:49 +0000 (13:16 +0000)]
Fix total breakage of search engine in zh wikis due to incorrect variable name

14 years agoRevert r64825
Sam Reed [Sat, 10 Apr 2010 12:29:44 +0000 (12:29 +0000)]
Revert r64825

14 years agoFollowup to r64850: replace $username with the right var
Roan Kattouw [Sat, 10 Apr 2010 12:14:47 +0000 (12:14 +0000)]
Followup to r64850: replace $username with the right var

14 years agoImprovements and fixes to HTMLForm:
Happy-melon [Sat, 10 Apr 2010 12:03:30 +0000 (12:03 +0000)]
Improvements and fixes to HTMLForm:
* allow css classes to be specified in form descriptors
* Don't overwrite $field['name'] if it's set
* Allow IDs on hidden fields
* Enforce 'required' validation on Text fields
* Fix type validation on Int fields to correctly handle numbers larger than PHP_MAX_INT or with leading zeroes (eg phone numbers on 32 bit systems)
* Fix weak-typing error in MultiSelect field
* Formatting and doc fixes

14 years agoFix epic fail in r64860
Roan Kattouw [Sat, 10 Apr 2010 11:10:53 +0000 (11:10 +0000)]
Fix epic fail in r64860

14 years agoFix yet another instance of comparing the result of User::newFromName to null
Roan Kattouw [Sat, 10 Apr 2010 10:08:29 +0000 (10:08 +0000)]
Fix yet another instance of comparing the result of User::newFromName to null

14 years agoFollow up r64851. Remove $wgOut.
Philip Tzou [Sat, 10 Apr 2010 07:07:49 +0000 (07:07 +0000)]
Follow up r64851. Remove $wgOut.

14 years agoAdd $wgLogAutocreatedAccounts to enable/disable account autocreation logging.
Victor Vasiliev [Sat, 10 Apr 2010 06:21:13 +0000 (06:21 +0000)]
Add $wgLogAutocreatedAccounts to enable/disable account autocreation logging.