lhc/web/wiklou.git
16 years agoFix call to deprecated functions
Alexandre Emsenhuber [Thu, 20 Mar 2008 22:00:59 +0000 (22:00 +0000)]
Fix call to deprecated functions

16 years agoAnnoying typo.
Greg Sabino Mullane [Thu, 20 Mar 2008 21:52:01 +0000 (21:52 +0000)]
Annoying typo.

16 years agoRemove the functionality allowing users to change the default direction; this is...
Aryeh Gregor [Thu, 20 Mar 2008 21:49:22 +0000 (21:49 +0000)]
Remove the functionality allowing users to change the default direction; this is basically redundant with first/last.  Uncomment the multiple-ordering stuff in Pager.php, since it works fine, but comment it out in SpecialCategories.php, since the index is not unique and it won't sort correctly.  IndexPager needs to support multiple-column sort, and the index should be extended to (cat_pages, cat_title).

16 years agobug 13448 second bit
Brion Vibber [Thu, 20 Mar 2008 21:48:28 +0000 (21:48 +0000)]
bug 13448 second bit

16 years agoDon't add spurious ')' in enhanced RC block line if we don't have a clean size change
Brion Vibber [Thu, 20 Mar 2008 21:27:29 +0000 (21:27 +0000)]
Don't add spurious ')' in enhanced RC block line if we don't have a clean size change

16 years agocomment the extra category paging option links for now as they're kinda broken
Brion Vibber [Thu, 20 Mar 2008 21:09:47 +0000 (21:09 +0000)]
comment the extra category paging option links for now as they're kinda broken
the new options aren't retained on the paging links, and they don't interact correctly with various special page parameters such as starting points on the user lists

16 years agoPer Brion's suggestion, show the selected options too for the Pager stuff, with no...
Aryeh Gregor [Thu, 20 Mar 2008 20:54:29 +0000 (20:54 +0000)]
Per Brion's suggestion, show the selected options too for the Pager stuff, with no link, just as we do for the other bits.

16 years agoMessed about in this horror myself a bit, think I got some issues worked out. :D
Brion Vibber [Thu, 20 Mar 2008 18:58:38 +0000 (18:58 +0000)]
Messed about in this horror myself a bit, think I got some issues worked out. :D
* Arrows align with the text again -- by keeping them within a text line, 'middle' alignment works
* Forced no-wrap whitespace to keep the line from breaking around the arrow or spacer image when the text line was long in Firefox

16 years agoUpdate.
Rotem Liss [Thu, 20 Mar 2008 18:37:06 +0000 (18:37 +0000)]
Update.

16 years ago(bug 13444) Add description to list=watchlist
Bryan Tong Minh [Thu, 20 Mar 2008 18:28:02 +0000 (18:28 +0000)]
(bug 13444) Add description to list=watchlist

16 years agoMissing pages in prop=langlinks and prop=extlinks are now handled properly. (bug...
Bryan Tong Minh [Thu, 20 Mar 2008 18:23:55 +0000 (18:23 +0000)]
Missing pages in prop=langlinks and prop=extlinks are now handled properly. (bug 13442)

16 years agoLocalisation updates for core messages from Betawiki (2008-03-20 18:56 CET)
Siebrand Mazeland [Thu, 20 Mar 2008 18:19:09 +0000 (18:19 +0000)]
Localisation updates for core messages from Betawiki (2008-03-20 18:56 CET)

16 years agoAlign arrows to top, but move down half a line, so it lines up
Aaron Schulz [Thu, 20 Mar 2008 17:59:38 +0000 (17:59 +0000)]
Align arrows to top, but move down half a line, so it lines up

16 years ago(bug 13454) Article::updateCategoryCounts can attempt to execute empty inserts.
Aryeh Gregor [Thu, 20 Mar 2008 17:33:32 +0000 (17:33 +0000)]
(bug 13454) Article::updateCategoryCounts can attempt to execute empty inserts.

16 years agoRevert r32218 -- incredibly cryptic illegible class names
Brion Vibber [Thu, 20 Mar 2008 17:16:21 +0000 (17:16 +0000)]
Revert r32218 -- incredibly cryptic illegible class names

16 years agoWait, never mind, revert that. This is supposed to be DB keys . . .
Aryeh Gregor [Thu, 20 Mar 2008 17:07:07 +0000 (17:07 +0000)]
Wait, never mind, revert that.  This is supposed to be DB keys . . .

16 years agoI knew there was a better way. Use makeTitleSafe for this too.
Aryeh Gregor [Thu, 20 Mar 2008 17:04:32 +0000 (17:04 +0000)]
I knew there was a better way.  Use makeTitleSafe for this too.

16 years agoMove some of the changes I made to Special:Categories out of SpecialCategories.php...
Aryeh Gregor [Thu, 20 Mar 2008 17:02:35 +0000 (17:02 +0000)]
Move some of the changes I made to Special:Categories out of SpecialCategories.php and into Pager.php.  Allow multiple possible sort orders for IndexPager, allow user override of sort direction for IndexPager, add extra links as appropriate for AlphabeticPager.  Some of this seems to duplicate TablePager logic; I'm not sure why that's a separate class to begin with.  Or why AlphabeticPager is called that, given that it's not necessarily alphabetic at all.  In fact all of these child classes seem to perform almost identical functions and it seems as though folding them into the IndexPager class would reduce code duplication.

16 years ago$lastSize is also an int or a literal NULL. Bug 13453.
Greg Sabino Mullane [Thu, 20 Mar 2008 16:59:24 +0000 (16:59 +0000)]
$lastSize is also an int or a literal NULL. Bug 13453.

16 years agoDon't quote the size, it's an int or a literal NULL. Per bug 13453.
Greg Sabino Mullane [Thu, 20 Mar 2008 16:49:12 +0000 (16:49 +0000)]
Don't quote the size, it's an int or a literal NULL. Per bug 13453.

16 years agoUse Title::makeTitleSafe
Victor Vasiliev [Thu, 20 Mar 2008 16:39:02 +0000 (16:39 +0000)]
Use Title::makeTitleSafe

16 years agoHandle empty sets correctly
Victor Vasiliev [Thu, 20 Mar 2008 16:28:38 +0000 (16:28 +0000)]
Handle empty sets correctly

16 years ago* Adding/updating Persian translations
Huji [Thu, 20 Mar 2008 15:28:12 +0000 (15:28 +0000)]
* Adding/updating Persian translations

16 years agoChange misleading comment
Aryeh Gregor [Thu, 20 Mar 2008 14:10:17 +0000 (14:10 +0000)]
Change misleading comment

16 years agoUpdate.
Rotem Liss [Thu, 20 Mar 2008 13:48:26 +0000 (13:48 +0000)]
Update.

16 years agoLocalisation updates German
Raimond Spekking [Thu, 20 Mar 2008 13:26:26 +0000 (13:26 +0000)]
Localisation updates German

16 years ago* Readd 'version' to messages.inc. Thanks to Grondin :)
Raimond Spekking [Thu, 20 Mar 2008 12:22:27 +0000 (12:22 +0000)]
* Readd 'version' to messages.inc. Thanks to Grondin :)
* Add comments for messages which are not used as normal message but as header for the special page itself

16 years agoAdd a few CSS classes to the tables
Raimond Spekking [Thu, 20 Mar 2008 11:20:13 +0000 (11:20 +0000)]
Add a few CSS classes to the tables

16 years ago* (Bug 13448) Fix regression from r32077: Readd CSS id for hidden field.
Raimond Spekking [Thu, 20 Mar 2008 10:46:17 +0000 (10:46 +0000)]
* (Bug 13448) Fix regression from r32077: Readd CSS id for hidden field.
Please see above bug for a suggestion. I haven't touched upload.js and I am unsure about it. Thanks.

16 years agoFixing missing message for extention title
Bertrand Grondin [Thu, 20 Mar 2008 10:06:08 +0000 (10:06 +0000)]
Fixing missing message for extention title

16 years ago Localisation updates for extensions messages from Betawiki
Bertrand Grondin [Thu, 20 Mar 2008 09:20:53 +0000 (09:20 +0000)]
 Localisation updates for extensions messages from Betawiki

16 years ago* (bug 13395) list=allcategories should use category table
Victor Vasiliev [Thu, 20 Mar 2008 09:20:23 +0000 (09:20 +0000)]
* (bug 13395) list=allcategories should use category table
* cat_hidden doesn't work. why?

16 years agoEaster housekeeping:
Raimond Spekking [Thu, 20 Mar 2008 08:20:47 +0000 (08:20 +0000)]
Easter housekeeping:
* Message 'subcategorycount' was removed in r32085
* Message 'groups' unused since ages

16 years ago* (bug 13322) Messages 'orig' and 'loadhist' removed, unused since ages
Raimond Spekking [Thu, 20 Mar 2008 07:06:18 +0000 (07:06 +0000)]
* (bug 13322) Messages 'orig' and 'loadhist' removed, unused since ages
Message 'isbn' removed too, was replaced by 'booksources-isbn' some time ago

16 years agoUpdated credits per discussion with Brion
Yuri Astrakhan [Thu, 20 Mar 2008 06:54:24 +0000 (06:54 +0000)]
Updated credits per discussion with Brion

16 years ago* Adding/updating Persian translations
Huji [Thu, 20 Mar 2008 06:38:42 +0000 (06:38 +0000)]
* Adding/updating Persian translations

16 years agoMessages 'data' and 'version' removed, seems unused since ages.
Raimond Spekking [Thu, 20 Mar 2008 06:29:51 +0000 (06:29 +0000)]
Messages 'data' and 'version' removed, seems unused since ages.
Please double check for usage before rebuilding all message files.

16 years ago* Add the new messages from r32198 to messages.inc
Raimond Spekking [Thu, 20 Mar 2008 06:05:32 +0000 (06:05 +0000)]
* Add the new messages from r32198 to messages.inc
* While I am in this section, move some other messages to their corresponding sections

16 years agoIndonesian (id) localisation updates for core messages.
Ivan Lanin [Thu, 20 Mar 2008 03:22:57 +0000 (03:22 +0000)]
Indonesian (id) localisation updates for core messages.

16 years agoImage should be 'middle' aligned
Aaron Schulz [Thu, 20 Mar 2008 03:00:38 +0000 (03:00 +0000)]
Image should be 'middle' aligned

16 years agoRemove lead space - not useful
Aaron Schulz [Thu, 20 Mar 2008 02:53:47 +0000 (02:53 +0000)]
Remove lead space - not useful

16 years agoNo need to <tt> these
Aaron Schulz [Thu, 20 Mar 2008 02:21:20 +0000 (02:21 +0000)]
No need to <tt> these

16 years agoRemove debug borders
Aaron Schulz [Thu, 20 Mar 2008 02:09:51 +0000 (02:09 +0000)]
Remove debug borders

16 years agoSpacing cleanup
Aaron Schulz [Thu, 20 Mar 2008 02:08:35 +0000 (02:08 +0000)]
Spacing cleanup

16 years agoUse formatNum for counts on category page.
Aryeh Gregor [Thu, 20 Mar 2008 02:01:55 +0000 (02:01 +0000)]
Use formatNum for counts on category page.

16 years agoNighttime commit when I'm tired and want to get this thing checked in and go to bed...
Aryeh Gregor [Thu, 20 Mar 2008 01:49:33 +0000 (01:49 +0000)]
Nighttime commit when I'm tired and want to get this thing checked in and go to bed!  Yay!  Allow sorting by number of members on Special:Categories, and also allow descending sorts.  Mostlinkedcategories should be killed and turned into a redirect to this.

16 years ago*Border should explicitly be 0
Aaron Schulz [Thu, 20 Mar 2008 01:20:39 +0000 (01:20 +0000)]
*Border should explicitly be 0
*Spacing

16 years agoUse category table for more efficient display of Special:Categories. I never realize...
Aryeh Gregor [Thu, 20 Mar 2008 00:49:02 +0000 (00:49 +0000)]
Use category table for more efficient display of Special:Categories.  I never realized how awesome our frameworks for this kind of boilerplate special page were.  This was a two-minute job.

16 years ago*End parenthesis lost in output somehow, add it back
Aaron Schulz [Thu, 20 Mar 2008 00:31:16 +0000 (00:31 +0000)]
*End parenthesis lost in output somehow, add it back
*Remove hard-coded size attribute

16 years agohopefully don't die on non-gallery-laden pages which trigger this consistency check
Brion Vibber [Wed, 19 Mar 2008 23:45:18 +0000 (23:45 +0000)]
hopefully don't die on non-gallery-laden pages which trigger this consistency check

16 years agofix regression in page history, where sometimes the last link would need to generate...
Brion Vibber [Wed, 19 Mar 2008 23:43:26 +0000 (23:43 +0000)]
fix regression in page history, where sometimes the last link would need to generate an 'oldid=prev' link but called a bogus variable

16 years agoif we get a bad cat, spit a warning and *continue* processing the rest of the wiki :)
Brion Vibber [Wed, 19 Mar 2008 23:20:01 +0000 (23:20 +0000)]
if we get a bad cat, spit a warning and *continue* processing the rest of the wiki :)

16 years agofix regression in XHTML validity
Brion Vibber [Wed, 19 Mar 2008 23:19:37 +0000 (23:19 +0000)]
fix regression in XHTML validity

16 years agoLocalisation updates German
Raimond Spekking [Wed, 19 Mar 2008 22:41:24 +0000 (22:41 +0000)]
Localisation updates German

16 years agoHandy script to manually run a single sql patch file, with all the necessary options...
Brion Vibber [Wed, 19 Mar 2008 22:25:20 +0000 (22:25 +0000)]
Handy script to manually run a single sql patch file, with all the necessary options expanded (prefix, charset, etc).
Commands like 'php maintenance/patchSql.php updatelog category'

16 years ago* Adding/updating Persian translations
Huji [Wed, 19 Mar 2008 20:56:39 +0000 (20:56 +0000)]
* Adding/updating Persian translations
* Updating messages.inc to let RebuildLanguage work correctly with the newly added message block

16 years agoRewrite a bit the MediaWiki class:
Alexandre Emsenhuber [Wed, 19 Mar 2008 19:55:26 +0000 (19:55 +0000)]
Rewrite a bit the MediaWiki class:
* Document function parameter and undocumented functions
* Move use of global settings to localized one setted in index.php
* fix whitespaces
* Use __METHOD__ instead of hardcoded method names
* Call MediaWiki::articleFromTitle() staticly

16 years agoPopulate rc_deleted
Aaron Schulz [Wed, 19 Mar 2008 18:42:09 +0000 (18:42 +0000)]
Populate rc_deleted

16 years agorev_deleted merge:
Aaron Schulz [Wed, 19 Mar 2008 18:09:20 +0000 (18:09 +0000)]
rev_deleted merge:
*Hide deleted content
*Add show/hide links

16 years ago* (bug 1459) Search for duplicate files by hash: Special:FileDuplicateSearch
Raimond Spekking [Wed, 19 Mar 2008 16:58:56 +0000 (16:58 +0000)]
* (bug 1459) Search for duplicate files by hash: Special:FileDuplicateSearch
* Add a link on the image description page to Special:FileDuplicateSearch/filename.ext

16 years agoFix an error for categories named literally "Project:" or some similarly weird thing...
Aryeh Gregor [Wed, 19 Mar 2008 15:53:48 +0000 (15:53 +0000)]
Fix an error for categories named literally "Project:" or some similarly weird thing.  I thought that's not a legal title, but I'm told otherwise.  Is there a better way to do this than manually prefixing "Category:"?  The second parameter to newFromText is ignored if there are any prefixes, according to the docs.

16 years agoWrong index, should be unique. Thanks Simmetrical.
Greg Sabino Mullane [Wed, 19 Mar 2008 14:27:00 +0000 (14:27 +0000)]
Wrong index, should be unique. Thanks Simmetrical.

16 years ago* Adding/updating Persian translations
Huji [Wed, 19 Mar 2008 14:18:00 +0000 (14:18 +0000)]
* Adding/updating Persian translations

16 years agoRemove apparently pointless $dbw parameter to Article::updateCategoryCounts.
Aryeh Gregor [Wed, 19 Mar 2008 13:36:33 +0000 (13:36 +0000)]
Remove apparently pointless $dbw parameter to Article::updateCategoryCounts.

16 years agoPatch from Sven Klemm from bug 13239: search_path tweaks for Postgres.
Greg Sabino Mullane [Wed, 19 Mar 2008 13:23:12 +0000 (13:23 +0000)]
Patch from Sven Klemm from bug 13239: search_path tweaks for Postgres.

16 years agoUse $db->conditional() instead of non-standard IF(). Fixes bug 13430.
Greg Sabino Mullane [Wed, 19 Mar 2008 13:15:09 +0000 (13:15 +0000)]
Use $db->conditional() instead of non-standard IF(). Fixes bug 13430.

16 years agoTypo.
Greg Sabino Mullane [Wed, 19 Mar 2008 13:06:16 +0000 (13:06 +0000)]
Typo.

16 years agoAdd 'category' table to Postgres schema.
Greg Sabino Mullane [Wed, 19 Mar 2008 13:02:49 +0000 (13:02 +0000)]
Add 'category' table to Postgres schema.

16 years agoTake out "bools" section: we're just using smallints now
Greg Sabino Mullane [Wed, 19 Mar 2008 13:02:04 +0000 (13:02 +0000)]
Take out "bools" section: we're just using smallints now

16 years agoAdd category table.
Greg Sabino Mullane [Wed, 19 Mar 2008 13:01:24 +0000 (13:01 +0000)]
Add category table.

16 years agoNo need for (1), keep tinyint consistent with the other booleans.
Greg Sabino Mullane [Wed, 19 Mar 2008 12:55:11 +0000 (12:55 +0000)]
No need for (1), keep tinyint consistent with the other booleans.

16 years agoIn continuation of r23243: is already created by Setup.php, it don't need to set...
Alexandre Emsenhuber [Wed, 19 Mar 2008 12:43:00 +0000 (12:43 +0000)]
In continuation of r23243:  is already created by Setup.php, it don't need to set twice.

16 years agoUpdate.
Rotem Liss [Wed, 19 Mar 2008 11:36:01 +0000 (11:36 +0000)]
Update.

16 years ago(bug 13137) Bots to edit protected pages
Huji [Wed, 19 Mar 2008 11:23:03 +0000 (11:23 +0000)]
(bug 13137) Bots to edit protected pages
For the record: A previous effort to fix this (r31247) failed (r31462)

16 years agoFixed no-op update query in common code path
Tim Starling [Wed, 19 Mar 2008 11:19:00 +0000 (11:19 +0000)]
Fixed no-op update query in common code path

16 years ago(bug 13429) Separate date and time in message sp-newimages-showfrom
Huji [Wed, 19 Mar 2008 10:21:45 +0000 (10:21 +0000)]
(bug 13429) Separate date and time in message sp-newimages-showfrom

16 years ago* Adding/updating Persian translations
Huji [Wed, 19 Mar 2008 10:14:14 +0000 (10:14 +0000)]
* Adding/updating Persian translations

16 years ago* update namespaces from Wikipedia -> Project
Siebrand Mazeland [Wed, 19 Mar 2008 09:14:30 +0000 (09:14 +0000)]
* update namespaces from Wikipedia -> Project
* remove messages referencing Wikipedia/Wikimedia

16 years agoLocalisation updates for core messages from Betawiki (2008-03-19 09:59 CET)
Siebrand Mazeland [Wed, 19 Mar 2008 09:03:29 +0000 (09:03 +0000)]
Localisation updates for core messages from Betawiki (2008-03-19 09:59 CET)

16 years ago* Add some CSS ids to forms and tables
Raimond Spekking [Wed, 19 Mar 2008 08:14:05 +0000 (08:14 +0000)]
* Add some CSS ids to forms and tables
* Use proper XML functions
* Fix double escaping
* Fix indention

16 years ago* Add a nice fieldset around the input form
Raimond Spekking [Wed, 19 Mar 2008 06:33:39 +0000 (06:33 +0000)]
* Add a nice fieldset around the input form
* Fix double escaping

16 years agoFixed debugging code left in (since r24477)
Tim Starling [Wed, 19 Mar 2008 03:10:31 +0000 (03:10 +0000)]
Fixed debugging code left in (since r24477)

16 years ago* (bug 9403) Sanitize newlines from search term input
Brion Vibber [Wed, 19 Mar 2008 00:34:49 +0000 (00:34 +0000)]
* (bug 9403) Sanitize newlines from search term input

16 years ago* (bug 13428) Fix regression in protection form layout HTML validity
Brion Vibber [Wed, 19 Mar 2008 00:08:58 +0000 (00:08 +0000)]
* (bug 13428) Fix regression in protection form layout HTML validity
a ; in place of a . there...

16 years ago* (bug 12801) Fix link in subtitle message in AJAX search
Brion Vibber [Wed, 19 Mar 2008 00:03:56 +0000 (00:03 +0000)]
* (bug 12801) Fix link in subtitle message in AJAX search

16 years agoAdd some newlines in messages consisting of multiple sentences
Siebrand Mazeland [Tue, 18 Mar 2008 23:54:09 +0000 (23:54 +0000)]
Add some newlines in messages consisting of multiple sentences

16 years ago* (bug 11563) Deprecated SearchMySQL4 class; merged code to SearchMySQL
Brion Vibber [Tue, 18 Mar 2008 23:50:05 +0000 (23:50 +0000)]
* (bug 11563) Deprecated SearchMySQL4 class; merged code to SearchMySQL
Some general cleanup on search backend code style :)

16 years agoAll messages files rebuilt and unknown messages removed
Siebrand Mazeland [Tue, 18 Mar 2008 23:43:40 +0000 (23:43 +0000)]
All messages files rebuilt and unknown messages removed

16 years agoCheck permissions before using cache (bug 9432)
Aaron Schulz [Tue, 18 Mar 2008 23:36:24 +0000 (23:36 +0000)]
Check permissions before using cache (bug 9432)

16 years agoLocalisation updates German
Raimond Spekking [Tue, 18 Mar 2008 23:16:00 +0000 (23:16 +0000)]
Localisation updates German

16 years agoPass $time on like it should
Aaron Schulz [Tue, 18 Mar 2008 23:14:20 +0000 (23:14 +0000)]
Pass $time on like it should

16 years agoRevert r32126 -- breaks type-safety by having a bunch of Revision functions which...
Brion Vibber [Tue, 18 Mar 2008 23:07:19 +0000 (23:07 +0000)]
Revert r32126 -- breaks type-safety by having a bunch of Revision functions which are supposed to always return strings return booleans sometimes.
Let's not toss in even more scary possibilities, please... predictability is nice!

16 years ago* Remove 5 messages, unused since ages:
Raimond Spekking [Tue, 18 Mar 2008 23:01:36 +0000 (23:01 +0000)]
* Remove 5 messages, unused since ages:
** 'getimagelist', 'showlast', 'byname', 'bysize', 'imgdelete'
* Regroup messages for Special:Imagelist, Special:NewImages and the image description page
* Add short descriptions to 'newimages-summary' and 'imagelist-summary' and remove their optional message status

16 years ago* (bug 13403) Fix cache invalidation of history pages when old revisions change
Brion Vibber [Tue, 18 Mar 2008 23:00:14 +0000 (23:00 +0000)]
* (bug 13403) Fix cache invalidation of history pages when old revisions change
add release note line for r32119 -- thanks aaron :D

16 years agoFix raw vs non-raw number formatting for {{PAGESINNS:}}
Brion Vibber [Tue, 18 Mar 2008 22:34:10 +0000 (22:34 +0000)]
Fix raw vs non-raw number formatting for {{PAGESINNS:}}
Cleanup some freaky code that does unnecessary call_user_func :)

16 years agoWorkaround for runJobs CategoryTree issue:
Brion Vibber [Tue, 18 Mar 2008 21:45:18 +0000 (21:45 +0000)]
Workaround for runJobs CategoryTree issue:
* Don't bloat $this->mStripList on every setHook() call.

It adds up in batch processing until we end up with regex errors!

16 years agoLocalisation updates for core messages from Betawiki (2008-03-18 22:19 CET)
Siebrand Mazeland [Tue, 18 Mar 2008 21:33:47 +0000 (21:33 +0000)]
Localisation updates for core messages from Betawiki (2008-03-18 22:19 CET)

16 years ago* Add a nice fieldset around the input form
Raimond Spekking [Tue, 18 Mar 2008 20:29:46 +0000 (20:29 +0000)]
* Add a nice fieldset around the input form
* Use proper XML function

16 years ago Localisation updates for extensions messages from Betawiki
Bertrand Grondin [Tue, 18 Mar 2008 19:56:11 +0000 (19:56 +0000)]
 Localisation updates for extensions messages from Betawiki

16 years ago*Return false when a user cannot see a field of a revision, rather than "", which...
Aaron Schulz [Tue, 18 Mar 2008 19:37:03 +0000 (19:37 +0000)]
*Return false when a user cannot see a field of a revision, rather than "", which could actually be valid
*Remove now unneeded perm checks in diffEng
*Fix unsafe cache leak for diffs (bug 9432)