From: Timo Tijhof <krinklemail@gmail.com>
Date: Thu, 1 Aug 2013 20:37:41 +0000 (+0200)
Subject: doc: Clarify documentation for ParserOptions::getUserLangObj
X-Git-Tag: 1.31.0-rc.0~19059
X-Git-Url: https://git.cyclocoop.org/?a=commitdiff_plain;h=06cfd63442724ce7b67401cb022c065448e8f2c2;p=lhc%2Fweb%2Fwiklou.git

doc: Clarify documentation for ParserOptions::getUserLangObj

It no longer produces inconsistent link tables, that was fixed
in r89706 by setting the parser to the default language when
saving, and then when viewing it might reparse for a different
uselang if needed (without saving link updates).

Of course, that isn't pretty and it should still be discouraged.

Change-Id: I599a7162fed458713ffa3a754086c6a2ffdebe07
---

diff --git a/includes/parser/ParserOptions.php b/includes/parser/ParserOptions.php
index b01f162877..bde508a29b 100644
--- a/includes/parser/ParserOptions.php
+++ b/includes/parser/ParserOptions.php
@@ -280,9 +280,17 @@ class ParserOptions {
 	}
 
 	/**
+	 * Get the user language used by the parser for this page.
+	 *
 	 * You shouldn't use this. Really. $parser->getFunctionLang() is all you need.
-	 * Using this fragments the cache and is discouraged. Yes, {{int: }} uses this,
-	 * producing inconsistent tables (Bug 14404).
+	 *
+	 * To avoid side-effects where the page will be rendered based on the language
+	 * of the user who last saved, this function will triger a cache fragmentation.
+	 * Usage of this method is discouraged for that reason.
+	 *
+	 * When saving, this will return the default language instead of the user's.
+	 *
+	 * {{int: }} uses this which used to produce inconsistent link tables (bug 14404).
 	 *
 	 * @return Language object
 	 * @since 1.19