[FileBackend] Use strcmp() for listing comparisons.
authorAaron Schulz <aschulz@wikimedia.org>
Sat, 25 Aug 2012 19:07:35 +0000 (12:07 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Sat, 25 Aug 2012 19:07:35 +0000 (12:07 -0700)
Change-Id: I60da57bd6cdb77a21763bb34afb51a02d905eb3a

includes/filebackend/SwiftFileBackend.php

index f54f666..e545b94 100644 (file)
@@ -852,13 +852,13 @@ class SwiftFileBackend extends FileBackendStore {
                                                // See function "create_container_table" in common/db.py.
                                                // If a directory is not "greater" than the last one,
                                                // then it was already listed by the calling iterator.
-                                               if ( $objectDir > $lastDir ) {
+                                               if ( strcmp( $objectDir, $lastDir ) > 0 ) {
                                                        $pDir = $objectDir;
                                                        do { // add dir and all its parent dirs
                                                                $dirs[] = "{$pDir}/";
                                                                $pDir = $this->getParentDir( $pDir );
                                                        } while ( $pDir !== false // sanity
-                                                               && $pDir > $lastDir // not done already
+                                                               && strcmp( $pDir, $lastDir ) > 0 // not done already
                                                                && strlen( $pDir ) > strlen( $dir ) // within $dir
                                                        );
                                                }