* Convert spaces to underscores instead of breaking mysteriously

* (bug 8066) Spaces can't be entered in special page aliases

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index cd5e33f..644ca51 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -262,6 +262,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * Fix regression -- missing feed links in sidebar on Special:Recentchanges
 * (bug 12371) Handle more namespace case variants in namespaceDupes.php
 * (bug 12380) Bot-friendly EditPage::spamPage
+* (bug 8066) Spaces can't be entered in special page aliases
 
 == Parser changes in 1.12 ==
 

diff --git a/languages/Language.php b/languages/Language.php
index 6caee42..c65d9aa 100644 (file)
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -2134,6 +2134,13 @@ class Language {
 
                # Replace spaces with underscores in namespace names
                $cache['namespaceNames'] = str_replace( ' ', '_', $cache['namespaceNames'] );
+
+               # And do the same for specialpage aliases. $page is an array.
+               foreach ( $cache['specialPageAliases'] as &$page ) {
+                       $page = str_replace( ' ', '_', $page );
+               }
+               # Decouple the reference to prevent accidental damage
+               unset($page);
                
                # Save to both caches
                self::$mLocalisationCache[$code] = $cache;