* (bug 19531) addPortletLink() now wraps inserted labels in a <span> element to be
compatible with the CSS for the Vector skin
* (bug 20578) Wrong localized image metadata - duplicated string?
+* (bug 20556) Stub threshold's "other" <input> in Special:Preferences now has a
+ correct type="text" parameter
== API changes in 1.16 ==
static $jsAdded = false;
function __construct( $params ) {
- if( !in_array( 'other', $params['options'] ) ) {
+ if( !in_array( 'other', $params['options'], true ) ) {
$params['options'][wfMsg( 'htmlform-selectorother-other' )] = 'other';
}
$select->setAttribute( 'class', 'mw-htmlform-select-or-other' );
- $tbAttribs = array( 'id' => $this->mID . '-other' );
+ $tbAttribs = array( 'id' => $this->mID . '-other', 'size' => $this->getSize() );
if( !empty( $this->mParams['disabled'] ) ) {
$select->setAttribute( 'disabled', 'disabled' );
$tbAttribs['disabled'] = 'disabled';
}
$textbox = Html::input( $this->mName . '-other',
- $this->getSize(),
- $valInSelect ? 'text' : $value,
+ $valInSelect ? '' : $value,
+ 'text',
$tbAttribs );
return "$select<br/>\n$textbox";