(bug 5970) Need to login to upload files

This fixes a mistake in the permissions system (which shouldn't be exist), however the actual problem - anonymous users logging - is still exist.

diff --git a/includes/SpecialUpload.php b/includes/SpecialUpload.php
index 807a882..b6301f1 100644 (file)
--- a/includes/SpecialUpload.php
+++ b/includes/SpecialUpload.php
@@ -202,13 +202,12 @@ class UploadForm {
                }
 
                # Check permissions
-               if( $wgUser->isLoggedIn() ) {
-                       if( !$wgUser->isAllowed( 'upload' ) ) {
+               if( !$wgUser->isAllowed( 'upload' ) ) {
+                       if( !$wgUser->isLoggedIn() ) {
+                               $wgOut->showErrorPage( 'uploadnologin', 'uploadnologintext' );
+                       } else {
                                $wgOut->permissionRequired( 'upload' );
-                               return;
                        }
-               } else {
-                       $wgOut->showErrorPage( 'uploadnologin', 'uploadnologintext' );
                        return;
                }