* (bug 12988) $wgMinimalPasswordLength no longer breaks create user by email

The user password was being set to '-' briefly during setup, before being overwritten.
This broke with $wgMinimalPasswordLength > 1, throwing a fatal exception.
Using the special value of null instead allows the initial non-valid password entry to be set without hitting the minimum length.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index ff50614..d41b763 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -42,6 +42,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 13140) Show parent categories in category namespace
 * (bug 13149) Correctly format 'fileexists' message on Upload page.
 * Make filepageexists accurate.
+* (bug 12988) $wgMinimalPasswordLength no longer breaks create user by email
 
 === API changes in 1.13 ===
 

diff --git a/includes/SpecialUserlogin.php b/includes/SpecialUserlogin.php
index 3651fdc..88ad236 100644 (file)
--- a/includes/SpecialUserlogin.php
+++ b/includes/SpecialUserlogin.php
@@ -271,8 +271,8 @@ class LoginForm {
                                return false;
                        } else {
                                # do not force a password for account creation by email
-                               # set pseudo password, it will be replaced later by a random generated password
-                               $this->mPassword = '-';
+                               # set invalid password, it will be replaced later by a random generated password
+                               $this->mPassword = null;
                        }
                }