Make the SQL search subclasses less nerve-wracking to read, by using makeList() inste...
authorTim Starling <tstarling@users.mediawiki.org>
Mon, 22 Dec 2008 12:31:15 +0000 (12:31 +0000)
committerTim Starling <tstarling@users.mediawiki.org>
Mon, 22 Dec 2008 12:31:15 +0000 (12:31 +0000)
commitcb68c863f06861892f6b55f8c273c928feb9cc44
tree620334b8ded7acddd158eedee362d3d6501b9e53
parent333567ce66908f1bad2d8d381221ab8804fc647a
Make the SQL search subclasses less nerve-wracking to read, by using makeList() instead of implode(), addQuotes() instead of strencode(), and by documenting the fact that parseQuery() is intentionally returning an SQL fragment to be included into a query without further escaping. No actual vulnerabilities fixed, due to effective UI-side validation, so this is just to minimise reviewer anxiety.
includes/SearchMySQL.php
includes/SearchOracle.php
includes/SearchPostgres.php