Fix handling of ar_length and ar_sha1 in RevisionArchiveRecord.

[lhc/web/wiklou.git] / tests / phpunit / includes / Storage / MutableRevisionRecordTest.php

diff --git a/tests/phpunit/includes/Storage/MutableRevisionRecordTest.php b/tests/phpunit/includes/Storage/MutableRevisionRecordTest.php
index 675201e..dd2c4b6 100644 (file)
--- a/tests/phpunit/includes/Storage/MutableRevisionRecordTest.php
+++ b/tests/phpunit/includes/Storage/MutableRevisionRecordTest.php
@@ -3,27 +3,116 @@
 namespace MediaWiki\Tests\Storage;
 
 use CommentStoreComment;
+use InvalidArgumentException;
 use MediaWiki\Storage\MutableRevisionRecord;
 use MediaWiki\Storage\RevisionAccessException;
 use MediaWiki\Storage\RevisionRecord;
 use MediaWiki\Storage\SlotRecord;
+use MediaWiki\User\UserIdentityValue;
 use MediaWikiTestCase;
+use TextContent;
 use Title;
 use WikitextContent;
 
 /**
  * @covers \MediaWiki\Storage\MutableRevisionRecord
+ * @covers \MediaWiki\Storage\RevisionRecord
  */
 class MutableRevisionRecordTest extends MediaWikiTestCase {
 
-       public function testSimpleSetGetId() {
+       use RevisionRecordTests;
+
+       /**
+        * @param array $rowOverrides
+        *
+        * @return MutableRevisionRecord
+        */
+       protected function newRevision( array $rowOverrides = [] ) {
+               $title = Title::newFromText( 'Dummy' );
+               $title->resetArticleID( 17 );
+
+               $user = new UserIdentityValue( 11, 'Tester', 0 );
+               $comment = CommentStoreComment::newUnsavedComment( 'Hello World' );
+
+               $record = new MutableRevisionRecord( $title );
+
+               if ( isset( $rowOverrides['rev_deleted'] ) ) {
+                       $record->setVisibility( $rowOverrides['rev_deleted'] );
+               }
+
+               if ( isset( $rowOverrides['rev_id'] ) ) {
+                       $record->setId( $rowOverrides['rev_id'] );
+               }
+
+               if ( isset( $rowOverrides['rev_page'] ) ) {
+                       $record->setPageId( $rowOverrides['rev_page'] );
+               }
+
+               $record->setContent( 'main', new TextContent( 'Lorem Ipsum' ) );
+               $record->setComment( $comment );
+               $record->setUser( $user );
+
+               return $record;
+       }
+
+       public function provideConstructor() {
+               $title = Title::newFromText( 'Dummy' );
+               $title->resetArticleID( 17 );
+
+               yield [
+                       $title,
+                       'acmewiki'
+               ];
+       }
+
+       /**
+        * @dataProvider provideConstructor
+        *
+        * @param Title $title
+        * @param bool $wikiId
+        */
+       public function testConstructorAndGetters(
+               Title $title,
+               $wikiId = false
+       ) {
+               $rec = new MutableRevisionRecord( $title, $wikiId );
+
+               $this->assertSame( $title, $rec->getPageAsLinkTarget(), 'getPageAsLinkTarget' );
+               $this->assertSame( $wikiId, $rec->getWikiId(), 'getWikiId' );
+       }
+
+       public function provideConstructorFailure() {
+               $title = Title::newFromText( 'Dummy' );
+               $title->resetArticleID( 17 );
+
+               yield 'not a wiki id' => [
+                       $title,
+                       null
+               ];
+       }
+
+       /**
+        * @dataProvider provideConstructorFailure
+        *
+        * @param Title $title
+        * @param bool $wikiId
+        */
+       public function testConstructorFailure(
+               Title $title,
+               $wikiId = false
+       ) {
+               $this->setExpectedException( InvalidArgumentException::class );
+               new MutableRevisionRecord( $title, $wikiId );
+       }
+
+       public function testSetGetId() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $this->assertNull( $record->getId() );
                $record->setId( 888 );
                $this->assertSame( 888, $record->getId() );
        }
 
-       public function testSimpleSetGetUser() {
+       public function testSetGetUser() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $user = $this->getTestSysop()->getUser();
                $this->assertNull( $record->getUser() );
@@ -31,34 +120,34 @@ class MutableRevisionRecordTest extends MediaWikiTestCase {
                $this->assertSame( $user, $record->getUser() );
        }
 
-       public function testSimpleSetGetPageId() {
+       public function testSetGetPageId() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $this->assertSame( 0, $record->getPageId() );
                $record->setPageId( 999 );
                $this->assertSame( 999, $record->getPageId() );
        }
 
-       public function testSimpleSetGetParentId() {
+       public function testSetGetParentId() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $this->assertNull( $record->getParentId() );
                $record->setParentId( 100 );
                $this->assertSame( 100, $record->getParentId() );
        }
 
-       public function testSimpleGetMainContentWhenEmpty() {
+       public function testGetMainContentWhenEmpty() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $this->setExpectedException( RevisionAccessException::class );
                $this->assertNull( $record->getContent( 'main' ) );
        }
 
-       public function testSimpleSetGetMainContent() {
+       public function testSetGetMainContent() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $content = new WikitextContent( 'Badger' );
                $record->setContent( 'main', $content );
                $this->assertSame( $content, $record->getContent( 'main' ) );
        }
 
-       public function testSimpleGetSlotWhenEmpty() {
+       public function testGetSlotWhenEmpty() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $this->assertFalse( $record->hasSlot( 'main' ) );
 
@@ -66,7 +155,7 @@ class MutableRevisionRecordTest extends MediaWikiTestCase {
                $record->getSlot( 'main' );
        }
 
-       public function testSimpleSetGetSlot() {
+       public function testSetGetSlot() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $slot = SlotRecord::newUnsaved(
                        'main',
@@ -77,42 +166,42 @@ class MutableRevisionRecordTest extends MediaWikiTestCase {
                $this->assertSame( $slot, $record->getSlot( 'main' ) );
        }
 
-       public function testSimpleSetGetMinor() {
+       public function testSetGetMinor() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $this->assertFalse( $record->isMinor() );
                $record->setMinorEdit( true );
                $this->assertSame( true, $record->isMinor() );
        }
 
-       public function testSimpleSetGetTimestamp() {
+       public function testSetGetTimestamp() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $this->assertNull( $record->getTimestamp() );
                $record->setTimestamp( '20180101010101' );
                $this->assertSame( '20180101010101', $record->getTimestamp() );
        }
 
-       public function testSimpleSetGetVisibility() {
+       public function testSetGetVisibility() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $this->assertSame( 0, $record->getVisibility() );
                $record->setVisibility( RevisionRecord::DELETED_USER );
                $this->assertSame( RevisionRecord::DELETED_USER, $record->getVisibility() );
        }
 
-       public function testSimpleSetGetSha1() {
+       public function testSetGetSha1() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $this->assertSame( 'phoiac9h4m842xq45sp7s6u21eteeq1', $record->getSha1() );
                $record->setSha1( 'someHash' );
                $this->assertSame( 'someHash', $record->getSha1() );
        }
 
-       public function testSimpleSetGetSize() {
+       public function testSetGetSize() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $this->assertSame( 0, $record->getSize() );
                $record->setSize( 775 );
                $this->assertSame( 775, $record->getSize() );
        }
 
-       public function testSimpleSetGetComment() {
+       public function testSetGetComment() {
                $record = new MutableRevisionRecord( Title::newFromText( 'Foo' ) );
                $comment = new CommentStoreComment( 1, 'foo' );
                $this->assertNull( $record->getComment() );