Merge "Adding a few tests for categories"

[lhc/web/wiklou.git] / maintenance / cleanupWatchlist.php

diff --git a/maintenance/cleanupWatchlist.php b/maintenance/cleanupWatchlist.php
index 7be4810..fbab6a3 100644 (file)
--- a/maintenance/cleanupWatchlist.php
+++ b/maintenance/cleanupWatchlist.php
@@ -1,12 +1,12 @@
 <?php
-/*
- * Script to remove broken, unparseable titles in the Watchlist.
+/**
+ * Remove broken, unparseable titles in the watchlist table.
  *
  * Usage: php cleanupWatchlist.php [--fix]
  * Options:
  *   --fix  Actually remove entries; without will only report.
  *
- * Copyright (C) 2005,2006 Brion Vibber <brion@pobox.com>
+ * Copyright © 2005,2006 Brion Vibber <brion@pobox.com>
  * http://www.mediawiki.org/
  *
  * This program is free software; you can redistribute it and/or modify
@@ -24,35 +24,57 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
+ * @file
  * @author Brion Vibber <brion at pobox.com>
  * @ingroup Maintenance
  */
 
-require_once( dirname(__FILE__) . '/cleanupTable.inc' );
+require_once( __DIR__ . '/cleanupTable.inc' );
 
+/**
+ * Maintenance script to remove broken, unparseable titles in the watchlist table.
+ *
+ * @ingroup Maintenance
+ */
 class WatchlistCleanup extends TableCleanup {
-       protected $targetTable = 'watchlist';
+       protected $defaultParams = array(
+               'table' => 'watchlist',
+               'index' => array( 'wl_user', 'wl_namespace', 'wl_title' ),
+               'conds' => array(),
+               'callback' => 'processRow'
+       );
+
        public function __construct() {
                parent::__construct();
                $this->mDescription = "Script to remove broken, unparseable titles in the Watchlist";
+               $this->addOption( 'fix', 'Actually remove entries; without will only report.' );
+       }
+
+       function execute() {
+               if ( !$this->hasOption( 'fix' ) ) {
+                       $this->output( "Dry run only: use --fix to enable updates\n" );
+               }
+               parent::execute();
        }
 
-       protected function processPage( $row ) {
+       protected function processRow( $row ) {
+               global $wgContLang;
                $current = Title::makeTitle( $row->wl_namespace, $row->wl_title );
                $display = $current->getPrefixedText();
-               $verified = UtfNormal::cleanUp( $display );
+               $verified = $wgContLang->normalize( $display );
                $title = Title::newFromText( $verified );
 
-               if( $row->wl_user == 0 || is_null( $title ) || !$title->equals( $current ) ) {
+               if ( $row->wl_user == 0 || is_null( $title ) || !$title->equals( $current ) ) {
                        $this->output( "invalid watch by {$row->wl_user} for ({$row->wl_namespace}, \"{$row->wl_title}\")\n" );
-                       $this->removeWatch( $row );
-                       return $this->progress( 1 );
+                       $updated = $this->removeWatch( $row );
+                       $this->progress( $updated );
+                       return;
                }
                $this->progress( 0 );
        }
 
        private function removeWatch( $row ) {
-               if( !$this->dryrun ) {
+               if ( !$this->dryrun && $this->hasOption( 'fix' ) ) {
                        $dbw = wfGetDB( DB_MASTER );
                        $dbw->delete( 'watchlist', array(
                                'wl_user'      => $row->wl_user,
@@ -60,9 +82,12 @@ class WatchlistCleanup extends TableCleanup {
                                'wl_title'     => $row->wl_title ),
                        __METHOD__ );
                        $this->output( "- removed\n" );
+                       return 1;
+               } else {
+                       return 0;
                }
        }
 }
 
 $maintClass = "WatchlistCleanup";
-require_once( DO_MAINTENANCE );
+require_once( RUN_MAINTENANCE_IF_MAIN );