From c99a288724eb59e4398d49ade90417aed7cd784e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Sat, 9 Aug 2014 00:38:14 +0200 Subject: [PATCH] Never display empty sections on Special:Version Follow-up to d423112b. Change-Id: I44c8bfe6f4ca1350a7e35a253785f772602353c1 --- includes/specials/SpecialVersion.php | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php index 50929a9ba6..318ceb148e 100644 --- a/includes/specials/SpecialVersion.php +++ b/includes/specials/SpecialVersion.php @@ -428,7 +428,11 @@ class SpecialVersion extends SpecialPage { function getExtensionCredits() { global $wgExtensionCredits; - if ( !count( $wgExtensionCredits ) ) { + if ( + count( $wgExtensionCredits ) === 0 || + // Skins are displayed separately, see getSkinCredits() + ( count( $wgExtensionCredits ) === 1 && isset( $wgExtensionCredits['skin'] ) ) + ) { return ''; } @@ -476,6 +480,11 @@ class SpecialVersion extends SpecialPage { * @return string Wikitext */ function getSkinCredits() { + global $wgExtensionCredits; + if ( !isset( $wgExtensionCredits['skin'] ) || count( $wgExtensionCredits['skin'] ) === 0 ) { + return ''; + } + $out = Xml::element( 'h2', array( 'id' => 'mw-version-skin' ), -- 2.20.1