From 85531b7b020a78d05813083c00007bfb4d32192c Mon Sep 17 00:00:00 2001 From: Fomafix Date: Sat, 10 Feb 2018 22:16:00 +0100 Subject: [PATCH] mediawiki.Title: Reorder function declaration This avoids the eslint rule exceptions: * no-use-before-define * vars-on-top Change-Id: Ie9c9145052fe8629b1aa50ac3e2ac62d6a10ec0f --- resources/src/mediawiki/mediawiki.Title.js | 40 +++++++++++----------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/resources/src/mediawiki/mediawiki.Title.js b/resources/src/mediawiki/mediawiki.Title.js index 9db2771d30..851f06c2d1 100644 --- a/resources/src/mediawiki/mediawiki.Title.js +++ b/resources/src/mediawiki/mediawiki.Title.js @@ -1,11 +1,9 @@ /*! * @author Neil Kandalgaonkar, 2010 - * @author Timo Tijhof, 2011-2013 + * @author Timo Tijhof * @since 1.18 */ -/* eslint-disable no-use-before-define */ - ( function ( mw, $ ) { /** * Parse titles into an object structure. Note that when using the constructor @@ -29,27 +27,10 @@ * mw.Title.makeTitle( NS_TEMPLATE, 'Template:Foo' ).getPrefixedText(); // => 'Template:Template:Foo' * * @class mw.Title - * @constructor - * @param {string} title Title of the page. If no second argument given, - * this will be searched for a namespace - * @param {number} [namespace=NS_MAIN] If given, will used as default namespace for the given title - * @throws {Error} When the title is invalid */ - function Title( title, namespace ) { - var parsed = parse( title, namespace ); - if ( !parsed ) { - throw new Error( 'Unable to parse title' ); - } - - this.namespace = parsed.namespace; - this.title = parsed.title; - this.ext = parsed.ext; - this.fragment = parsed.fragment; - } /* Private members */ - // eslint-disable-next-line vars-on-top var namespaceIds = mw.config.get( 'wgNamespaceIds' ), @@ -458,6 +439,25 @@ return trimToByteLength( name, FILENAME_MAX_BYTES - extension.length - 1 ) + '.' + extension; }; + /** + * @method constructor + * @param {string} title Title of the page. If no second argument given, + * this will be searched for a namespace + * @param {number} [namespace=NS_MAIN] If given, will used as default namespace for the given title + * @throws {Error} When the title is invalid + */ + function Title( title, namespace ) { + var parsed = parse( title, namespace ); + if ( !parsed ) { + throw new Error( 'Unable to parse title' ); + } + + this.namespace = parsed.namespace; + this.title = parsed.title; + this.ext = parsed.ext; + this.fragment = parsed.fragment; + } + /* Static members */ /** -- 2.20.1