From: Matthias Mullie Date: Mon, 17 Jun 2013 20:23:35 +0000 (+0200) Subject: Pass along tagFilter to ContribsPager, it already expects it X-Git-Tag: 1.31.0-rc.0~19407^2 X-Git-Url: https://git.cyclocoop.org//%22?a=commitdiff_plain;h=a46f9755a5dcc27383b4ef0758102ab6d7cbe59f;p=lhc%2Fweb%2Fwiklou.git Pass along tagFilter to ContribsPager, it already expects it ContribsPager already has this below line: $this->tagFilter = isset( $options['tagfilter'] ) ? $options['tagfilter'] : false; The reason the code already works fine is because, in ChangeTags.php, there's this fallback: if ( $filter_tag === false ) { $filter_tag = $wgRequest->getVal( 'tagfilter' ); } Which essentially boils down to the same result as passing along tagfilter, which in SpecialContributions is read from $wgRequest, passed to ContribsPager, and (well, currently not) passed to ChangeTags Change-Id: I12c0336ae31c5524e41fa0087afe2ba104dc7d37 --- diff --git a/includes/specials/SpecialContributions.php b/includes/specials/SpecialContributions.php index 21becd66ec..2f37cb48db 100644 --- a/includes/specials/SpecialContributions.php +++ b/includes/specials/SpecialContributions.php @@ -175,6 +175,7 @@ class SpecialContributions extends SpecialPage { 'target' => $target, 'contribs' => $this->opts['contribs'], 'namespace' => $this->opts['namespace'], + 'tagfilter' => $this->opts['tagfilter'], 'year' => $this->opts['year'], 'month' => $this->opts['month'], 'deletedOnly' => $this->opts['deletedOnly'],