From: Aryeh Gregor <simetrical@users.mediawiki.org>
Date: Fri, 7 Dec 2007 04:21:35 +0000 (+0000)
Subject: Make it a little clearer in the code that we aren't using STDERR outside command... 
X-Git-Tag: 1.31.0-rc.0~50514
X-Git-Url: https://git.cyclocoop.org//%22?a=commitdiff_plain;h=72736d11d4abbe0cdf84df39c5a81117ce3a68b8;p=lhc%2Fweb%2Fwiklou.git

Make it a little clearer in the code that we aren't using STDERR outside command-line mode, by inlining a one-line function that was only called once in the code base.
---

diff --git a/includes/Exception.php b/includes/Exception.php
index 1ae28deeca..3756fb7f1e 100644
--- a/includes/Exception.php
+++ b/includes/Exception.php
@@ -92,18 +92,13 @@ class MWException extends Exception
 		}
 	}
 
-	/** Print the exception report using text */
-	function reportText() {
-		fwrite( STDERR, $this->getText() );
-	}
-
 	/* Output a report about the exception and takes care of formatting.
 	 * It will be either HTML or plain text based on $wgCommandLineMode.
 	 */
 	function report() {
 		global $wgCommandLineMode;
 		if ( $wgCommandLineMode ) {
-			$this->reportText();
+			fwrite( STDERR, $this->getText() );
 		} else {
 			$log = $this->getLogMessage();
 			if ( $log ) {