From: Aaron Schulz <aschulz@wikimedia.org>
Date: Tue, 8 May 2018 21:58:01 +0000 (-0700)
Subject: resourceloader: Remove AJAX call from addScript() in mediawiki.js
X-Git-Tag: 1.34.0-rc.0~5482^2
X-Git-Url: https://git.cyclocoop.org//%22?a=commitdiff_plain;h=42956b99b558294e5aa8c6c0e2a8f18513478022;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Remove AJAX call from addScript() in mediawiki.js

Bug: T192623
Change-Id: If38376cb987c273b9991129df8f9a2ae04cfa4ed
---

diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js
index 598293aa6f..b1e1da3347 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -1191,21 +1191,19 @@
 			 * @param {Function} [callback] Callback to run after request resolution
 			 */
 			function addScript( src, callback ) {
-				var promise = $.ajax( {
-					url: src,
-					dataType: 'script',
-					// Force jQuery behaviour to be for crossDomain. Otherwise jQuery would use
-					// XHR for a same domain request instead of <script>, which changes the request
-					// headers (potentially missing a cache hit), and reduces caching in general
-					// since browsers cache XHR much less (if at all). And XHR means we retrieve
-					// text, so we'd need to $.globalEval, which then messes up line numbers.
-					crossDomain: true,
-					cache: true
-				} );
-
-				if ( callback ) {
-					promise.always( callback );
-				}
+				var script = document.createElement( 'script' );
+				script.src = src;
+				script.onload = script.onerror = function () {
+					if ( script.parentNode ) {
+						script.parentNode.removeChild( script );
+					}
+					script = null;
+					if ( callback ) {
+						callback();
+						callback = null;
+					}
+				};
+				document.head.appendChild( script );
 			}
 
 			/**